yujunjun/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2025-09-27 09:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: notifier disposed but in use (#6586)

Browse Source
This commit is contained in:
Mathias Mogensen 2024-10-21 00:21:25 +02:00 committed by GitHub
parent 6340174927
commit 1d9876a6eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/appflowy_flutter/lib/workspace/presentation/command_palette/command_palette.dart
View File

@ -56,7 +56,7 @@ class _CommandPaletteController extends StatefulWidget {
} }
class _CommandPaletteControllerState extends State<_CommandPaletteController> { class _CommandPaletteControllerState extends State<_CommandPaletteController> {
late final ValueNotifier<bool> _toggleNotifier = widget.notifier; late ValueNotifier<bool> _toggleNotifier = widget.notifier;
bool _isOpen = false; bool _isOpen = false;
@override @override
@ -71,6 +71,16 @@ class _CommandPaletteControllerState extends State<_CommandPaletteController> {
super.dispose(); super.dispose();
} }
@override
void didUpdateWidget(_CommandPaletteController oldWidget) {
if (oldWidget.notifier != widget.notifier) {
oldWidget.notifier.removeListener(_onToggle);
_toggleNotifier = widget.notifier;
_toggleNotifier.addListener(_onToggle);
}
super.didUpdateWidget(oldWidget);
}
void _onToggle() { void _onToggle() {
if (_toggleNotifier.value && !_isOpen) { if (_toggleNotifier.value && !_isOpen) {
_isOpen = true; _isOpen = true;