From 510752868d77b426cd3e83ca95af90ba0c06f940 Mon Sep 17 00:00:00 2001 From: nathan Date: Sun, 11 Aug 2024 15:16:02 +0800 Subject: [PATCH] chore: fix flutter wanrings --- .../presentation/home/tabs/flowy_tab.dart | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart index 52007a3df7..a871d91565 100644 --- a/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart +++ b/frontend/appflowy_flutter/lib/workspace/presentation/home/tabs/flowy_tab.dart @@ -2,7 +2,6 @@ import 'package:appflowy/generated/flowy_svgs.g.dart'; import 'package:appflowy/workspace/application/tabs/tabs_bloc.dart'; import 'package:appflowy/workspace/presentation/home/home_sizes.dart'; import 'package:appflowy/workspace/presentation/home/home_stack.dart'; -import 'package:flowy_infra/theme_extension.dart'; import 'package:flowy_infra_ui/style_widget/hover.dart'; import 'package:flowy_infra_ui/style_widget/icon_button.dart'; import 'package:flutter/material.dart'; @@ -23,13 +22,12 @@ class FlowyTab extends StatefulWidget { } class _FlowyTabState extends State { - @override Widget build(BuildContext context) { return FlowyHover( - style: HoverStyle( + isSelected: () => widget.isCurrent, + style: const HoverStyle( borderRadius: BorderRadius.zero, - backgroundColor: _getBackgroundColor(), ), builder: (context, onHover) { return ChangeNotifierProvider.value( @@ -70,18 +68,6 @@ class _FlowyTabState extends State { ); } - Color _getBackgroundColor() { - if (widget.isCurrent) { - return Theme.of(context).colorScheme.onSecondaryContainer; - } - - if (_isHovering) { - return AFThemeExtension.of(context).lightGreyHover; - } - - return Theme.of(context).colorScheme.surfaceContainerHighest; - } - void _closeTab([TapUpDetails? details]) => context .read() .add(TabsEvent.closeTab(widget.pageManager.plugin.id));