chore: adjust Toggle widget's onChanged callback (#6556)

This commit is contained in:
Richard Shiue 2024-10-16 14:39:46 +08:00 committed by GitHub
parent e86d812ee6
commit 6cc8c81e3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
12 changed files with 16 additions and 16 deletions

View File

@ -335,7 +335,7 @@ Widget _toggleItem({
const Spacer(), const Spacer(),
Toggle( Toggle(
value: value, value: value,
onChanged: (value) => onToggle(!value), onChanged: (value) => onToggle(value),
padding: EdgeInsets.zero, padding: EdgeInsets.zero,
), ),
], ],

View File

@ -52,12 +52,12 @@ class _DateCellEditor extends State<DateCellEditor> {
includeTime: state.includeTime, includeTime: state.includeTime,
rebuildOnDaySelected: false, rebuildOnDaySelected: false,
onIncludeTimeChanged: (value) => onIncludeTimeChanged: (value) =>
dateCellBloc.add(DateCellEditorEvent.setIncludeTime(!value)), dateCellBloc.add(DateCellEditorEvent.setIncludeTime(value)),
isRange: state.isRange, isRange: state.isRange,
startDay: state.isRange ? state.startDay : null, startDay: state.isRange ? state.startDay : null,
endDay: state.isRange ? state.endDay : null, endDay: state.isRange ? state.endDay : null,
onIsRangeChanged: (value) => onIsRangeChanged: (value) =>
dateCellBloc.add(DateCellEditorEvent.setIsRange(!value)), dateCellBloc.add(DateCellEditorEvent.setIsRange(value)),
dateFormat: state.dateTypeOptionPB.dateFormat, dateFormat: state.dateTypeOptionPB.dateFormat,
timeFormat: state.dateTypeOptionPB.timeFormat, timeFormat: state.dateTypeOptionPB.timeFormat,
selectedDay: state.dateTime, selectedDay: state.dateTime,

View File

@ -41,7 +41,7 @@ class MediaTypeOptionEditorFactory implements TypeOptionEditorFactory {
value: typeOption.hideFileNames, value: typeOption.hideFileNames,
onChanged: (value) { onChanged: (value) {
onTypeOptionUpdated( onTypeOptionUpdated(
_toggleHideFiles(typeOption, !value).writeToBuffer(), _toggleHideFiles(typeOption, value).writeToBuffer(),
); );
}, },
padding: EdgeInsets.zero, padding: EdgeInsets.zero,

View File

@ -34,7 +34,7 @@ class TimestampTypeOptionEditorFactory implements TypeOptionEditorFactory {
onChanged: (value) { onChanged: (value) {
final newTypeOption = _updateTypeOption( final newTypeOption = _updateTypeOption(
typeOption: typeOption, typeOption: typeOption,
includeTime: !value, includeTime: value,
); );
onTypeOptionUpdated(newTypeOption.writeToBuffer()); onTypeOptionUpdated(newTypeOption.writeToBuffer());
}, },

View File

@ -72,7 +72,7 @@ class DatabaseGroupList extends StatelessWidget {
Toggle( Toggle(
value: !state.layoutSettings.hideUngroupedColumn, value: !state.layoutSettings.hideUngroupedColumn,
onChanged: (value) => onChanged: (value) =>
_updateLayoutSettings(state.layoutSettings, value), _updateLayoutSettings(state.layoutSettings, !value),
padding: EdgeInsets.zero, padding: EdgeInsets.zero,
), ),
], ],

View File

@ -155,7 +155,7 @@ class LocalAIChatSettingHeader extends StatelessWidget {
const Spacer(), const Spacer(),
Toggle( Toggle(
value: isEnabled, value: isEnabled,
onChanged: (value) { onChanged: (_) {
context context
.read<LocalAIChatToggleBloc>() .read<LocalAIChatToggleBloc>()
.add(const LocalAIChatToggleEvent.toggle()); .add(const LocalAIChatToggleEvent.toggle());

View File

@ -106,7 +106,7 @@ class LocalAISettingHeader extends StatelessWidget {
const Spacer(), const Spacer(),
Toggle( Toggle(
value: isEnabled, value: isEnabled,
onChanged: (value) { onChanged: (_) {
if (isEnabled) { if (isEnabled) {
showConfirmDialog( showConfirmDialog(
context: context, context: context,

View File

@ -437,7 +437,7 @@ class EnableRTLItemsSwitcher extends StatelessWidget {
.enableRtlToolbarItems, .enableRtlToolbarItems,
onChanged: (value) => context onChanged: (value) => context
.read<AppearanceSettingsCubit>() .read<AppearanceSettingsCubit>()
.setEnableRTLToolbarItems(!value), .setEnableRTLToolbarItems(value),
), ),
], ],
); );
@ -582,8 +582,8 @@ class _TimeFormatSwitcher extends StatelessWidget {
onChanged: (value) => onChanged: (value) =>
context.read<AppearanceSettingsCubit>().setTimeFormat( context.read<AppearanceSettingsCubit>().setTimeFormat(
value value
? UserTimeFormatPB.TwelveHour ? UserTimeFormatPB.TwentyFourHour
: UserTimeFormatPB.TwentyFourHour, : UserTimeFormatPB.TwelveHour,
), ),
), ),
], ],

View File

@ -322,7 +322,7 @@ class AppFlowyCloudEnableSync extends StatelessWidget {
value: state.setting.enableSync, value: state.setting.enableSync,
onChanged: (value) => context onChanged: (value) => context
.read<AppFlowyCloudSettingBloc>() .read<AppFlowyCloudSettingBloc>()
.add(AppFlowyCloudSettingEvent.enableSync(!value)), .add(AppFlowyCloudSettingEvent.enableSync(value)),
), ),
], ],
); );

View File

@ -26,7 +26,7 @@ class SettingsNotificationsView extends StatelessWidget {
trailing: [ trailing: [
Toggle( Toggle(
value: state.isNotificationsEnabled, value: state.isNotificationsEnabled,
onChanged: (value) => context onChanged: (_) => context
.read<NotificationSettingsCubit>() .read<NotificationSettingsCubit>()
.toggleNotificationsEnabled(), .toggleNotificationsEnabled(),
), ),

View File

@ -186,8 +186,8 @@ class _AnimatedDatePickerState extends State<_AnimatedDatePicker> {
child: AppFlowyDatePicker( child: AppFlowyDatePicker(
includeTime: _includeTime, includeTime: _includeTime,
onIncludeTimeChanged: (includeTime) { onIncludeTimeChanged: (includeTime) {
widget.options.onIncludeTimeChanged.call(!includeTime); widget.options.onIncludeTimeChanged.call(includeTime);
setState(() => _includeTime = !includeTime); setState(() => _includeTime = includeTime);
}, },
enableRanges: widget.options.enableRanges, enableRanges: widget.options.enableRanges,
isRange: widget.options.isRange, isRange: widget.options.isRange,

View File

@ -56,7 +56,7 @@ class Toggle extends StatelessWidget {
: inactiveBackgroundColor ?? : inactiveBackgroundColor ??
AFThemeExtension.of(context).toggleButtonBGColor; AFThemeExtension.of(context).toggleButtonBGColor;
return GestureDetector( return GestureDetector(
onTap: () => onChanged(value), onTap: () => onChanged(!value),
child: Padding( child: Padding(
padding: padding, padding: padding,
child: Stack( child: Stack(