yujunjun/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2025-11-25 14:51:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(flutter_desktop): clicking on empty space when editing a cell sho… (#6949)

Browse Source 
* fix(flutter_desktop): clicking on empty space when editing a cell shouldn't close event card

* test: fix integration tests
This commit is contained in:
Richard Shiue 2024-12-09 15:13:37 +08:00 committed by GitHub
parent d21c0c0dfc
commit 7b93bbe5ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/appflowy_flutter/integration_test/desktop/database/database_calendar_test.dart
View File

@ -301,6 +301,7 @@ void main() {
await tester.createOption(name: "qwer"); await tester.createOption(name: "qwer");
await tester.selectOption(name: "asdf"); await tester.selectOption(name: "asdf");
await tester.dismissCellEditor(); await tester.dismissCellEditor();
await tester.dismissCellEditor();
await tester.tapDatabaseFilterButton(); await tester.tapDatabaseFilterButton();
await tester.tapCreateFilterByFieldType(FieldType.MultiSelect, "Tags"); await tester.tapCreateFilterByFieldType(FieldType.MultiSelect, "Tags");
@ -332,6 +333,7 @@ void main() {
await tester.tapButton(finderForFieldType(FieldType.MultiSelect)); await tester.tapButton(finderForFieldType(FieldType.MultiSelect));
await tester.selectOption(name: "asdf"); await tester.selectOption(name: "asdf");
await tester.dismissCellEditor(); await tester.dismissCellEditor();
await tester.dismissCellEditor();
tester.assertNumberOfEventsInCalendar(0); tester.assertNumberOfEventsInCalendar(0);

1
frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_date_cell.dart
View File

@ -31,6 +31,7 @@ class DesktopRowDetailDateCellSkin extends IEditableDateCellSkin {
direction: PopoverDirection.bottomWithLeftAligned, direction: PopoverDirection.bottomWithLeftAligned,
constraints: BoxConstraints.loose(const Size(260, 620)), constraints: BoxConstraints.loose(const Size(260, 620)),
margin: EdgeInsets.zero, margin: EdgeInsets.zero,
asBarrier: true,
child: Container( child: Container(
alignment: AlignmentDirectional.centerStart, alignment: AlignmentDirectional.centerStart,
padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 6), padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 6),

2
frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_media_cell.dart
View File

@ -252,6 +252,7 @@ class _AddFileButtonState extends State<_AddFileButton> {
direction: widget.direction, direction: widget.direction,
constraints: const BoxConstraints(maxWidth: _menuWidth), constraints: const BoxConstraints(maxWidth: _menuWidth),
margin: EdgeInsets.zero, margin: EdgeInsets.zero,
asBarrier: true,
onClose: () => onClose: () =>
context.read<EditorDropManagerState>().remove(_dropFileKey), context.read<EditorDropManagerState>().remove(_dropFileKey),
popupBuilder: (_) { popupBuilder: (_) {
@ -458,6 +459,7 @@ class _FilePreviewRenderState extends State<_FilePreviewRender> {
offset: const Offset(0, 5), offset: const Offset(0, 5),
triggerActions: PopoverTriggerFlags.none, triggerActions: PopoverTriggerFlags.none,
onClose: () => setState(() => isSelected = false), onClose: () => setState(() => isSelected = false),
asBarrier: true,
popupBuilder: (popoverContext) => MultiBlocProvider( popupBuilder: (popoverContext) => MultiBlocProvider(
providers: [ providers: [
BlocProvider.value(value: context.read<RowDetailBloc>()), BlocProvider.value(value: context.read<RowDetailBloc>()),

1
frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_relation_cell.dart
View File

@ -24,6 +24,7 @@ class DesktopRowDetailRelationCellSkin extends IEditableRelationCellSkin {
direction: PopoverDirection.bottomWithLeftAligned, direction: PopoverDirection.bottomWithLeftAligned,
constraints: const BoxConstraints(maxWidth: 400, maxHeight: 400), constraints: const BoxConstraints(maxWidth: 400, maxHeight: 400),
margin: EdgeInsets.zero, margin: EdgeInsets.zero,
asBarrier: true,
onClose: () => cellContainerNotifier.isFocus = false, onClose: () => cellContainerNotifier.isFocus = false,
popupBuilder: (context) { popupBuilder: (context) {
return BlocProvider.value( return BlocProvider.value(

1
frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_select_option_cell.dart
View File

@ -25,6 +25,7 @@ class DesktopRowDetailSelectOptionCellSkin
controller: popoverController, controller: popoverController,
constraints: const BoxConstraints.tightFor(width: 300), constraints: const BoxConstraints.tightFor(width: 300),
margin: EdgeInsets.zero, margin: EdgeInsets.zero,
asBarrier: true,
triggerActions: PopoverTriggerFlags.none, triggerActions: PopoverTriggerFlags.none,
direction: PopoverDirection.bottomWithLeftAligned, direction: PopoverDirection.bottomWithLeftAligned,
onClose: () => cellContainerNotifier.isFocus = false, onClose: () => cellContainerNotifier.isFocus = false,