yujunjun/AppFlowy
1
0
Fork 0
mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2025-10-31 10:03:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: multi scrollview warning

Browse Source
This commit is contained in:
appflowy 2022-08-13 11:57:14 +08:00
parent 28e77ae68c
commit f6263f758f
6 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/app_flowy/lib/plugins/board/application/board_bloc.dart
View File

@ -207,3 +207,8 @@ class BoardColumnItem extends AFColumnItem {
@override @override
String get id => row.id; String get id => row.id;
} }
class CreateCardItem extends AFColumnItem {
@override
String get id => '$CreateCardItem';
}

4
frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart
View File

@ -89,8 +89,8 @@ class BoardDataController {
); );
} }
void createRow() { Future<Either<RowPB, FlowyError>> createRow() {
_gridFFIService.createRow(); return _gridFFIService.createRow();
} }
Future<void> dispose() async { Future<void> dispose() async {

2
frontend/app_flowy/lib/plugins/board/board.dart
View File

@ -31,7 +31,7 @@ class BoardPluginBuilder implements PluginBuilder {
class BoardPluginConfig implements PluginConfig { class BoardPluginConfig implements PluginConfig {
@override @override
bool get creatable => true; bool get creatable => false;
} }
class BoardPlugin extends Plugin { class BoardPlugin extends Plugin {

3
frontend/app_flowy/lib/plugins/board/presentation/board_page.dart
View File

@ -54,10 +54,11 @@ class BoardContent extends StatelessWidget {
padding: const EdgeInsets.symmetric(vertical: 10, horizontal: 20), padding: const EdgeInsets.symmetric(vertical: 10, horizontal: 20),
child: AFBoard( child: AFBoard(
key: UniqueKey(), key: UniqueKey(),
scrollController: ScrollController(),
dataController: context.read<BoardBloc>().boardDataController, dataController: context.read<BoardBloc>().boardDataController,
headerBuilder: _buildHeader, headerBuilder: _buildHeader,
footBuilder: _buildFooter, footBuilder: _buildFooter,
cardBuilder: _buildCard, cardBuilder: (_, data) => _buildCard(context, data),
columnConstraints: const BoxConstraints.tightFor(width: 240), columnConstraints: const BoxConstraints.tightFor(width: 240),
config: AFBoardConfig( config: AFBoardConfig(
columnBackgroundColor: HexColor.fromHex('#F7F8FC'), columnBackgroundColor: HexColor.fromHex('#F7F8FC'),

3
frontend/app_flowy/lib/plugins/board/presentation/card/card.dart
View File

@ -3,6 +3,7 @@ import 'package:app_flowy/plugins/board/application/card/card_data_controller.da
import 'package:app_flowy/plugins/grid/application/cell/cell_service/cell_service.dart'; import 'package:app_flowy/plugins/grid/application/cell/cell_service/cell_service.dart';
import 'package:flowy_infra/image.dart'; import 'package:flowy_infra/image.dart';
import 'package:flowy_infra/theme.dart'; import 'package:flowy_infra/theme.dart';
import 'package:flowy_sdk/log.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart'; import 'package:flutter_bloc/flutter_bloc.dart';
import 'card_cell_builder.dart'; import 'card_cell_builder.dart';
@ -79,6 +80,6 @@ class _CardMoreOption extends StatelessWidget with CardAccessory {
@override @override
void onTap(BuildContext context) { void onTap(BuildContext context) {
print('show options'); Log.debug('show options');
} }
} }

4
frontend/app_flowy/packages/appflowy_board/lib/src/widgets/board.dart
View File

@ -46,6 +46,8 @@ class AFBoard extends StatelessWidget {
/// ///
final BoardPhantomController phantomController; final BoardPhantomController phantomController;
final ScrollController? scrollController;
final AFBoardConfig config; final AFBoardConfig config;
AFBoard({ AFBoard({
@ -54,6 +56,7 @@ class AFBoard extends StatelessWidget {
this.background, this.background,
this.footBuilder, this.footBuilder,
this.headerBuilder, this.headerBuilder,
this.scrollController,
this.columnConstraints = const BoxConstraints(maxWidth: 200), this.columnConstraints = const BoxConstraints(maxWidth: 200),
this.config = const AFBoardConfig(), this.config = const AFBoardConfig(),
Key? key, Key? key,
@ -69,6 +72,7 @@ class AFBoard extends StatelessWidget {
return BoardContent( return BoardContent(
config: config, config: config,
dataController: dataController, dataController: dataController,
scrollController: scrollController,
background: background, background: background,
delegate: phantomController, delegate: phantomController,
columnConstraints: columnConstraints, columnConstraints: columnConstraints,