From f9fbf622830a58c7906f73fa61b9e15cabf3fb89 Mon Sep 17 00:00:00 2001 From: Richard Shiue <71320345+richardshiue@users.noreply.github.com> Date: Tue, 8 Oct 2024 16:33:48 +0800 Subject: [PATCH] test: fix flaky sort editor bloc test (#6504) * test: fix flaky sort test * test: experiment * test: remove loops --- frontend/appflowy_flutter/pubspec.lock | 12 ++++++------ .../grid_test/sort/sort_editor_bloc_test.dart | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/frontend/appflowy_flutter/pubspec.lock b/frontend/appflowy_flutter/pubspec.lock index 744d039b5e..8e27e7709b 100644 --- a/frontend/appflowy_flutter/pubspec.lock +++ b/frontend/appflowy_flutter/pubspec.lock @@ -1535,10 +1535,10 @@ packages: dependency: transitive description: name: platform - sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65" + sha256: "12220bb4b65720483f8fa9450b4332347737cf8213dd2840d8b2c823e47243ec" url: "https://pub.dev" source: hosted - version: "3.1.5" + version: "3.1.4" plugin_platform_interface: dependency: "direct dev" description: @@ -1933,10 +1933,10 @@ packages: dependency: transitive description: name: string_scanner - sha256: "688af5ed3402a4bde5b3a6c15fd768dbf2621a614950b17f04626c431ab3c4c3" + sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde" url: "https://pub.dev" source: hosted - version: "1.3.0" + version: "1.2.0" string_validator: dependency: "direct main" description: @@ -2238,10 +2238,10 @@ packages: dependency: transitive description: name: vm_service - sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" + sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec" url: "https://pub.dev" source: hosted - version: "14.2.5" + version: "14.2.1" watcher: dependency: transitive description: diff --git a/frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart b/frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart index 7a2fcbb119..585a08c281 100644 --- a/frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart +++ b/frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart @@ -105,9 +105,9 @@ void main() { test('reorder sorts', () async { final selectOptionField = getFirstFieldByType(FieldType.SingleSelect); final checkboxField = getFirstFieldByType(FieldType.Checkbox); - sortBloc - ..add(SortEditorEvent.createSort(fieldId: selectOptionField.id)) - ..add(SortEditorEvent.createSort(fieldId: checkboxField.id)); + sortBloc.add(SortEditorEvent.createSort(fieldId: selectOptionField.id)); + await gridResponseFuture(); + sortBloc.add(SortEditorEvent.createSort(fieldId: checkboxField.id)); await gridResponseFuture(); expect(sortBloc.state.sorts[0].fieldId, selectOptionField.id);