From 5cdc49423ff5711a3e59ad5c3573f9a259b714a2 Mon Sep 17 00:00:00 2001 From: hanhainebula <2512674094@qq.com> Date: Fri, 7 Feb 2025 20:18:10 +0800 Subject: [PATCH 1/2] fix beir eval bug: corpus_embd_save_dir is None --- FlagEmbedding/evaluation/beir/evaluator.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/FlagEmbedding/evaluation/beir/evaluator.py b/FlagEmbedding/evaluation/beir/evaluator.py index b960ba3..9d4fdd4 100644 --- a/FlagEmbedding/evaluation/beir/evaluator.py +++ b/FlagEmbedding/evaluation/beir/evaluator.py @@ -87,7 +87,8 @@ class BEIREvaluator(AbsEvaluator): if sub_dataset_names is None: if dataset_name is not None: save_name = f"{dataset_name}-" + "{split}.json" - corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name) + if corpus_embd_save_dir is not None: + corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name) else: save_name = "{split}.json" @@ -213,7 +214,8 @@ class BEIREvaluator(AbsEvaluator): for sub_dataset_name in sub_dataset_names: if dataset_name is not None: save_name = f"{dataset_name}-{sub_dataset_name}-" + "{split}.json" - corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name, sub_dataset_name) + if corpus_embd_save_dir is not None: + corpus_embd_save_dir = os.path.join(corpus_embd_save_dir, str(retriever), dataset_name, sub_dataset_name) else: save_name = f"{sub_dataset_name}-" + "{split}.json" From 0921c45cf0b293e4ccc291a837545fe4f20351ce Mon Sep 17 00:00:00 2001 From: hanhainebula <2512674094@qq.com> Date: Fri, 7 Feb 2025 20:18:54 +0800 Subject: [PATCH 2/2] release version 1.3.4 --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index ea1f178..4b60c5f 100644 --- a/setup.py +++ b/setup.py @@ -5,7 +5,7 @@ with open("README.md", mode="r", encoding="utf-8") as readme_file: setup( name='FlagEmbedding', - version='1.3.3', + version='1.3.4', description='FlagEmbedding', long_description=readme, long_description_content_type="text/markdown", @@ -16,7 +16,7 @@ setup( install_requires=[ 'torch>=1.6.0', 'transformers>=4.44.2', - 'datasets==2.19.0', + 'datasets>=2.19.0', 'accelerate>=0.20.1', 'sentence_transformers', 'peft',