From b178040b79ede8cc3e92a9de6f4606c4e8f9c1fe Mon Sep 17 00:00:00 2001
From: Daniel Kleine <53251018+d-kleine@users.noreply.github.com>
Date: Fri, 7 Jun 2024 13:52:05 +0200
Subject: [PATCH] fixed code (#197)

---
 ch07/03_model-evaluation/llm-instruction-eval-ollama.ipynb | 7 +++----
 ch07/03_model-evaluation/llm-instruction-eval-openai.ipynb | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/ch07/03_model-evaluation/llm-instruction-eval-ollama.ipynb b/ch07/03_model-evaluation/llm-instruction-eval-ollama.ipynb
index 40213a4..68f6d67 100644
--- a/ch07/03_model-evaluation/llm-instruction-eval-ollama.ipynb
+++ b/ch07/03_model-evaluation/llm-instruction-eval-ollama.ipynb
@@ -286,8 +286,6 @@
     }
    ],
    "source": [
-    "import json\n",
-    "\n",
     "json_file = \"eval-example-data.json\"\n",
     "\n",
     "with open(json_file, \"r\") as file:\n",
@@ -628,6 +626,8 @@
     }
    ],
    "source": [
+    "from pathlib import Path\n",
+    "\n",
     "for model in (\"model 1 response\", \"model 2 response\"):\n",
     "\n",
     "    scores = generate_model_scores(json_data, model)\n",
@@ -636,8 +636,7 @@
     "    print(f\"Average score: {sum(scores)/len(scores):.2f}\\n\")\n",
     "\n",
     "    # Optionally save the scores\n",
-    "    from pathlib import Path\n",
-    "    save_path = (Path(\"scores\")/f\"llama3-8b-{model}.json\").replace(\" \", \"-\")\n",
+    "    save_path = Path(\"scores\") / f\"llama3-8b-{model.replace(' ', '-')}.json\"\n",
     "    with open(save_path, \"w\") as file:\n",
     "        json.dump(scores, file)"
    ]
diff --git a/ch07/03_model-evaluation/llm-instruction-eval-openai.ipynb b/ch07/03_model-evaluation/llm-instruction-eval-openai.ipynb
index 956bff4..60d3a09 100644
--- a/ch07/03_model-evaluation/llm-instruction-eval-openai.ipynb
+++ b/ch07/03_model-evaluation/llm-instruction-eval-openai.ipynb
@@ -205,8 +205,6 @@
     }
    ],
    "source": [
-    "import json\n",
-    "\n",
     "json_file = \"eval-example-data.json\"\n",
     "\n",
     "with open(json_file, \"r\") as file:\n",
@@ -524,6 +522,8 @@
     }
    ],
    "source": [
+    "from pathlib import Path\n",
+    "\n",
     "for model in (\"model 1 response\", \"model 2 response\"):\n",
     "\n",
     "    scores = generate_model_scores(json_data, model, client)\n",
@@ -532,8 +532,7 @@
     "    print(f\"Average score: {sum(scores)/len(scores):.2f}\\n\")\n",
     "\n",
     "    # Optionally save the scores\n",
-    "    from pathlib import Path\n",
-    "    save_path = (Path(\"scores\")/f\"gpt4-{model}.json\").replace(\" \", \"-\")\n",
+    "    save_path = Path(\"scores\") / f\"gpt4-{model.replace(' ', '-')}.json\"\n",
     "    with open(save_path, \"w\") as file:\n",
     "        json.dump(scores, file)"
    ]