From 005d902b1008be40c6050549a0d564db16c1e3ac Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Tue, 14 Oct 2025 22:07:46 +0530 Subject: [PATCH] Enhance NoProfilerBanner component with data-testid attributes and update related tests --- .../NoProfilerBanner/NoProfilerBanner.component.tsx | 6 ++++-- .../NoProfilerBanner/NoProfilerBanner.test.tsx | 6 +++++- .../Profiler/TableProfiler/SingleColumnProfile.test.tsx | 2 +- .../src/components/IncidentManager/IncidentManager.test.tsx | 2 +- .../src/main/resources/ui/src/test/unit/mocks/mui.mock.js | 3 +++ 5 files changed, 14 insertions(+), 5 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.component.tsx index 8f08c43bed2..f1b8726cfa9 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.component.tsx @@ -48,8 +48,10 @@ const NoProfilerBanner = () => { -

{t('message.no-profiler-title')}

-

+

+ {t('message.no-profiler-title')} +

+

{t('message.no-profiler-message')}

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.test.tsx index 312744cc8dc..b43ce9a58c6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/NoProfilerBanner/NoProfilerBanner.test.tsx @@ -12,6 +12,7 @@ */ import { render, screen } from '@testing-library/react'; import { MemoryRouter } from 'react-router-dom'; +import '../../../../../test/unit/mocks/mui.mock'; import NoProfilerBanner from './NoProfilerBanner.component'; jest.mock('react-router-dom', () => ({ @@ -30,7 +31,10 @@ describe('NoProfilerBanner', () => { expect( await screen.findByTestId('no-profiler-placeholder') ).toBeInTheDocument(); - expect(await screen.findByTestId('error-msg')).toBeInTheDocument(); + expect(await screen.findByTestId('profiler-title')).toBeInTheDocument(); + expect( + await screen.findByTestId('profiler-description') + ).toBeInTheDocument(); expect(await screen.findByTestId('documentation-link')).toBeInTheDocument(); }); }); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/SingleColumnProfile.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/SingleColumnProfile.test.tsx index 55387e6d617..d32d0490678 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/SingleColumnProfile.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/SingleColumnProfile.test.tsx @@ -14,13 +14,13 @@ import { render, screen, waitFor } from '@testing-library/react'; import { AxiosError } from 'axios'; import { DateRangeObject } from 'Models'; -import '../../../../../test/unit/mocks/mui.mock'; import { OperationPermission } from '../../../../context/PermissionProvider/PermissionProvider.interface'; import { ColumnProfile } from '../../../../generated/entity/data/container'; import { Table } from '../../../../generated/entity/data/table'; import { Operation } from '../../../../generated/entity/policies/accessControl/resourcePermission'; import { DataType } from '../../../../generated/tests/testDefinition'; import { getColumnProfilerList } from '../../../../rest/tableAPI'; +import '../../../../test/unit/mocks/mui.mock'; import { showErrorToast } from '../../../../utils/ToastUtils'; import SingleColumnProfile from './SingleColumnProfile'; import { useTableProfiler } from './TableProfilerProvider'; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManager.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManager.test.tsx index e96ddfc71e8..3f0a7567a72 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManager.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/IncidentManager/IncidentManager.test.tsx @@ -13,10 +13,10 @@ import { fireEvent, render, screen } from '@testing-library/react'; import QueryString from 'qs'; import { act } from 'react'; -import '../../../test/unit/mocks/mui.mock'; import { Table } from '../../generated/entity/data/table'; import { MOCK_PERMISSIONS } from '../../mocks/Glossary.mock'; import { getListTestCaseIncidentStatusFromSearch } from '../../rest/incidentManagerAPI'; +import '../../test/unit/mocks/mui.mock'; import IncidentManager from './IncidentManager.component'; jest.mock('../common/NextPrevious/NextPrevious', () => { diff --git a/openmetadata-ui/src/main/resources/ui/src/test/unit/mocks/mui.mock.js b/openmetadata-ui/src/main/resources/ui/src/test/unit/mocks/mui.mock.js index 3fb8a2df6c6..0de2c89d7d0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/test/unit/mocks/mui.mock.js +++ b/openmetadata-ui/src/main/resources/ui/src/test/unit/mocks/mui.mock.js @@ -11,6 +11,9 @@ * limitations under the License. */ +import React from 'react'; +window.React = React; + /** * Global mock for Material-UI (MUI) components * This mock resolves Jest compatibility issues with MUI Grid v2 and theme context