yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 04:29:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #915 - Fix version number to single digit precision

Browse Source
This commit is contained in:
sureshms 2021-10-24 09:30:26 -07:00
parent b584382c65
commit 01129ef037
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java
View File

@ -247,9 +247,9 @@ public abstract class EntityRepository<T> {
public final Double getNewVersion(Double oldVersion) {
Double newVersion = oldVersion;
if (majorVersionChange) {
newVersion = oldVersion + 1.0;
newVersion = Math.round((oldVersion + 1.0) * 10.0)/10.0;
} else if (!fieldsUpdated.isEmpty() || !fieldsAdded.isEmpty() || !fieldsDeleted.isEmpty()) {
newVersion = oldVersion + 0.1;
newVersion = Math.round((oldVersion + 0.1) * 10.0)/10.0;
}
LOG.info("{}->{} - Fields added {}, updated {}, deleted {}",
oldVersion, newVersion, fieldsAdded, fieldsUpdated, fieldsDeleted);

4
catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java
View File

@ -296,9 +296,9 @@ public final class TestUtils {
if (updateType == UpdateType.NO_CHANGE) {
assertEquals(previousVersion, newVersion); // No change in the version
} else if (updateType == UpdateType.MINOR_UPDATE) {
assertEquals(previousVersion + 0.1, newVersion); // Minor version change
assertEquals(Math.round((previousVersion + 0.1) * 10.0)/10.0, newVersion); // Minor version change
} else if (updateType == UpdateType.MAJOR_UPDATE) {
assertEquals(previousVersion + 1.0, newVersion); // Minor version change
assertEquals(Math.round((previousVersion + 1.0) * 10.0)/10.0, newVersion); // Major version change
}
}
}