From 01129ef0373a6059631cf4da49280f17e47e5253 Mon Sep 17 00:00:00 2001 From: sureshms Date: Sun, 24 Oct 2021 09:30:26 -0700 Subject: [PATCH] Fixes #915 - Fix version number to single digit precision --- .../java/org/openmetadata/catalog/jdbi3/EntityRepository.java | 4 ++-- .../test/java/org/openmetadata/catalog/util/TestUtils.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java index 29b591ec3bc..756450f6161 100644 --- a/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java +++ b/catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/EntityRepository.java @@ -247,9 +247,9 @@ public abstract class EntityRepository { public final Double getNewVersion(Double oldVersion) { Double newVersion = oldVersion; if (majorVersionChange) { - newVersion = oldVersion + 1.0; + newVersion = Math.round((oldVersion + 1.0) * 10.0)/10.0; } else if (!fieldsUpdated.isEmpty() || !fieldsAdded.isEmpty() || !fieldsDeleted.isEmpty()) { - newVersion = oldVersion + 0.1; + newVersion = Math.round((oldVersion + 0.1) * 10.0)/10.0; } LOG.info("{}->{} - Fields added {}, updated {}, deleted {}", oldVersion, newVersion, fieldsAdded, fieldsUpdated, fieldsDeleted); diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java index 18e57eb3097..a31acc39d5a 100644 --- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java +++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/util/TestUtils.java @@ -296,9 +296,9 @@ public final class TestUtils { if (updateType == UpdateType.NO_CHANGE) { assertEquals(previousVersion, newVersion); // No change in the version } else if (updateType == UpdateType.MINOR_UPDATE) { - assertEquals(previousVersion + 0.1, newVersion); // Minor version change + assertEquals(Math.round((previousVersion + 0.1) * 10.0)/10.0, newVersion); // Minor version change } else if (updateType == UpdateType.MAJOR_UPDATE) { - assertEquals(previousVersion + 1.0, newVersion); // Minor version change + assertEquals(Math.round((previousVersion + 1.0) * 10.0)/10.0, newVersion); // Major version change } } }