yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-16 21:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: service connection config not getting updated with multiple project ids after ingestion (#20975)

Browse Source
This commit is contained in:
Keshav Mohta 2025-04-25 19:55:50 +05:30 committed by Keshav Mohta
parent 1eb83c2bde
commit 04aa358ec9
No known key found for this signature in database
GPG Key ID: 9481AB99C36FAE9C
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ingestion/src/metadata/ingestion/source/database/bigquery/helper.py
View File

@ -14,6 +14,7 @@ Source connection helper
""" """
import re import re
import traceback import traceback
from copy import deepcopy
from typing import Any, List, Tuple from typing import Any, List, Tuple
from pydantic import BaseModel from pydantic import BaseModel
@ -54,24 +55,25 @@ def get_inspector_details(
""" """
# TODO support location property in JSON Schema # TODO support location property in JSON Schema
# TODO support OAuth 2.0 scopes # TODO support OAuth 2.0 scopes
new_service_connection = deepcopy(service_connection)
kwargs = {} kwargs = {}
if isinstance(service_connection.credentials.gcpConfig, GcpCredentialsValues): if isinstance(new_service_connection.credentials.gcpConfig, GcpCredentialsValues):
service_connection.credentials.gcpConfig.projectId = SingleProjectId( new_service_connection.credentials.gcpConfig.projectId = SingleProjectId(
database_name database_name
) )
if service_connection.credentials.gcpImpersonateServiceAccount: if new_service_connection.credentials.gcpImpersonateServiceAccount:
kwargs[ kwargs[
"impersonate_service_account" "impersonate_service_account"
] = ( ] = (
service_connection.credentials.gcpImpersonateServiceAccount.impersonateServiceAccount new_service_connection.credentials.gcpImpersonateServiceAccount.impersonateServiceAccount
) )
kwargs[ kwargs[
"lifetime" "lifetime"
] = service_connection.credentials.gcpImpersonateServiceAccount.lifetime ] = new_service_connection.credentials.gcpImpersonateServiceAccount.lifetime
client = get_bigquery_client(project_id=database_name, **kwargs) client = get_bigquery_client(project_id=database_name, **kwargs)
engine = get_connection(service_connection) engine = get_connection(new_service_connection)
inspector = inspect(engine) inspector = inspect(engine)
return InspectorWrapper(client=client, engine=engine, inspector=inspector) return InspectorWrapper(client=client, engine=engine, inspector=inspector)