Fixes #14182: Search Index Application weekly schedule (#14200)

* fix: Search Index Application weekly schedule

* added comments

openmetadata-ui/src/main/resources/ui/src/components/Applications/AppSchedule/AppSchedule.component.tsx

@@ -158,6 +158,10 @@ const AppSchedule = ({
 
       return cronstrue.toString(cronExp, {
         throwExceptionOnParseError: false,
+        // Quartz cron format accepts 1-7 or SUN-SAT so need to increment index by 1
+        // Ref: https://www.quartz-scheduler.org/api/2.1.7/org/quartz/CronExpression.html
+        dayOfWeekStartIndexZero: false,
+        monthStartIndexZero: false,
       });
     }
 

openmetadata-ui/src/main/resources/ui/src/utils/CronUtils.test.ts

@@ -0,0 +1,96 @@
+/*
+ *  Copyright 2023 Collate.
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+import { getQuartzCronExpression } from './CronUtils';
+
+describe('getQuartzCronExpression function', () => {
+  it('should generate cron expression for every minute', () => {
+    const state = {
+      selectedPeriod: 'minute',
+      selectedMinOption: { min: 1 },
+      selectedHourOption: { min: 0 },
+      selectedDayOption: { min: 0, hour: 0 },
+      selectedWeekOption: { min: 0, hour: 0, dow: 0 },
+      selectedMonthOption: { min: 0, hour: 0, dom: 1 },
+      selectedYearOption: { min: 0, hour: 0, dom: 1, mon: 1 },
+    };
+
+    const result = getQuartzCronExpression(state);
+
+    expect(result).toEqual('0 0/1 * * * ?');
+  });
+
+  it('should generate cron expression for every hour', () => {
+    const state = {
+      selectedPeriod: 'hour',
+      selectedMinOption: { min: 0 },
+      selectedHourOption: { min: 0 },
+      selectedDayOption: { min: 0, hour: 0 },
+      selectedWeekOption: { min: 0, hour: 0, dow: 0 },
+      selectedMonthOption: { min: 0, hour: 0, dom: 1 },
+      selectedYearOption: { min: 0, hour: 0, dom: 1, mon: 1 },
+    };
+
+    const result = getQuartzCronExpression(state);
+
+    expect(result).toEqual('0 0 * * * ?');
+  });
+
+  it('should generate cron expression for specific time on a specific day of the month and month of the year', () => {
+    const state = {
+      selectedPeriod: 'year',
+      selectedMinOption: { min: 0 },
+      selectedHourOption: { min: 0 },
+      selectedDayOption: { min: 0, hour: 0 },
+      selectedWeekOption: { min: 0, hour: 0, dow: 0 },
+      selectedMonthOption: { min: 0, hour: 0, dom: 0 },
+      selectedYearOption: { min: 45, hour: 3, dom: 1, mon: 7 },
+    };
+
+    const result = getQuartzCronExpression(state);
+
+    expect(result).toEqual('0 45 3 1 7 ?');
+  });
+
+  it('should generate cron expression for specific time daily', () => {
+    const state = {
+      selectedPeriod: 'day',
+      selectedMinOption: { min: 0 },
+      selectedHourOption: { min: 0 },
+      selectedDayOption: { min: 15, hour: 8 },
+      selectedWeekOption: { min: 0, hour: 0, dow: 0 },
+      selectedMonthOption: { min: 0, hour: 0, dom: 0 },
+      selectedYearOption: { min: 45, hour: 3, dom: 1, mon: 7 },
+    };
+
+    const result = getQuartzCronExpression(state);
+
+    expect(result).toEqual('0 15 8 * * ?');
+  });
+
+  it('should generate cron expression for specific time on a specific day of the week', () => {
+    const state = {
+      selectedPeriod: 'week',
+      selectedMinOption: { min: 0 },
+      selectedHourOption: { min: 0 },
+      selectedDayOption: { min: 15, hour: 8 },
+      selectedWeekOption: { min: 30, hour: 10, dow: 3 },
+      selectedMonthOption: { min: 0, hour: 0, dom: 0 },
+      selectedYearOption: { min: 45, hour: 3, dom: 1, mon: 7 },
+    };
+
+    const result = getQuartzCronExpression(state);
+
+    expect(result).toEqual('0 30 10 ? * 4');
+  });
+});

openmetadata-ui/src/main/resources/ui/src/utils/CronUtils.ts

@@ -51,7 +51,11 @@ export const getQuartzCronExpression = (state: StateValue) => {
     case 'day':
       return `0 ${selectedDayOption.min} ${selectedDayOption.hour} * * ?`;
     case 'week':
-      return `0 ${selectedWeekOption.min} ${selectedWeekOption.hour} ? * ${selectedWeekOption.dow}`;
+      return `0 ${selectedWeekOption.min} ${selectedWeekOption.hour} ? * ${
+        // Quartz cron format accepts 1-7 or SUN-SAT so need to increment index by 1
+        // Ref: https://www.quartz-scheduler.org/api/2.1.7/org/quartz/CronExpression.html
+        selectedWeekOption.dow + 1
+      }`;
     case 'month':
       return `0 ${selectedMonthOption.min} ${selectedMonthOption.hour} ${selectedMonthOption.dom} * ?`;
     case 'year':