From 064b43c21cd98e603b396b4e2a8a499eaa2ff2bd Mon Sep 17 00:00:00 2001 From: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> Date: Thu, 26 Jun 2025 19:08:53 +0530 Subject: [PATCH] fix pw issues for domain (#21986) --- .../main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts | 4 ++-- .../src/main/resources/ui/playwright/utils/domain.ts | 7 +------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts index 601e036b366..781eca94669 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts @@ -259,9 +259,9 @@ test('Verify column lineage between table and topic', async ({ browser }) => { await page.keyboard.type(tableServiceFqn); await searchRes; + const lineageRes = page.waitForResponse('/api/v1/lineage/getLineage?*'); await page.click(`[data-testid="node-suggestion-${tableServiceFqn}"]`); - - await page.waitForLoadState('networkidle'); + await lineageRes; const tableServiceNode = page.locator( `[data-testid="lineage-node-${tableServiceFqn}"]` diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts index f57dce6796e..da37fd6064a 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts @@ -114,6 +114,7 @@ export const selectDomain = async (page: Page, domain: Domain['data']) => { .getByRole('menuitem', { name: domain.displayName }) .locator('span') .click(); + await page.waitForLoadState('networkidle'); }; export const selectSubDomain = async ( @@ -135,12 +136,7 @@ export const selectSubDomain = async ( } await page.getByTestId('subdomains').getByText('Sub Domains').click(); - const res = page.waitForResponse( - '/api/v1/search/query?*&index=data_product_search_index*' - ); await page.getByTestId(subDomain.name).click(); - await res; - await page.waitForLoadState('networkidle'); await page.locator('[data-testid="loader"]').waitFor({ state: 'detached' }); }; @@ -183,7 +179,6 @@ export const selectDataProduct = async ( const goToAssetsTab = async (page: Page, domain: Domain['data']) => { await selectDomain(page, domain); - await page.waitForSelector('[data-testid="loader"]', { state: 'detached' }); await checkDomainDisplayName(page, domain.displayName); await page.getByTestId('assets').click(); };