yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-28 19:05:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix(UI)#8659: Fixed issue with wrong link for custom attributes in activity feed (#8668)

Browse Source 
* Fixed issue with wrong link for custom attributes in activity feed

* Function to get customAttributes path removed and used already existing function
This commit is contained in:
Aniket Katkar 2022-11-12 00:30:49 +05:30 committed by GitHub
parent 5972570f61
commit 072e190dd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openmetadata-ui/src/main/resources/ui/src/constants/constants.ts
View File

@ -458,13 +458,6 @@ export const getAddCustomPropertyPath = (entityTypeFQN: string) => {
return path; return path;
}; };
export const getCustomEntityPath = (entityTypeFQN: string) => {
let path = ROUTES.CUSTOM_ENTITY_DETAIL;
path = path.replace(PLACEHOLDER_ENTITY_TYPE_FQN, entityTypeFQN);
return path;
};
export const getCreateUserPath = (bot: boolean) => { export const getCreateUserPath = (bot: boolean) => {
let path = bot ? ROUTES.CREATE_USER_WITH_BOT : ROUTES.CREATE_USER; let path = bot ? ROUTES.CREATE_USER_WITH_BOT : ROUTES.CREATE_USER;

9
openmetadata-ui/src/main/resources/ui/src/utils/TableUtils.tsx
View File

@ -23,7 +23,6 @@ import { ReactComponent as TopicIcon } from '../assets/svg/topic-grey.svg';
import PopOver from '../components/common/popover/PopOver'; import PopOver from '../components/common/popover/PopOver';
import { FQN_SEPARATOR_CHAR } from '../constants/char.constants'; import { FQN_SEPARATOR_CHAR } from '../constants/char.constants';
import { import {
getCustomEntityPath,
getDashboardDetailsPath, getDashboardDetailsPath,
getDatabaseDetailsPath, getDatabaseDetailsPath,
getDatabaseSchemaDetailsPath, getDatabaseSchemaDetailsPath,
@ -34,6 +33,7 @@ import {
getTableDetailsPath, getTableDetailsPath,
getTopicDetailsPath, getTopicDetailsPath,
} from '../constants/constants'; } from '../constants/constants';
import { GlobalSettingsMenuCategory } from '../constants/globalSettings.constants';
import { EntityType, FqnPart } from '../enums/entity.enum'; import { EntityType, FqnPart } from '../enums/entity.enum';
import { SearchIndex } from '../enums/search.enum'; import { SearchIndex } from '../enums/search.enum';
import { ConstraintTypes, PrimaryTableDataTypes } from '../enums/table.enum'; import { ConstraintTypes, PrimaryTableDataTypes } from '../enums/table.enum';
@ -44,7 +44,7 @@ import {
getPartialNameFromTableFQN, getPartialNameFromTableFQN,
getTableFQNFromColumnFQN, getTableFQNFromColumnFQN,
} from './CommonUtils'; } from './CommonUtils';
import { getGlossaryPath } from './RouterUtils'; import { getGlossaryPath, getSettingPath } from './RouterUtils';
import { ordinalize } from './StringsUtils'; import { ordinalize } from './StringsUtils';
import SVGIcons, { Icons } from './SvgUtils'; import SVGIcons, { Icons } from './SvgUtils';
@ -217,7 +217,10 @@ export const getEntityLink = (
return getEditWebhookPath(fullyQualifiedName); return getEditWebhookPath(fullyQualifiedName);
case EntityType.TYPE: case EntityType.TYPE:
return getCustomEntityPath(fullyQualifiedName); return getSettingPath(
GlobalSettingsMenuCategory.CUSTOM_ATTRIBUTES,
`${fullyQualifiedName}s`
);
case EntityType.MLMODEL: case EntityType.MLMODEL:
case SearchIndex.MLMODEL: case SearchIndex.MLMODEL: