yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-23 08:28:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: change in entityLink to string in CreateTestCaseRequest (#11291)

Browse Source
This commit is contained in:
Teddy 2023-04-26 12:52:09 +02:00 committed by GitHub
parent 86e579f9b9
commit 0930bc307a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ingestion/src/metadata/ingestion/ometa/mixins/tests_mixin.py
View File

@ -183,14 +183,8 @@ class OMetaTestsMixin:
CreateTestCaseRequest(
name=test_case_fqn.split(".")[-1],
entityLink=entity_link,
testSuite=self.get_entity_reference(
entity=TestSuite,
fqn=test_suite_fqn,
),
testDefinition=self.get_entity_reference(
entity=TestDefinition,
fqn=test_definition_fqn,
),
testSuite=test_suite_fqn,
testDefinition=test_definition_fqn,
parameterValues=test_case_parameter_values,
)
)

20
ingestion/tests/integration/ometa/test_ometa_test_suite.py
View File

@ -132,6 +132,26 @@ class OMetaTestSuiteTest(TestCase):
assert test_case.name.__root__ == "testCaseForIntegration"
assert isinstance(test_case, OMetaTestCase)
def test_create_test_case(self):
"""test we get a create the test case object if it does not exists"""
test_case_fqn = (
"sample_data.ecommerce_db.shopify.dim_address.aNonExistingTestCase"
)
test_case = self.metadata.get_by_name(
entity=OMetaTestCase, fqn=test_case_fqn, fields=["*"]
)
assert test_case is None
test_case = self.metadata.get_or_create_test_case(
test_case_fqn,
test_suite_fqn="critical_metrics_suite",
test_definition_fqn="columnValuesToMatchRegex",
entity_link="<#E::table::sample_data.ecommerce_db.shopify.dim_address::columns::last_name>",
)
assert test_case.name.__root__ == "aNonExistingTestCase"
assert isinstance(test_case, OMetaTestCase)
def test_get_test_case_results(self):
"""test get test case result method"""
res = self.metadata.get_test_case_results(