From 099853ab1076f3abe51592c2b51d598ff636111e Mon Sep 17 00:00:00 2001 From: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Date: Wed, 14 Dec 2022 21:42:06 +0530 Subject: [PATCH] Fix Clickhouse Comments (#9295) --- ingestion/setup.py | 2 +- .../src/metadata/ingestion/source/database/clickhouse.py | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/ingestion/setup.py b/ingestion/setup.py index 8cae2436f8d..e0655c23b32 100644 --- a/ingestion/setup.py +++ b/ingestion/setup.py @@ -150,7 +150,7 @@ plugins: Dict[str, Set[str]] = { "mlflow": {"mlflow-skinny~=1.26.1"}, "sklearn": {"scikit-learn==1.0.2"}, "db2": {"ibm-db-sa==0.3.7"}, - "clickhouse": {"clickhouse-driver==0.2.3", "clickhouse-sqlalchemy==0.2.0"}, + "clickhouse": {"clickhouse-driver==0.2.5", "clickhouse-sqlalchemy==0.2.3"}, "databricks": {"sqlalchemy-databricks==0.1.0"}, "singlestore": {"pymysql>=1.0.2"}, "azure-sso": {"msal~=1.17.0"}, diff --git a/ingestion/src/metadata/ingestion/source/database/clickhouse.py b/ingestion/src/metadata/ingestion/source/database/clickhouse.py index c8ff2fd7c3b..2ba03226b10 100644 --- a/ingestion/src/metadata/ingestion/source/database/clickhouse.py +++ b/ingestion/src/metadata/ingestion/source/database/clickhouse.py @@ -154,13 +154,6 @@ def get_pk_constraint( return {"constrained_columns": [], "name": "undefined"} -@reflection.cache -def get_table_comment( - self, connection, table_name, schema=None, **kw # pylint: disable=unused-argument -): - return {"text": None} - - @reflection.cache def get_view_definition( self, connection, view_name, schema=None, **kw # pylint: disable=unused-argument @@ -184,7 +177,6 @@ ClickHouseDialect.get_pk_constraint = get_pk_constraint ClickHouseDialect._get_column_type = ( # pylint: disable=protected-access _get_column_type ) -ClickHouseDialect.get_table_comment = get_table_comment RequestsTransport.execute = execute ClickHouseDialect.get_view_definition = get_view_definition