yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-15 04:26:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Clickhouse Comments (#9295)

Browse Source
This commit is contained in:
Mayur Singal 2022-12-14 21:42:06 +05:30 committed by GitHub
parent a6ae9fd11a
commit 099853ab10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/setup.py
View File

@ -150,7 +150,7 @@ plugins: Dict[str, Set[str]] = {
"mlflow": {"mlflow-skinny~=1.26.1"}, "mlflow": {"mlflow-skinny~=1.26.1"},
"sklearn": {"scikit-learn==1.0.2"}, "sklearn": {"scikit-learn==1.0.2"},
"db2": {"ibm-db-sa==0.3.7"}, "db2": {"ibm-db-sa==0.3.7"},
"clickhouse": {"clickhouse-driver==0.2.3", "clickhouse-sqlalchemy==0.2.0"}, "clickhouse": {"clickhouse-driver==0.2.5", "clickhouse-sqlalchemy==0.2.3"},
"databricks": {"sqlalchemy-databricks==0.1.0"}, "databricks": {"sqlalchemy-databricks==0.1.0"},
"singlestore": {"pymysql>=1.0.2"}, "singlestore": {"pymysql>=1.0.2"},
"azure-sso": {"msal~=1.17.0"}, "azure-sso": {"msal~=1.17.0"},

8
ingestion/src/metadata/ingestion/source/database/clickhouse.py
View File

@ -154,13 +154,6 @@ def get_pk_constraint(
return {"constrained_columns": [], "name": "undefined"} return {"constrained_columns": [], "name": "undefined"}
@reflection.cache
def get_table_comment(
self, connection, table_name, schema=None, **kw # pylint: disable=unused-argument
):
return {"text": None}
@reflection.cache @reflection.cache
def get_view_definition( def get_view_definition(
self, connection, view_name, schema=None, **kw # pylint: disable=unused-argument self, connection, view_name, schema=None, **kw # pylint: disable=unused-argument
@ -184,7 +177,6 @@ ClickHouseDialect.get_pk_constraint = get_pk_constraint
ClickHouseDialect._get_column_type = ( # pylint: disable=protected-access ClickHouseDialect._get_column_type = ( # pylint: disable=protected-access
_get_column_type _get_column_type
) )
ClickHouseDialect.get_table_comment = get_table_comment
RequestsTransport.execute = execute RequestsTransport.execute = execute
ClickHouseDialect.get_view_definition = get_view_definition ClickHouseDialect.get_view_definition = get_view_definition