yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-19 22:49:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue 4237 - fixes empty dictionary (#4239)

Browse Source
This commit is contained in:
Ayush Shah 2022-04-19 21:22:46 +05:30 committed by GitHub
parent 579d3cdd88
commit 09f01fc7e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ingestion/examples/workflows/mysql.json
View File

@ -7,10 +7,16 @@
"type": "Mysql", "type": "Mysql",
"username": "openmetadata_user", "username": "openmetadata_user",
"password": "openmetadata_password", "password": "openmetadata_password",
"hostPort": "localhost:3306" "hostPort": "localhost:3306",
"connectionOptions": {},
"connectionArguments": {}
} }
}, },
"sourceConfig": {"config": {"enableDataProfiler": false}} "sourceConfig": {
"config": {
"enableDataProfiler": false
}
}
}, },
"sink": { "sink": {
"type": "metadata-rest", "type": "metadata-rest",

6
ingestion/src/metadata/utils/source_connections.py
View File

@ -91,7 +91,11 @@ def get_connection_url_common(connection):
url += connection.hostPort url += connection.hostPort
url += f"/{connection.database}" if connection.database else "" url += f"/{connection.database}" if connection.database else ""
options = connection.connectionOptions options = (
connection.connectionOptions.dict()
if connection.connectionOptions
else connection.connectionOptions
)
if options: if options:
if not connection.database: if not connection.database:
url += "/" url += "/"

4
ingestion/tests/unit/source/test_mysql.py
View File

@ -44,7 +44,9 @@ CONFIG = """
"username": "openmetadata_user", "username": "openmetadata_user",
"password": "openmetadata_password", "password": "openmetadata_password",
"hostPort": "localhost:3306", "hostPort": "localhost:3306",
"database": "openmetadata_db" "database": "openmetadata_db",
"connectionOptions": {},
"connectionArguments": {}
} }
}, },
"sourceConfig": { "sourceConfig": {