yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-18 05:19:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Servlets Log Error Messages (#11514)

Browse Source 
* remove stack trace logging

* Fixed Error Messages

* Feed Servelt logging
This commit is contained in:
Mohit Yadav 2023-05-10 10:56:28 +05:30 committed by GitHub
parent bc5a11a72a
commit 0aa6c08cf6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-service/src/main/java/org/openmetadata/service/security/saml/SamlAssertionConsumerServlet.java
View File

@ -37,7 +37,7 @@ public class SamlAssertionConsumerServlet extends HttpServlet {
try { try {
handleResponse(req, resp); handleResponse(req, resp);
} catch (Exception e) { } catch (Exception e) {
LOG.error("SamlResponseError :" + e.getMessage()); LOG.error("[SamlAssertionConsumerServlet] Exception :" + e.getMessage());
} }
} }

6
openmetadata-service/src/main/java/org/openmetadata/service/security/saml/SamlLoginServlet.java
View File

@ -35,8 +35,10 @@ public class SamlLoginServlet extends HttpServlet {
auth = new Auth(SamlSettingsHolder.getInstance().getSaml2Settings(), req, resp); auth = new Auth(SamlSettingsHolder.getInstance().getSaml2Settings(), req, resp);
auth.login(SamlSettingsHolder.getInstance().getRelayState()); auth.login(SamlSettingsHolder.getInstance().getRelayState());
} catch (Exception e) { } catch (Exception e) {
LOG.error(e.getMessage()); resp.setContentType("text/html; charset=UTF-8");
resp.getOutputStream().println(e.getMessage()); LOG.error("[SamlLoginServlet] Failed in Auth Login : {}", e.getMessage());
resp.getOutputStream()
.println(String.format("<p> [SamlLoginServlet] Failed in Auth Login : %s </p>", e.getMessage()));
} }
} }
} }

1
openmetadata-service/src/main/java/org/openmetadata/service/security/saml/SamlMetadataServlet.java
View File

@ -39,6 +39,7 @@ public class SamlMetadataServlet extends HttpServlet {
} else { } else {
resp.setContentType("text/html; charset=UTF-8"); resp.setContentType("text/html; charset=UTF-8");
for (String error : errors) { for (String error : errors) {
LOG.error("[SamlMetadataServlet] Errors in getting Metadata : {} : Errors : {}", metadata, errors);
resp.getOutputStream().println("<p>" + error + "</p>"); resp.getOutputStream().println("<p>" + error + "</p>");
} }
} }

7
openmetadata-service/src/main/java/org/openmetadata/service/socket/FeedServlet.java
View File

@ -19,13 +19,16 @@ import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletRequestWrapper; import javax.servlet.http.HttpServletRequestWrapper;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import lombok.extern.slf4j.Slf4j;
@Slf4j
@WebServlet("/api/v1/push/feed/*") @WebServlet("/api/v1/push/feed/*")
public class FeedServlet extends HttpServlet { public class FeedServlet extends HttpServlet {
public FeedServlet() {} public FeedServlet() {}
@Override @Override
protected void service(HttpServletRequest request, HttpServletResponse response) throws IOException { protected void service(HttpServletRequest request, HttpServletResponse response) throws IOException {
try {
WebSocketManager.getInstance() WebSocketManager.getInstance()
.getEngineIoServer() .getEngineIoServer()
.handleRequest( .handleRequest(
@ -36,5 +39,9 @@ public class FeedServlet extends HttpServlet {
} }
}, },
response); response);
} catch (Exception ex) {
LOG.error("[FeedServlet] Error Encountered : {}", ex.getMessage());
response.getWriter().println(String.format("[FeedServlet] Error Encountered : %s", ex.getMessage()));
}
} }
} }

4
openmetadata-service/src/main/java/org/openmetadata/service/socket/SocketAddressFilter.java
View File

@ -22,7 +22,6 @@ import java.util.TreeMap;
import javax.servlet.Filter; import javax.servlet.Filter;
import javax.servlet.FilterChain; import javax.servlet.FilterChain;
import javax.servlet.FilterConfig; import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest; import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse; import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
@ -52,8 +51,7 @@ public class SocketAddressFilter implements Filter {
public void destroy() {} public void destroy() {}
@Override @Override
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException {
throws IOException, ServletException {
try { try {
HttpServletRequest httpServletRequest = (HttpServletRequest) request; HttpServletRequest httpServletRequest = (HttpServletRequest) request;
Map<String, String> query = ParseQS.decode(httpServletRequest.getQueryString()); Map<String, String> query = ParseQS.decode(httpServletRequest.getQueryString());