Add database required fields

2025-12-25 14:38:29 +00:00 · 2022-04-18 17:38:34 +02:00 · 2022-04-18 17:38:34 +02:00 · 0c55a7ccc1
commit 0c55a7ccc1
parent c7fe4f8968
22 changed files with 100 additions and 29 deletions
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/azureSQLConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/azureSQLConnection.json
@ -62,5 +62,6 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": ["hostPort", "username"]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/bigQueryConnection.json
@ -85,5 +85,8 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsUsageExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "projectID"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/clickhouseConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/clickhouseConnection.json
@ -64,5 +64,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsUsageExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/databricksConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/databricksConnection.json
@ -62,5 +62,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "token"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/db2Connection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/db2Connection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/druidConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/dynamoDBConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/dynamoDBConnection.json
@ -19,10 +19,6 @@
      "$ref": "#/definitions/dynamoDBType",
      "default": "DynamoDB"
    },
-    "hostPort": {
-      "description": "Host and port of the DynamoDB",
-      "type": "string"
-    },
    "endPointURL": {
      "description": "EndPoint URL for the Dynamo DB",
      "type": "string"
@ -59,5 +55,11 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "endPointURL",
+    "awsRegion",
+    "awsAccessKeyId",
+    "awsSecretAccessKey"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/glueConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/glueConnection.json
@ -19,10 +19,6 @@
      "$ref": "#/definitions/glueType",
      "default": "Glue"
    },
-    "hostPort": {
-      "description": "Host and port of the Glue",
-      "type": "string"
-    },
    "endPointURL": {
      "description": "EndPoint URL for the Glue",
      "type": "string"
@ -67,5 +63,11 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "endPointURL",
+    "awsRegion",
+    "awsAccessKeyId",
+    "awsSecretAccessKey"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/hiveConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/hiveConnection.json
@ -61,5 +61,6 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": ["hostPort"]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mariaDBConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mariaDBConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mysqlConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/mysqlConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/oracleConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/oracleConnection.json
@ -62,5 +62,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/postgresConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/postgresConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/prestoConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/prestoConnection.json
@ -61,5 +61,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/redshiftConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/redshiftConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/salesforceConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/salesforceConnection.json
@ -61,5 +61,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/singleStoreConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/singleStoreConnection.json
@ -57,5 +57,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/snowflakeConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/snowflakeConnection.json
@ -72,5 +72,10 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsUsageExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username",
+    "account"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/trinoConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/trinoConnection.json
@ -69,5 +69,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsMetadataExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/verticaConnection.json
+++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/database/verticaConnection.json
@ -60,5 +60,9 @@
      "$ref": "../connectionBasicType.json#/definitions/supportsUsageExtraction"
    }
  },
-  "additionalProperties": false
+  "additionalProperties": false,
+  "required": [
+    "hostPort",
+    "username"
+  ]
 }
--- a/ingestion/examples/workflows/dynamodb.json
+++ b/ingestion/examples/workflows/dynamodb.json
@ -7,7 +7,7 @@
        "awsAccessKeyId": "aws_access_key_id",
        "awsSecretAccessKey": "aws_secret_access_key",
        "awsRegion": "us-east-2",
-        "endPointURL": "https://dynamodb.us-east-2.amazonaws.com",
+        "hostPort": "https://dynamodb.us-east-2.amazonaws.com",
        "database": "custom_database_name"
      }
    },
--- a/ingestion/tests/unit/source/test_source_parsing.py
+++ b/ingestion/tests/unit/source/test_source_parsing.py
@ -641,6 +641,7 @@ def test_salesforce():
        "serviceConnection": {
            "config": {
                "type": "Salesforce",
+                "hostPort": "localhost",
                "username": "username",
                "password": "password",
                "securityToken": "securityToken",