UI : - Disable the name field file while editing Ingestion (#9023)

* Added support for edit display name in Ingestion

* changes as per comments

* fix unit test issue
This commit is contained in:
Ashish Gupta 2022-11-29 14:01:47 +05:30 committed by GitHub
parent ce3ab68932
commit 0c61c4cb69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 0 deletions

View File

@ -723,6 +723,7 @@ const AddIngestion = ({
databaseServiceNames={databaseServiceNames}
description={description}
enableDebugLog={enableDebugLog}
formType={status}
getExcludeValue={getExcludeValue}
getIncludeValue={getIncludeValue}
handleDatasetServiceName={(val) => setDatabaseServiceNames(val)}

View File

@ -13,6 +13,7 @@
import { findAllByText, findByTestId, render } from '@testing-library/react';
import React from 'react';
import { FormSubmitType } from '../../../enums/form.enum';
import { ServiceCategory } from '../../../enums/service.enum';
import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
import { ConfigureIngestionProps } from '../addIngestion.interface';
@ -66,6 +67,7 @@ const mockConfigureIngestion: ConfigureIngestionProps = {
includeView: false,
includeTags: false,
pipelineType: PipelineType.Metadata,
formType: FormSubmitType.EDIT,
queryLogDuration: 1,
resultLimit: 100,
stageFileLocation: '',

View File

@ -15,6 +15,7 @@ import { isNil } from 'lodash';
import { EditorContentRef } from 'Models';
import React, { Fragment, useRef, useState } from 'react';
import { FilterPatternEnum } from '../../../enums/filterPattern.enum';
import { FormSubmitType } from '../../../enums/form.enum';
import { ServiceCategory } from '../../../enums/service.enum';
import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
import { errorMsg, getSeparator } from '../../../utils/CommonUtils';
@ -81,6 +82,7 @@ const ConfigureIngestion = ({
onUseFqnFilterClick,
onCancel,
onNext,
formType,
}: ConfigureIngestionProps) => {
const markdownRef = useRef<EditorContentRef>();
@ -496,6 +498,7 @@ const ConfigureIngestion = ({
<input
className="tw-form-inputs tw-form-inputs-padding"
data-testid="name"
disabled={formType === FormSubmitType.EDIT}
id="name"
name="name"
type="text"

View File

@ -55,6 +55,7 @@ export interface AddIngestionProps {
}
export interface ConfigureIngestionProps {
formType: FormSubmitType;
ingestionName: string;
description?: string;
databaseServiceNames: string[];