From 0c61c4cb69de3b1e96f904483e4f79a7c42bb6c3 Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Tue, 29 Nov 2022 14:01:47 +0530
Subject: [PATCH] UI : - Disable the name field file while editing Ingestion
 (#9023)

* Added support for edit display name in Ingestion

* changes as per comments

* fix unit test issue
---
 .../ui/src/components/AddIngestion/AddIngestion.component.tsx  | 1 +
 .../components/AddIngestion/Steps/ConfigureIngestion.test.tsx  | 2 ++
 .../src/components/AddIngestion/Steps/ConfigureIngestion.tsx   | 3 +++
 .../ui/src/components/AddIngestion/addIngestion.interface.ts   | 1 +
 4 files changed, 7 insertions(+)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/AddIngestion.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/AddIngestion.component.tsx
index 63838c96e79..3183127a1bf 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/AddIngestion.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/AddIngestion.component.tsx
@@ -723,6 +723,7 @@ const AddIngestion = ({
             databaseServiceNames={databaseServiceNames}
             description={description}
             enableDebugLog={enableDebugLog}
+            formType={status}
             getExcludeValue={getExcludeValue}
             getIncludeValue={getIncludeValue}
             handleDatasetServiceName={(val) => setDatabaseServiceNames(val)}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.test.tsx
index 57b71509ccb..d49be769d72 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.test.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.test.tsx
@@ -13,6 +13,7 @@
 
 import { findAllByText, findByTestId, render } from '@testing-library/react';
 import React from 'react';
+import { FormSubmitType } from '../../../enums/form.enum';
 import { ServiceCategory } from '../../../enums/service.enum';
 import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
 import { ConfigureIngestionProps } from '../addIngestion.interface';
@@ -66,6 +67,7 @@ const mockConfigureIngestion: ConfigureIngestionProps = {
   includeView: false,
   includeTags: false,
   pipelineType: PipelineType.Metadata,
+  formType: FormSubmitType.EDIT,
   queryLogDuration: 1,
   resultLimit: 100,
   stageFileLocation: '',
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.tsx
index 69ce7ca3f12..343fa51c6dd 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.tsx
@@ -15,6 +15,7 @@ import { isNil } from 'lodash';
 import { EditorContentRef } from 'Models';
 import React, { Fragment, useRef, useState } from 'react';
 import { FilterPatternEnum } from '../../../enums/filterPattern.enum';
+import { FormSubmitType } from '../../../enums/form.enum';
 import { ServiceCategory } from '../../../enums/service.enum';
 import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
 import { errorMsg, getSeparator } from '../../../utils/CommonUtils';
@@ -81,6 +82,7 @@ const ConfigureIngestion = ({
   onUseFqnFilterClick,
   onCancel,
   onNext,
+  formType,
 }: ConfigureIngestionProps) => {
   const markdownRef = useRef<EditorContentRef>();
 
@@ -496,6 +498,7 @@ const ConfigureIngestion = ({
           <input
             className="tw-form-inputs tw-form-inputs-padding"
             data-testid="name"
+            disabled={formType === FormSubmitType.EDIT}
             id="name"
             name="name"
             type="text"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/addIngestion.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/addIngestion.interface.ts
index a9f867de4de..5db955a303f 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/addIngestion.interface.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/addIngestion.interface.ts
@@ -55,6 +55,7 @@ export interface AddIngestionProps {
 }
 
 export interface ConfigureIngestionProps {
+  formType: FormSubmitType;
   ingestionName: string;
   description?: string;
   databaseServiceNames: string[];