yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-01 13:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI : - Disable the name field file while editing Ingestion (#9023)

Browse Source 
* Added support for edit display name in Ingestion

* changes as per comments

* fix unit test issue
This commit is contained in:
Ashish Gupta 2022-11-29 14:01:47 +05:30 committed by GitHub
parent ce3ab68932
commit 0c61c4cb69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/AddIngestion.component.tsx
View File

@ -723,6 +723,7 @@ const AddIngestion = ({
databaseServiceNames={databaseServiceNames} databaseServiceNames={databaseServiceNames}
description={description} description={description}
enableDebugLog={enableDebugLog} enableDebugLog={enableDebugLog}
formType={status}
getExcludeValue={getExcludeValue} getExcludeValue={getExcludeValue}
getIncludeValue={getIncludeValue} getIncludeValue={getIncludeValue}
handleDatasetServiceName={(val) => setDatabaseServiceNames(val)} handleDatasetServiceName={(val) => setDatabaseServiceNames(val)}

2
openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.test.tsx
View File

@ -13,6 +13,7 @@
import { findAllByText, findByTestId, render } from '@testing-library/react'; import { findAllByText, findByTestId, render } from '@testing-library/react';
import React from 'react'; import React from 'react';
import { FormSubmitType } from '../../../enums/form.enum';
import { ServiceCategory } from '../../../enums/service.enum'; import { ServiceCategory } from '../../../enums/service.enum';
import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline'; import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
import { ConfigureIngestionProps } from '../addIngestion.interface'; import { ConfigureIngestionProps } from '../addIngestion.interface';
@ -66,6 +67,7 @@ const mockConfigureIngestion: ConfigureIngestionProps = {
includeView: false, includeView: false,
includeTags: false, includeTags: false,
pipelineType: PipelineType.Metadata, pipelineType: PipelineType.Metadata,
formType: FormSubmitType.EDIT,
queryLogDuration: 1, queryLogDuration: 1,
resultLimit: 100, resultLimit: 100,
stageFileLocation: '', stageFileLocation: '',

3
openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/Steps/ConfigureIngestion.tsx
View File

@ -15,6 +15,7 @@ import { isNil } from 'lodash';
import { EditorContentRef } from 'Models'; import { EditorContentRef } from 'Models';
import React, { Fragment, useRef, useState } from 'react'; import React, { Fragment, useRef, useState } from 'react';
import { FilterPatternEnum } from '../../../enums/filterPattern.enum'; import { FilterPatternEnum } from '../../../enums/filterPattern.enum';
import { FormSubmitType } from '../../../enums/form.enum';
import { ServiceCategory } from '../../../enums/service.enum'; import { ServiceCategory } from '../../../enums/service.enum';
import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline'; import { PipelineType } from '../../../generated/entity/services/ingestionPipelines/ingestionPipeline';
import { errorMsg, getSeparator } from '../../../utils/CommonUtils'; import { errorMsg, getSeparator } from '../../../utils/CommonUtils';
@ -81,6 +82,7 @@ const ConfigureIngestion = ({
onUseFqnFilterClick, onUseFqnFilterClick,
onCancel, onCancel,
onNext, onNext,
formType,
}: ConfigureIngestionProps) => { }: ConfigureIngestionProps) => {
const markdownRef = useRef<EditorContentRef>(); const markdownRef = useRef<EditorContentRef>();
@ -496,6 +498,7 @@ const ConfigureIngestion = ({
<input <input
className="tw-form-inputs tw-form-inputs-padding" className="tw-form-inputs tw-form-inputs-padding"
data-testid="name" data-testid="name"
disabled={formType === FormSubmitType.EDIT}
id="name" id="name"
name="name" name="name"
type="text" type="text"

1
openmetadata-ui/src/main/resources/ui/src/components/AddIngestion/addIngestion.interface.ts
View File

@ -55,6 +55,7 @@ export interface AddIngestionProps {
} }
export interface ConfigureIngestionProps { export interface ConfigureIngestionProps {
formType: FormSubmitType;
ingestionName: string; ingestionName: string;
description?: string; description?: string;
databaseServiceNames: string[]; databaseServiceNames: string[];