yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-31 04:14:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor: address ui feedback on data observability (#16427)

Browse Source 
* Minor: address ui feedback on data observability

* fixed failing unit test
This commit is contained in:
Shailesh Parmar 2024-05-28 14:12:16 +05:30 committed by GitHub
parent a4c516d2c7
commit 0c974edd13
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/Severity/Severity.component.tsx
View File

@ -11,7 +11,8 @@
* limitations under the License.
*/
import { Button, Space, Tooltip } from 'antd';
import Icon from '@ant-design/icons/lib/components/Icon';
import { Space, Tooltip } from 'antd';
import classNames from 'classnames';
import { startCase, toLower } from 'lodash';
import React, { useCallback, useMemo, useState } from 'react';
@ -70,10 +71,11 @@ const Severity = ({ severity, onSubmit }: SeverityProps) => {
title={t('label.edit-entity', {
entity: t('label.severity'),
})}>
<Button
<Icon
{...ICON_DIMENSION}
component={EditIcon}
data-testid="edit-severity-icon"
icon={<EditIcon {...ICON_DIMENSION} color={DE_ACTIVE_COLOR} />}
type="text"
style={{ color: DE_ACTIVE_COLOR }}
onClick={onEditSeverity}
/>
</Tooltip>

13
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/TestCaseStatus/TestCaseIncidentManagerStatus.component.tsx
View File

@ -11,12 +11,14 @@
* limitations under the License.
*/
import { Button, Space, Tooltip, Typography } from 'antd';
import Icon from '@ant-design/icons/lib/components/Icon';
import { Space, Tooltip, Typography } from 'antd';
import classNames from 'classnames';
import React, { useCallback, useMemo, useState } from 'react';
import { ReactComponent as EditIcon } from '../../../../assets/svg/edit-new.svg';
import {
DE_ACTIVE_COLOR,
ICON_DIMENSION,
NO_DATA_PLACEHOLDER,
} from '../../../../constants/constants';
import { usePermissionProvider } from '../../../../context/PermissionProvider/PermissionProvider';
@ -70,12 +72,11 @@ const TestCaseIncidentManagerStatus = ({
label={statusType}
/>
{hasEditPermission && (
<Button
className="flex-center p-0"
<Icon
{...ICON_DIMENSION}
component={EditIcon}
data-testid="edit-resolution-icon"
icon={<EditIcon color={DE_ACTIVE_COLOR} width="14px" />}
size="small"
type="text"
style={{ color: DE_ACTIVE_COLOR }}
onClick={onEditStatus}
/>
)}

2
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuite/TestSuiteList/TestSuites.component.tsx
View File

@ -279,7 +279,7 @@ export const TestSuites = ({ summaryPanel }: { summaryPanel: ReactNode }) => {
/>
</Form.Item>
<Form.Item
className="m-0 w-52"
className="m-0"
label={t('label.owner')}
name="owner">
<UserTeamSelectableList

2
openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerPage.tsx
View File

@ -443,7 +443,7 @@ const IncidentManagerPage = () => {
return (
<PageLayoutV1 pageTitle="Incident Manager">
<Row className="p-x-lg p-t-md" gutter={[0, 16]}>
<Row className="p-x-lg p-b-lg p-t-md" gutter={[0, 16]}>
<Col span={24}>
<Typography.Title
className="m-b-md"