yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-27 02:16:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix - Existing custom properties getting removed on import of empty extension column (#19234)

Browse Source
This commit is contained in:
sonika-shah 2025-01-05 23:16:14 +05:30 committed by GitHub
parent 1c793cc268
commit 0d3393c3c1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java
View File

@ -2840,6 +2840,13 @@ public abstract class EntityRepository<T extends EntityInterface> {
return;
}
if (operation == Operation.PUT && updatedExtension == null) {
// Revert change to non-empty extension if it is being updated by a PUT request
// For PUT operations, existing extension can't be removed.
updated.setExtension(origExtension);
return;
}
List<JsonNode> added = new ArrayList<>();
List<JsonNode> deleted = new ArrayList<>();
JsonNode origFields = JsonUtils.valueToTree(origExtension);

3
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/MlModelRepository.java
View File

@ -211,7 +211,8 @@ public class MlModelRepository extends EntityRepository<MlModel> {
.getFeatureSources()
.forEach(
mlFeatureSource -> {
EntityReference targetEntity = getEntityReference(mlFeatureSource.getDataSource(), Include.ALL);
EntityReference targetEntity =
getEntityReference(mlFeatureSource.getDataSource(), Include.ALL);
if (targetEntity != null) {
addRelationship(
targetEntity.getId(),