yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-15 18:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(playwright): fix test timeout and domains sidebar validation (#23693)

Browse Source 
- Replace promise catch with try-catch in waitForSearchDebounce to prevent
  silent error swallowing that caused 180s test timeouts
- Add DOMAINS to dropdown items condition in validateLeftSidebarWithHiddenItems
  to properly handle domains section validation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
satish 2025-10-03 16:30:22 +05:30 committed by GitHub
parent ea54b6b883
commit 0d860d28aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmetadata-ui/src/main/resources/ui/playwright/utils/customizeNavigation.ts
View File

@ -46,7 +46,11 @@ export const validateLeftSidebarWithHiddenItems = async (
) => { ) => {
for (const item of Object.values(SidebarItem)) { for (const item of Object.values(SidebarItem)) {
// Dropdown items are handled differently // Dropdown items are handled differently
if (item === SidebarItem.OBSERVABILITY || item === SidebarItem.GOVERNANCE) { if (
item === SidebarItem.OBSERVABILITY ||
item === SidebarItem.GOVERNANCE ||
item === SidebarItem.DOMAINS
) {
await expect(page.getByTestId(item)).toBeVisible(); await expect(page.getByTestId(item)).toBeVisible();
} else { } else {
const items = SIDEBAR_LIST_ITEMS[item as keyof typeof SIDEBAR_LIST_ITEMS]; const items = SIDEBAR_LIST_ITEMS[item as keyof typeof SIDEBAR_LIST_ITEMS];

12
openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts
View File

@ -49,18 +49,18 @@ const waitForAssetModalInitialLoad = async (page: Page) => {
const waitForSearchDebounce = async (page: Page) => { const waitForSearchDebounce = async (page: Page) => {
// Wait for loader to appear and disappear after search // Wait for loader to appear and disappear after search
// This ensures search debounce completed and results are stable // This ensures search debounce completed and results are stable
await page try {
.waitForSelector('[data-testid="loader"]', { await page.waitForSelector('[data-testid="loader"]', {
state: 'attached', state: 'attached',
timeout: 999, timeout: 999,
})
.catch(() => {
// Loader might not appear if search is very fast
}); });
await page.waitForSelector('[data-testid="loader"]', { await page.waitForSelector('[data-testid="loader"]', {
state: 'detached', state: 'detached',
}); });
} catch (e) {
// Loader never appeared - search was instant, which is fine
// Just continue without waiting
}
}; };
export const assignDomain = async (page: Page, domain: Domain['data']) => { export const assignDomain = async (page: Page, domain: Domain['data']) => {