reverted table fixed header changes (#20785)

This commit is contained in:
Ashish Gupta 2025-04-12 16:01:48 +05:30 committed by GitHub
parent 04eafbc572
commit 0e44f5df97
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 12 additions and 20 deletions

View File

@ -173,12 +173,12 @@ describe('ContainerDataModel', () => {
);
const rows = await screen.findAllByRole('row');
const row1 = rows[0];
const row1 = rows[1];
expect(containerDataModel).toBeInTheDocument();
// should render header row and content row
expect(rows).toHaveLength(4);
expect(rows).toHaveLength(5);
const name = await findByText(row1, 'department_id');
const dataType = await findByText(row1, 'numeric');

View File

@ -78,7 +78,7 @@ describe('EditTestCaseModal Component', () => {
expect(await screen.findByText('label.submit')).toBeInTheDocument();
});
it.skip('table, name, test definition, should be disabled', async () => {
it('table, name, test definition, should be disabled', async () => {
render(<EditTestCaseModal {...mockProps} />);
expect(await screen.findByLabelText('label.name')).toBeDisabled();

View File

@ -871,8 +871,6 @@ const GlossaryTermTab = ({ isGlossary, className }: GlossaryTermTabProps) => {
loading={isTableLoading || termsLoading}
pagination={false}
rowKey="fullyQualifiedName"
// Had to pass y: 'auto' to override default styling from Table component
scroll={{ y: 'auto' }}
size="small"
staticVisibleColumns={STATIC_VISIBLE_COLUMNS}
onHeaderRow={onTableHeader}

View File

@ -88,7 +88,7 @@ describe('Test CustomField Table Component', () => {
const tableRow = await findAllByRole('row');
expect(tableRow).toHaveLength(mockProperties.length);
expect(tableRow).toHaveLength(mockProperties.length + 1);
});
it('Test delete property flow', async () => {
@ -111,7 +111,7 @@ describe('Test CustomField Table Component', () => {
const tableRow = await screen.findAllByRole('row');
expect(tableRow).toHaveLength(mockProperties.length);
expect(tableRow).toHaveLength(mockProperties.length + 1);
const dataRow = tableRow[1];

View File

@ -118,7 +118,7 @@ describe('Team Hierarchy page', () => {
expect(assetCountColumn).toBeInTheDocument();
expect(descriptionColumn).toBeInTheDocument();
expect(rows).toHaveLength(MOCK_TABLE_DATA.length);
expect(rows).toHaveLength(MOCK_TABLE_DATA.length + 1);
});
it('Should render child row in table', async () => {

View File

@ -33,8 +33,7 @@ describe('TeamImportResult component', () => {
expect(
await screen.findByTestId('import-result-table')
).toBeInTheDocument();
// only 3 row because of the header is excluded
expect(row).toHaveLength(3);
expect(row).toHaveLength(4);
});
it('Component should render id no data provided', async () => {

View File

@ -35,7 +35,7 @@ describe('UserImportResult component', () => {
expect(
await screen.findByTestId('import-result-table')
).toBeInTheDocument();
expect(row).toHaveLength(3);
expect(row).toHaveLength(4);
});
it('Component should render id no data provided', async () => {

View File

@ -162,12 +162,12 @@ describe('Topic Schema', () => {
const schemaFields = await screen.findByTestId('topic-schema-fields-table');
const rows = await screen.findAllByRole('row');
const row1 = rows[0];
const row1 = rows[1];
expect(schemaFields).toBeInTheDocument();
// should render header row and content row
expect(rows).toHaveLength(19);
expect(rows).toHaveLength(20);
const name = await findByText(row1, 'Order');
const dataType = await findByText(row1, 'RECORD');
@ -185,7 +185,7 @@ describe('Topic Schema', () => {
const rows = await screen.findAllByRole('row');
const nestedRow = rows[0];
const nestedRow = rows[1];
const singleRow = rows[2];
const expandIcon = await findByTestId(nestedRow, 'expand-icon');

View File

@ -311,11 +311,6 @@ const Table = <T extends Record<string, unknown>>(
ref={ref}
tableLayout="fixed"
{...resizingTableProps}
scroll={{
y: 740,
x: resizingTableProps.scroll?.x ?? rest.scroll?.x,
...rest.scroll,
}}
/>
</Col>
{customPaginationProps && customPaginationProps.showPagination ? (

View File

@ -101,7 +101,7 @@ const MockComponent = () => {
);
};
describe.skip('DataQualityProvider', () => {
describe('DataQualityProvider', () => {
beforeEach(() => {
render(
<DataQualityProvider>