From 123ed599231a0e3d49a8db313bb80afe98850d9c Mon Sep 17 00:00:00 2001 From: Sriharsha Chintalapani Date: Mon, 18 Dec 2023 19:16:29 -0800 Subject: [PATCH] Minor: update git-blmae-ignore-revs, and uncomment ClassificationResourceTest tests code (#14431) --- .git-blame-ignore-revs | 2 +- .pre-commit-config.yaml.swp | Bin 12288 -> 0 bytes .../tags/ClassificationResourceTest.java | 12 +++++++----- 3 files changed, 8 insertions(+), 6 deletions(-) delete mode 100644 .pre-commit-config.yaml.swp diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 81ebac81d8b..6b37b4eac68 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -1 +1 @@ -8c2a1e415dbe00b89e7105905f0e1e7e6296a5c4 +1294f93e15258c4d0ea2f8d4f0b746a6267dd6cc diff --git a/.pre-commit-config.yaml.swp b/.pre-commit-config.yaml.swp deleted file mode 100644 index 7b30cc8b0c2838af386183f156ed618c72a306ec..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 12288 zcmeI2L2nc{7>1pyr%+l{%7v3zT2U%yoNPdXJs}WOiHM4{PzgZ^&Wv})Va8r;?~;{J z+ee#(>oo+&Xv?`NJ*4~evQ3rvrmxJZ3Nn>Jin#Aol-RP=0hQ_LEFQ^nX7Kij=x-uG1olT@5PH%1!#9`O zi}h7M**d|GetL6%b5Jx9AOb{y2oM1xKm>>Y5g-Bwnn38!u^+I555~LrYFy9lsK;Na zA_7E!2oM1xKm>>Y5g-CYfCvx)B0vNVAOV>&R?agP9fEoM|9|rP|K%r)y@39Po`0pw1Wi2xBG0z`la5CI}U1P%ZJJ}yo@7-*-~ zymDF=9Uk03u}No77s_||o%qWQ|7gQ+J_;V6&C{PxBMNDT^h``(a4x&O`f>Wv`#7w-4kY!$?{;a^*u73!4dD_FALxDTU3 z@rOF(d~u<(z^^SE#S3M!knd#D3~q*28Ogj`kA;uAZH7};FN9}-*`sQIb?+Xu#s}f9 zMW%B(&UB7&WQICX!n;J2QXAovw*!|bFE+e2!Y8>ZrI=YA$j`?kZmbQ!MQ?N)@n z*@}JZ3~#L$GP&RSu68)_ti5&3o!jXdAlt}<-_>)_r49Kgan=`VB(^4dAJ+}U+GK5U wr=fN`UfRo$EZ2vknWDP0_4VzKLSDTcntF+)swW3USev|g)`rUY>ixm~2Yc1O)&Kwi diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/tags/ClassificationResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/tags/ClassificationResourceTest.java index c46fa8ce6e9..12e519bb10b 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/tags/ClassificationResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/tags/ClassificationResourceTest.java @@ -40,6 +40,7 @@ import org.openmetadata.schema.api.classification.CreateClassification; import org.openmetadata.schema.entity.classification.Classification; import org.openmetadata.schema.entity.classification.Tag; import org.openmetadata.schema.type.ChangeDescription; +import org.openmetadata.schema.type.ProviderType; import org.openmetadata.service.Entity; import org.openmetadata.service.exception.CatalogExceptionMessage; import org.openmetadata.service.resources.EntityResourceTest; @@ -98,17 +99,18 @@ public class ClassificationResourceTest @Override public void validateCreatedEntity( Classification createdEntity, CreateClassification request, Map authHeaders) { - // assertEquals( - // request.getProvider() == null ? ProviderType.USER : request.getProvider(), - // createdEntity.getProvider()); + assertEquals( + request.getProvider() == null ? ProviderType.USER : request.getProvider(), + createdEntity.getProvider()); assertEquals(request.getMutuallyExclusive(), createdEntity.getMutuallyExclusive()); } @Override public void compareEntities( Classification expected, Classification updated, Map authHeaders) { - // assertEquals(expected.getProvider() == null ? ProviderType.USER : expected.getProvider(), - // updated.getProvider()); + assertEquals( + expected.getProvider() == null ? ProviderType.USER : expected.getProvider(), + updated.getProvider()); assertEquals(expected.getMutuallyExclusive(), updated.getMutuallyExclusive()); }