From 130ff685a686a5a12357a5dc8191b65f3a5cfc7c Mon Sep 17 00:00:00 2001
From: Shrushti Polekar <shrushtipolekar@gmail.com>
Date: Tue, 13 May 2025 13:29:59 +0530
Subject: [PATCH] Fix: Button styling issues (#21127)

* fixes button styling issues

* address pr comments
---
 .../TaskFeedCard/TaskFeedCardNew.component.tsx     |  1 -
 .../Entity/Task/TaskTab/task-tab-new.less          |  3 +++
 .../PersonaSelectableList.component.tsx            |  8 ++------
 .../UserProfileRoles.component.tsx                 | 14 ++------------
 .../UserProfileTeams.component.tsx                 | 14 ++------------
 .../ui/src/components/Settings/Users/users.less    |  9 +++++++++
 .../DomainSelectableTreeNew.tsx                    |  4 ++--
 7 files changed, 20 insertions(+), 33 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx
index c92810e015c..4b866725f00 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx
@@ -376,7 +376,6 @@ const TaskFeedCard = ({
                       className="task-card-approve-btn d-flex items-center"
                       data-testid="approve-button"
                       icon={<CheckCircleFilled />}
-                      type="primary"
                       onClick={onTaskResolve}>
                       {t('label.approve')}
                     </Button>
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/task-tab-new.less b/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/task-tab-new.less
index b2f4d219de8..c0f42db9f3b 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/task-tab-new.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/task-tab-new.less
@@ -23,6 +23,9 @@
   button {
     height: 32px;
     border-radius: 8px;
+    display: flex;
+    align-items: center;
+    justify-content: center;
     span {
       font-size: 14px;
       font-style: normal;
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/MyData/Persona/PersonaSelectableList/PersonaSelectableList.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/MyData/Persona/PersonaSelectableList/PersonaSelectableList.component.tsx
index 62207537ae3..2530f0ec326 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/MyData/Persona/PersonaSelectableList/PersonaSelectableList.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/MyData/Persona/PersonaSelectableList/PersonaSelectableList.component.tsx
@@ -228,9 +228,7 @@ export const PersonaSelectableList = ({
             <Button
               className="persona-profile-edit-save"
               data-testid="user-profile-persona-edit-cancel"
-              icon={
-                <ClosePopoverIcon height={24} style={{ marginTop: '2px' }} />
-              }
+              icon={<ClosePopoverIcon height={24} />}
               size="small"
               type="primary"
               onClick={handleCloseEditTeam}
@@ -238,9 +236,7 @@ export const PersonaSelectableList = ({
             <Button
               className="persona-profile-edit-cancel"
               data-testid="user-profile-persona-edit-save"
-              icon={
-                <SavePopoverIcon height={24} style={{ marginTop: '2px' }} />
-              }
+              icon={<SavePopoverIcon height={24} />}
               loading={isSaving}
               size="small"
               type="primary"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx
index 934cbe42e1c..9daecfa6d82 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx
@@ -258,12 +258,7 @@ const UserProfileRoles = ({
                   <Button
                     className="profile-edit-save"
                     data-testid="user-profile-edit-roles-cancel-button"
-                    icon={
-                      <ClosePopoverIcon
-                        height={24}
-                        style={{ marginTop: '2px' }}
-                      />
-                    }
+                    icon={<ClosePopoverIcon height={24} />}
                     size="small"
                     style={{
                       width: '30px',
@@ -279,12 +274,7 @@ const UserProfileRoles = ({
                   <Button
                     className="profile-edit-cancel"
                     data-testid="user-profile-edit-roles-save-button"
-                    icon={
-                      <SavePopoverIcon
-                        height={24}
-                        style={{ marginTop: '2px' }}
-                      />
-                    }
+                    icon={<SavePopoverIcon height={24} />}
                     loading={isLoading}
                     size="small"
                     style={{
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
index b5e7364aacc..f4a5a3c2bb0 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
@@ -162,12 +162,7 @@ const UserProfileTeams = ({
                   <Button
                     className="profile-edit-save"
                     data-testid="teams-edit-close-btn"
-                    icon={
-                      <ClosePopoverIcon
-                        height={24}
-                        style={{ marginTop: '2px' }}
-                      />
-                    }
+                    icon={<ClosePopoverIcon height={24} />}
                     size="small"
                     style={{
                       width: '30px',
@@ -183,12 +178,7 @@ const UserProfileTeams = ({
                   <Button
                     className="profile-edit-cancel"
                     data-testid="teams-edit-save-btn"
-                    icon={
-                      <SavePopoverIcon
-                        height={24}
-                        style={{ marginTop: '2px' }}
-                      />
-                    }
+                    icon={<SavePopoverIcon height={24} />}
                     loading={isLoading}
                     size="small"
                     style={{
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
index 1dd9b3724c8..3f393af8fc6 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
@@ -317,6 +317,9 @@
   width: 30px;
   height: 30px;
   background: '#0950C5' !important;
+  display: flex;
+  align-items: center;
+  justify-content: center;
 }
 
 .profile-edit-save:hover,
@@ -339,6 +342,9 @@
   background: #0950c5;
   position: absolute;
   bottom: 0;
+  display: flex;
+  align-items: center;
+  justify-content: center;
 }
 
 .persona-profile-edit-save.ant-btn-icon-only.ant-btn-sm {
@@ -348,6 +354,9 @@
   position: absolute;
   bottom: 0;
   right: 38px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
 }
 
 .max-tag-text {
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTreeNew.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTreeNew.tsx
index ec2270d7dac..df0512974b5 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTreeNew.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainSelectableTree/DomainSelectableTreeNew.tsx
@@ -256,7 +256,7 @@ const DomainSelectablTreeNew: FC<DomainSelectableTreeProps> = ({
         <Button
           className="profile-edit-save"
           data-testid="user-profile-domain-edit-save"
-          icon={<ClosePopoverIcon height={24} style={{ marginTop: '2px' }} />}
+          icon={<ClosePopoverIcon height={24} />}
           size="small"
           style={{
             width: '30px',
@@ -272,7 +272,7 @@ const DomainSelectablTreeNew: FC<DomainSelectableTreeProps> = ({
         <Button
           className="profile-edit-cancel"
           data-testid="user-profile-domain-edit-cancel"
-          icon={<SavePopoverIcon height={24} style={{ marginTop: '2px' }} />}
+          icon={<SavePopoverIcon height={24} />}
           loading={isSubmitLoading}
           size="small"
           style={{