yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-25 06:28:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed api errors shown for deleted tables on table details page (#9963)

Browse Source
This commit is contained in:
Aniket Katkar 2023-01-27 21:39:56 +05:30 committed by GitHub
parent d9ea00b2f2
commit 134a5b2c54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 32 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openmetadata-ui/src/main/resources/ui/src/components/DatasetDetails/DatasetDetails.component.tsx
View File

@ -787,16 +787,23 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
)}
{activeTab === 3 && (
<div className="tab-details-container" id="sampleDataDetails">
<SampleDataTable tableId={tableDetails.id} />
<SampleDataTable
isTableDeleted={tableDetails.deleted}
tableId={tableDetails.id}
/>
</div>
)}
{activeTab === 4 && (
<div className="tab-details-container">
<TableQueries tableId={tableDetails.id} />
<TableQueries
isTableDeleted={tableDetails.deleted}
tableId={tableDetails.id}
/>
</div>
)}
{activeTab === 5 && (
<TableProfilerV1
isTableDeleted={tableDetails.deleted}
permissions={tablePermissions}
tableFqn={tableDetails.fullyQualifiedName || ''}
/>

12
openmetadata-ui/src/main/resources/ui/src/components/SampleDataTable/SampleDataTable.component.tsx
View File

@ -51,10 +51,14 @@ type SampleData = {
};
interface Props {
isTableDeleted?: boolean;
tableId: string;
}
const SampleDataTable: FunctionComponent<Props> = ({ tableId }: Props) => {
const SampleDataTable: FunctionComponent<Props> = ({
isTableDeleted,
tableId,
}: Props) => {
const tableRef = useRef<HTMLDivElement>(null);
const location = useLocation();
const [sampleData, setSampleData] = useState<SampleData>();
@ -123,7 +127,11 @@ const SampleDataTable: FunctionComponent<Props> = ({ tableId }: Props) => {
useEffect(() => {
setIsLoading(true);
if (tableId && !location.pathname.includes(ROUTES.TOUR)) {
if (
!isTableDeleted &&
tableId &&
!location.pathname.includes(ROUTES.TOUR)
) {
fetchSampleData();
} else {
setIsLoading(false);

1
openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfiler.interface.ts
View File

@ -25,6 +25,7 @@ import { TestCase } from '../../generated/tests/testCase';
import { OperationPermission } from '../PermissionProvider/PermissionProvider.interface';
export interface TableProfilerProps {
isTableDeleted?: boolean;
tableFqn: string;
permissions: OperationPermission;
}

7
openmetadata-ui/src/main/resources/ui/src/components/TableProfiler/TableProfilerV1.tsx
View File

@ -70,7 +70,10 @@ import {
} from './TableProfiler.interface';
import './tableProfiler.less';
const TableProfilerV1: FC<TableProfilerProps> = ({ permissions }) => {
const TableProfilerV1: FC<TableProfilerProps> = ({
isTableDeleted,
permissions,
}) => {
const { t } = useTranslation();
const { datasetFQN } = useParams<{ datasetFQN: string }>();
const [table, setTable] = useState<Table>();
@ -332,7 +335,7 @@ const TableProfilerV1: FC<TableProfilerProps> = ({ permissions }) => {
}, [table, viewTest]);
useEffect(() => {
if (datasetFQN) {
if (!isTableDeleted && datasetFQN) {
fetchLatestProfilerData();
}
}, [datasetFQN]);

8
openmetadata-ui/src/main/resources/ui/src/components/TableQueries/TableQueries.tsx
View File

@ -24,10 +24,14 @@ import Loader from '../Loader/Loader';
import QueryCard from './QueryCard';
interface TableQueriesProp {
isTableDeleted?: boolean;
tableId: string;
}
const TableQueries: FC<TableQueriesProp> = ({ tableId }: TableQueriesProp) => {
const TableQueries: FC<TableQueriesProp> = ({
isTableDeleted,
tableId,
}: TableQueriesProp) => {
const [tableQueries, setTableQueries] = useState<Table['tableQueries']>([]);
const [isQueriesLoading, setIsQueriesLoading] = useState(true);
@ -44,7 +48,7 @@ const TableQueries: FC<TableQueriesProp> = ({ tableId }: TableQueriesProp) => {
useEffect(() => {
setIsQueriesLoading(true);
if (tableId) {
if (tableId && !isTableDeleted) {
fetchTableQuery();
} else {
setIsQueriesLoading(false);

2
openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.component.tsx
View File

@ -825,7 +825,7 @@ const DatasetDetailsPage: FunctionComponent = () => {
}, [tablePermissions]);
useEffect(() => {
fetchTableProfileDetails();
!tableDetails.deleted && fetchTableProfileDetails();
}, [tableDetails]);
useEffect(() => {