yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 20:49:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed BulkEditEntity flaky test (#21209)

Browse Source 
* fixed BulkEditEntity flaky test

* fixed enter click issue

* removed changes that does not belongs to me in pr

* removed changes that does not belongs to me in pr

* removed unwated code

(cherry picked from commit c24a2dbdca9a8e9a99b0f53dc2373bdae1edb351)
This commit is contained in:
Dhruv Parmar 2025-05-19 12:09:36 +05:30 committed by Ashish Gupta
parent 2378e77219
commit 13c4e00a51
4 changed files with 13 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkEditEntity.spec.ts
View File

@ -194,20 +194,10 @@ test.describe('Bulk Edit Entity', () => {
// Verify Owners // Verify Owners
await expect( await expect(
page.getByRole('link', { page.getByTestId(EntityDataClass.user1.responseData?.['displayName'])
name: EntityDataClass.user1.responseData?.[
'displayName'
][0].toUpperCase(),
exact: true,
})
).toBeVisible(); ).toBeVisible();
await expect( await expect(
page.getByRole('link', { page.getByTestId(EntityDataClass.user2.responseData?.['displayName'])
name: EntityDataClass.user2.responseData?.[
'displayName'
][0].toUpperCase(),
exact: true,
})
).toBeVisible(); ).toBeVisible();
// Verify Tags // Verify Tags
@ -588,10 +578,10 @@ test.describe('Bulk Edit Entity', () => {
.locator('.inovua-react-toolkit-load-mask__background-layer') .locator('.inovua-react-toolkit-load-mask__background-layer')
.waitFor({ state: 'detached' }); .waitFor({ state: 'detached' });
await updateButtonResponse;
await page.waitForSelector('.message-banner-wrapper', { await page.waitForSelector('.message-banner-wrapper', {
state: 'detached', state: 'detached',
}); });
await updateButtonResponse;
await toastNotification(page, /details updated successfully/); await toastNotification(page, /details updated successfully/);
// Verify Details updated // Verify Details updated

10
openmetadata-ui/src/main/resources/ui/playwright/utils/customProperty.ts
View File

@ -690,15 +690,13 @@ export const addCustomPropertiesForEntity = async ({
); );
await page.click('[data-testid="create-button"]'); await page.click('[data-testid="create-button"]');
await page.waitForSelector('[data-testid="custom-property-form"]', {
state: 'detached',
});
await page.waitForLoadState('networkidle');
const response = await createPropertyPromise; const response = await createPropertyPromise;
expect(response.status()).toBe(200); expect(response.status()).toBe(200);
await page.waitForSelector('[data-testid="loader"]', {
state: 'detached',
});
await expect( await expect(
page.getByRole('row', { name: new RegExp(propertyName, 'i') }) page.getByRole('row', { name: new RegExp(propertyName, 'i') })
).toBeVisible(); ).toBeVisible();

10
openmetadata-ui/src/main/resources/ui/playwright/utils/importUtils.ts
View File

@ -39,13 +39,13 @@ export const createGlossaryTermRowDetails = () => {
}; };
export const fillTextInputDetails = async (page: Page, text: string) => { export const fillTextInputDetails = async (page: Page, text: string) => {
await page.keyboard.press('Enter'); await page.keyboard.press('Enter', { delay: 100 });
await page.locator('.ant-layout-content').getByRole('textbox').fill(text); const textboxLocator = page
await page
.locator('.ant-layout-content') .locator('.ant-layout-content')
.getByRole('textbox') .getByRole('textbox');
.press('Enter', { delay: 100 }); await textboxLocator.fill(text);
await textboxLocator.press('Enter', { delay: 100 });
}; };
export const fillDescriptionDetails = async ( export const fillDescriptionDetails = async (

1
openmetadata-ui/src/main/resources/ui/src/utils/RouterUtils.ts
View File

@ -50,6 +50,7 @@ import { PipelineType } from '../generated/api/services/ingestionPipelines/creat
import { DataQualityPageTabs } from '../pages/DataQuality/DataQualityPage.interface'; import { DataQualityPageTabs } from '../pages/DataQuality/DataQualityPage.interface';
import { IncidentManagerTabs } from '../pages/IncidentManager/IncidentManager.interface'; import { IncidentManagerTabs } from '../pages/IncidentManager/IncidentManager.interface';
import { getPartialNameFromFQN } from './CommonUtils'; import { getPartialNameFromFQN } from './CommonUtils';
import { getBasePath } from './HistoryUtils';
import { getServiceRouteFromServiceType } from './ServiceUtils'; import { getServiceRouteFromServiceType } from './ServiceUtils';
import { getEncodedFqn } from './StringsUtils'; import { getEncodedFqn } from './StringsUtils';