yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-29 11:26:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: test case indexing -- remove changeDescription from testSuites list (#17083)

Browse Source 
* fix: test case indexing -- remove changeDescription from testSuites list

* fix: change type to interface

* style: ran java linting
This commit is contained in:
Teddy 2024-07-19 08:19:45 +02:00 committed by GitHub
parent bc49f9e843
commit 13daa3668a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openmetadata-service/src/main/java/org/openmetadata/service/search/indexes/TestCaseIndex.java
View File

@ -15,7 +15,7 @@ import org.openmetadata.service.search.SearchIndexUtils;
import org.openmetadata.service.search.models.SearchSuggest; import org.openmetadata.service.search.models.SearchSuggest;
public record TestCaseIndex(TestCase testCase) implements SearchIndex { public record TestCaseIndex(TestCase testCase) implements SearchIndex {
private static final Set<String> excludeFields = Set.of("testSuites.changeDescription"); private static final Set<String> excludeFields = Set.of("changeDescription");
@Override @Override
public Object getEntity() { public Object getEntity() {
@ -23,8 +23,12 @@ public record TestCaseIndex(TestCase testCase) implements SearchIndex {
} }
@Override @Override
public Set<String> getExcludedFields() { public void removeNonIndexableFields(Map<String, Object> esDoc) {
return excludeFields; SearchIndex.super.removeNonIndexableFields(esDoc);
List<Map<String, Object>> testSuites = (List<Map<String, Object>>) esDoc.get("testSuites");
for (Map<String, Object> testSuite : testSuites) {
SearchIndexUtils.removeNonIndexableFields(testSuite, excludeFields);
}
} }
@SneakyThrows @SneakyThrows

25
openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
View File

@ -96,6 +96,7 @@ import org.openmetadata.service.resources.EntityResourceTest;
import org.openmetadata.service.resources.databases.TableResourceTest; import org.openmetadata.service.resources.databases.TableResourceTest;
import org.openmetadata.service.resources.feeds.FeedResourceTest; import org.openmetadata.service.resources.feeds.FeedResourceTest;
import org.openmetadata.service.resources.feeds.MessageParser; import org.openmetadata.service.resources.feeds.MessageParser;
import org.openmetadata.service.search.indexes.TestCaseIndex;
import org.openmetadata.service.util.JsonUtils; import org.openmetadata.service.util.JsonUtils;
import org.openmetadata.service.util.ResultList; import org.openmetadata.service.util.ResultList;
import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils;
@ -2026,6 +2027,30 @@ public class TestCaseResourceTest extends EntityResourceTest<TestCase, CreateTes
() -> createEntity(invalidTestCaseMixedTypes, ADMIN_AUTH_HEADERS), BAD_REQUEST, "Value"); () -> createEntity(invalidTestCaseMixedTypes, ADMIN_AUTH_HEADERS), BAD_REQUEST, "Value");
} }
@Test
void test_testCaseEsDocCleanUp(TestInfo testInfo) {
TestCase testCase =
new TestCase()
.withId(UUID.randomUUID())
.withChangeDescription(new ChangeDescription())
.withTestSuites(
List.of(
new TestSuite()
.withId(UUID.randomUUID())
.withChangeDescription(new ChangeDescription()),
new TestSuite()
.withId(UUID.randomUUID())
.withChangeDescription(new ChangeDescription())));
Map<String, Object> doc = JsonUtils.convertValue(testCase, Map.class);
TestCaseIndex testCaseIndex = new TestCaseIndex(testCase);
testCaseIndex.removeNonIndexableFields(doc);
assertNull(doc.get("changeDescription"));
List<Map<String, Object>> testSuites = (List<Map<String, Object>>) doc.get("testSuites");
assertNull(testSuites.get(0).get("changeDescription"));
}
public void deleteTestCaseResult(String fqn, Long timestamp, Map<String, String> authHeaders) public void deleteTestCaseResult(String fqn, Long timestamp, Map<String, String> authHeaders)
throws HttpResponseException { throws HttpResponseException {
WebTarget target = getCollection().path("/" + fqn + "/testCaseResult/" + timestamp); WebTarget target = getCollection().path("/" + fqn + "/testCaseResult/" + timestamp);