yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-17 19:33:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix lineage to support 'merge into' queries starting with comments (#8355)

Browse Source
This commit is contained in:
Nahuel 2022-10-25 19:29:59 +02:00 committed by GitHub
parent e9ebb4dd75
commit 1583adee29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/ingestion/lineage/sql_lineage.py
View File

@ -60,7 +60,7 @@ def clean_raw_query(raw_query: str) -> str:
replace_by=" ", replace_by=" ",
) )
if insensitive_match(clean_query, "merge into .*when matched.*"): if insensitive_match(clean_query, ".*merge into .*when matched.*"):
clean_query = insensitive_replace( clean_query = insensitive_replace(
raw_str=clean_query, raw_str=clean_query,
to_replace="when matched.*", # merge into queries specific to_replace="when matched.*", # merge into queries specific

4
ingestion/tests/unit/test_query_parser.py
View File

@ -166,10 +166,10 @@ class QueryParserTests(TestCase):
Validate query cleaning logic Validate query cleaning logic
""" """
query = """ query = """
merge into table_1 using (select a, b from table_2) when matched update set t.a = 'value' /* comment */ merge into table_1 using (select a, b from table_2) when matched update set t.a = 'value'
when not matched then insert (table_1.a, table_2.b) values ('value1', 'value2') when not matched then insert (table_1.a, table_2.b) values ('value1', 'value2')
""" """
self.assertEqual( self.assertEqual(
clean_raw_query(query), clean_raw_query(query),
"merge into table_1 using (select a, b from table_2)", "/* comment */ merge into table_1 using (select a, b from table_2)",
) )