From 16c7a3e09708c0b8bfb09ad04a35c6d0eb1d93ed Mon Sep 17 00:00:00 2001 From: Vivek Ratnavel Subramanian Date: Mon, 9 May 2022 02:38:28 -0700 Subject: [PATCH] UI: Remove debounce and timeout in add service forms (#4795) --- .../common/FormBuilder/FormBuilder.tsx | 27 +++++-------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/FormBuilder/FormBuilder.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/FormBuilder/FormBuilder.tsx index 565552aae7a..2fb0ffa62c8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/FormBuilder/FormBuilder.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/FormBuilder/FormBuilder.tsx @@ -14,9 +14,9 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import Form, { FormProps } from '@rjsf/core'; import classNames from 'classnames'; -import { debounce, isEmpty } from 'lodash'; +import { isEmpty } from 'lodash'; import { LoadingState } from 'Models'; -import React, { FunctionComponent, useCallback, useState } from 'react'; +import React, { FunctionComponent, useState } from 'react'; import { ConfigData } from '../../../interface/service.interface'; import { formatFormDataForRender } from '../../../utils/JSONSchemaFormUtils'; import SVGIcons, { Icons } from '../../../utils/SvgUtils'; @@ -74,34 +74,19 @@ const FormBuilder: FunctionComponent = ({ setConnectionTestingState('waiting'); onTestConnection(localFormData) .then(() => { - setTimeout(() => { - setConnectionTestingState('success'); - }, 500); + setConnectionTestingState('success'); }) .catch(() => { - setTimeout(() => { - setConnectionTestingState('initial'); - }, 500); + setConnectionTestingState('initial'); }) .finally(() => { - setTimeout(() => { - setConnectionTesting(false); - }, 500); + setConnectionTesting(false); }); } }; - const debouncedOnChange = useCallback( - (updatedData: ConfigData): void => { - setLocalFormData(updatedData); - }, - [setLocalFormData] - ); - const debounceOnSearch = useCallback(debounce(debouncedOnChange, 400), [ - debouncedOnChange, - ]); const handleChange = (updatedData: ConfigData) => { - debounceOnSearch(updatedData); + setLocalFormData(updatedData); }; const getConnectionTestingMessage = () => {