fix: alignment issue in tag, profiler (#1519)

This commit is contained in:
Shailesh Parmar 2021-12-03 10:10:39 +05:30 committed by GitHub
parent 7494b1e4c1
commit 16d8ba548d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 31 deletions

View File

@ -11,7 +11,7 @@
* limitations under the License. * limitations under the License.
*/ */
import { isEqual, isNil } from 'lodash'; import { isEqual, isNil, isUndefined } from 'lodash';
import { ColumnJoins, EntityTags } from 'Models'; import { ColumnJoins, EntityTags } from 'Models';
import React, { useEffect, useState } from 'react'; import React, { useEffect, useState } from 'react';
import { getTeamDetailsPath } from '../../constants/constants'; import { getTeamDetailsPath } from '../../constants/constants';
@ -216,26 +216,27 @@ const DatasetDetails: React.FC<DatasetDetailsProps> = ({
}, },
{ {
key: 'Rows', key: 'Rows',
value: tableProfile ? ( value:
<TableProfilerGraph !isUndefined(tableProfile) && tableProfile.length > 0 ? (
className="tw--mt-5" <TableProfilerGraph
data={ className="tw--mt-5"
tableProfile data={
?.map((d) => ({ tableProfile
date: d.profileDate, ?.map((d) => ({
value: d.rowCount ?? 0, date: d.profileDate,
})) value: d.rowCount ?? 0,
.reverse() as Array<{ }))
date: Date; .reverse() as Array<{
value: number; date: Date;
}> value: number;
} }>
height={38} }
toolTipPos={{ x: 20, y: -30 }} height={38}
/> toolTipPos={{ x: 20, y: -30 }}
) : ( />
'--' ) : (
), '--'
),
}, },
]; ];

View File

@ -334,12 +334,13 @@ const EntityPageInfo = ({
html={ html={
<> <>
{tags.slice(LIST_SIZE).map((tag, index) => ( {tags.slice(LIST_SIZE).map((tag, index) => (
<Tags <p className="tw-text-left" key={index}>
className="tw-bg-tag tw-px-2" <Tags
key={index} className="tw-bg-tag tw-px-2"
startWith="#" startWith="#"
tag={tag} tag={tag}
/> />
</p>
))} ))}
</> </>
} }

View File

@ -75,10 +75,7 @@ const Tags: FunctionComponent<TagProps> = ({
<div className="tw-text-left tw-p-1"> <div className="tw-text-left tw-p-1">
{tag.description && ( {tag.description && (
<div className="tw-mb-3"> <div className="tw-mb-3">
<RichTextEditorPreviewer <RichTextEditorPreviewer markdown={tag.description} />
className="tw-p-2"
markdown={tag.description}
/>
</div> </div>
)} )}
<p>Set as {tag.labelType}</p> <p>Set as {tag.labelType}</p>