yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-18 05:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix(ui): Added displayName to add Asset Selection Model (#21544)

Browse Source 
* added displayName to add assetmodal

* fixed persona glossery
This commit is contained in:
Dhruv Parmar 2025-06-05 12:22:06 +05:30 committed by GitHub
parent cfd548556e
commit 1df7aacae4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 40 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openmetadata-ui/src/main/resources/ui/playwright/utils/domain.ts
View File

@ -339,17 +339,25 @@ export const addAssetsToDomain = async (
for (const asset of assets) {
const name = get(asset, 'entityResponseData.name');
const fqn = get(asset, 'entityResponseData.fullyQualifiedName');
const entityDisplayName = get(asset, 'entityResponseData.displayName');
const visibleName = entityDisplayName ?? name;
const searchRes = page.waitForResponse(
`/api/v1/search/query?q=${name}&index=all&from=0&size=25&*`
`/api/v1/search/query?q=${visibleName}&index=all&from=0&size=25&*`
);
await page
.getByTestId('asset-selection-modal')
.getByTestId('searchbar')
.fill(name);
.fill(visibleName);
await searchRes;
await page.locator(`[data-testid="table-data-card_${fqn}"] input`).check();
await expect(
page.locator(
`[data-testid="table-data-card_${fqn}"] [data-testid="entity-header-name"]`
)
).toContainText(visibleName);
}
const assetsAddRes = page.waitForResponse(`/api/v1/domains/*/assets/add`);

10
openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts
View File

@ -696,17 +696,25 @@ export const addAssetToGlossaryTerm = async (
const entityFqn = get(asset, 'entityResponseData.fullyQualifiedName');
const entityName = get(asset, 'entityResponseData.name');
const searchRes = page.waitForResponse('/api/v1/search/query*');
const entityDisplayName = get(asset, 'entityResponseData.displayName');
const visibleName = entityDisplayName ?? entityName;
await page
.locator(
'[data-testid="asset-selection-modal"] [data-testid="searchbar"]'
)
.fill(entityName);
.fill(visibleName);
await searchRes;
await page.click(
`[data-testid="table-data-card_${entityFqn}"] input[type="checkbox"]`
);
await expect(
page.locator(
`[data-testid="table-data-card_${entityFqn}"] [data-testid="entity-header-name"]`
)
).toContainText(visibleName);
}
await page.click('[data-testid="save-btn"]');

21
openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts
View File

@ -113,34 +113,43 @@ export const addAssetsToTag = async (
if (!isUndefined(otherAsset)) {
for (const asset of otherAsset) {
const name = get(asset, 'entityResponseData.name');
const entityDisplayName = get(asset, 'entityResponseData.displayName');
const visibleName = entityDisplayName ?? name;
const searchRes = page.waitForResponse(
`/api/v1/search/query?q=${name}&index=all&from=0&size=25&**`
`/api/v1/search/query?q=${visibleName}&index=all&from=0&size=25&**`
);
await page
.getByTestId('asset-selection-modal')
.getByTestId('searchbar')
.fill(name);
.fill(visibleName);
await searchRes;
await expect(page.getByText(name)).not.toBeVisible();
await expect(page.getByText(visibleName)).not.toBeVisible();
}
}
for (const asset of assets) {
const name = get(asset, 'entityResponseData.name');
const fqn = get(asset, 'entityResponseData.fullyQualifiedName');
const entityDisplayName = get(asset, 'entityResponseData.displayName');
const visibleName = entityDisplayName ?? name;
const searchRes = page.waitForResponse(
`/api/v1/search/query?q=${name}&index=all&from=0&size=25&**`
`/api/v1/search/query?q=${visibleName}&index=all&from=0&size=25&**`
);
await page
.getByTestId('asset-selection-modal')
.getByTestId('searchbar')
.fill(name);
.fill(visibleName);
await searchRes;
await page.locator(`[data-testid="table-data-card_${fqn}"] input`).check();
await expect(
page.locator(
`[data-testid="table-data-card_${fqn}"] [data-testid="entity-header-name"]`
)
).toContainText(visibleName);
}
const assetsAddRes = page.waitForResponse(`/api/v1/tags/*/assets/add`);

3
openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityHeader/EntityHeader.component.tsx
View File

@ -38,6 +38,7 @@ interface Props {
showName?: boolean;
nameClassName?: string;
displayNameClassName?: string;
showOnlyDisplayName?: boolean;
}
export const EntityHeader = ({
@ -54,6 +55,7 @@ export const EntityHeader = ({
showName = true,
nameClassName = '',
displayNameClassName = '',
showOnlyDisplayName = false,
}: Props) => {
return (
<div className="w-full">
@ -83,6 +85,7 @@ export const EntityHeader = ({
openEntityInNewPage={openEntityInNewPage}
serviceName={serviceName}
showName={showName}
showOnlyDisplayName={showOnlyDisplayName}
/>
</div>
);

3
openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryHeader/GlossaryHeaderWidget.tsx
View File

@ -49,11 +49,12 @@ export const GlossaryHeaderWidget = ({
return (
<div className="p-x-md p-y-sm">
<EntityHeader
showName
breadcrumb={[
{ name: 'Glossaries', url: '#', activeTitle: false },
{ name: 'Glossary Term', url: '#', activeTitle: false },
]}
entityData={{ name: 'Glossary Term' }}
entityData={{ name: 'Glossary Term', displayName: 'Glossary Term' }}
entityType={EntityType.GLOSSARY_TERM}
icon={icon}
serviceName=""

1
openmetadata-ui/src/main/resources/ui/src/components/common/TableDataCardV2/TableDataCardV2.tsx
View File

@ -155,6 +155,7 @@ const TableDataCardV2: React.FC<TableDataCardPropsV2> = forwardRef<
)}
<Col flex="auto">
<EntityHeader
showOnlyDisplayName
titleIsLink
breadcrumb={breadcrumbs}
displayNameClassName={displayNameClassName}