yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-01 11:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused methods in ResultList implementations (#8378)

Browse Source 
* Fixes 8371 Remove bot flag from authorizeAdmin method

* Remove authorizeAdminOrBot method

* Fix merge errors

* Remove unused constructor methods
This commit is contained in:
Suresh Srinivas 2022-10-27 07:58:03 -07:00 committed by GitHub
parent 1732d85dd6
commit 1f4d16dab0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
33 changed files with 1 additions and 167 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/analytics/ReportDataResource.java
View File

@ -8,7 +8,6 @@ import io.swagger.v3.oas.annotations.media.Content;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import javax.validation.Valid;
import javax.ws.rs.Consumes;
import javax.ws.rs.GET;
@ -54,10 +53,6 @@ public class ReportDataResource {
public ReportDataResultList() {
/* Required for serde */
}
public ReportDataResultList(List<ReportData> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/analytics/WebAnalyticEventResource.java
View File

@ -89,11 +89,6 @@ public class WebAnalyticEventResource extends EntityResource<WebAnalyticEvent, W
public WebAnalyticEventDataList() {
// Empty constructor needed for deserialization
}
public WebAnalyticEventDataList(
List<WebAnalyticEventData> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@SuppressWarnings("unused") // Method used for reflection of webAnalyticEventTypes

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/bots/BotResource.java
View File

@ -130,10 +130,6 @@ public class BotResource extends EntityResource<Bot, BotRepository> {
public BotList() {
/* Required for serde */
}
public BotList(List<Bot> data) {
super(data);
}
}
@GET

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/charts/ChartResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -85,10 +84,6 @@ public class ChartResource extends EntityResource<Chart, ChartRepository> {
ChartList() {
// Empty constructor needed for deserialization
}
public ChartList(List<Chart> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,followers,tags";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/dashboards/DashboardResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -84,10 +83,6 @@ public class DashboardResource extends EntityResource<Dashboard, DashboardReposi
DashboardList() {
// Empty constructor needed for deserialization
}
public DashboardList(List<Dashboard> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,charts,followers,tags,usageSummary,extension";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -83,10 +82,6 @@ public class DatabaseResource extends EntityResource<Database, DatabaseRepositor
public static class DatabaseList extends ResultList<Database> {
@SuppressWarnings("unused") // Empty constructor needed for deserialization
DatabaseList() {}
public DatabaseList(List<Database> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,databaseSchemas,usageSummary,location";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/DatabaseSchemaResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -82,10 +81,6 @@ public class DatabaseSchemaResource extends EntityResource<DatabaseSchema, Datab
public static class DatabaseSchemaList extends ResultList<DatabaseSchema> {
@SuppressWarnings("unused") // Empty constructor needed for deserialization
DatabaseSchemaList() {}
public DatabaseSchemaList(List<DatabaseSchema> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,tables,usageSummary";

12
openmetadata-service/src/main/java/org/openmetadata/service/resources/databases/TableResource.java
View File

@ -125,10 +125,6 @@ public class TableResource extends EntityResource<Table, TableRepository> {
public TableList() {
/* Required for serde */
}
public TableList(List<Table> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static class TableProfileList extends ResultList<TableProfile> {
@ -136,10 +132,6 @@ public class TableResource extends EntityResource<Table, TableRepository> {
public TableProfileList() {
/* Required for serde */
}
public TableProfileList(List<TableProfile> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static class ColumnProfileList extends ResultList<ColumnProfile> {
@ -147,10 +139,6 @@ public class TableResource extends EntityResource<Table, TableRepository> {
public ColumnProfileList() {
/* Required for serde */
}
public ColumnProfileList(List<ColumnProfile> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS =

9
openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java
View File

@ -13,7 +13,6 @@ import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -92,10 +91,6 @@ public class TestCaseResource extends EntityResource<TestCase, TestCaseRepositor
public TestCaseList() {
// Empty constructor needed for deserialization
}
public TestCaseList(List<TestCase> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static class TestCaseResultList extends ResultList<TestCaseResult> {
@ -103,10 +98,6 @@ public class TestCaseResource extends EntityResource<TestCase, TestCaseRepositor
public TestCaseResultList() {
/* Required for serde */
}
public TestCaseResultList(List<TestCaseResult> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestDefinitionResource.java
View File

@ -88,10 +88,6 @@ public class TestDefinitionResource extends EntityResource<TestDefinition, TestD
public TestDefinitionList() {
// Empty constructor needed for deserialization
}
public TestDefinitionList(List<TestDefinition> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java
View File

@ -11,7 +11,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -76,10 +75,6 @@ public class TestSuiteResource extends EntityResource<TestSuite, TestSuiteReposi
public TestSuiteList() {
// Empty constructor needed for deserialization
}
public TestSuiteList(List<TestSuite> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/events/WebhookResource.java
View File

@ -82,10 +82,6 @@ public class WebhookResource extends EntityResource<Webhook, WebhookRepository>
@SuppressWarnings("unused") /* Required for tests */
public WebhookList() {}
public WebhookList(List<Webhook> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public WebhookResource(CollectionDAO dao, Authorizer authorizer) {

9
openmetadata-service/src/main/java/org/openmetadata/service/resources/feeds/FeedResource.java
View File

@ -69,6 +69,7 @@ import org.openmetadata.service.jdbi3.FeedRepository;
import org.openmetadata.service.jdbi3.FeedRepository.FilterType;
import org.openmetadata.service.jdbi3.FeedRepository.PaginationType;
import org.openmetadata.service.resources.Collection;
import org.openmetadata.service.resources.feeds.FeedResource.ThreadList;
import org.openmetadata.service.resources.feeds.MessageParser.EntityLink;
import org.openmetadata.service.security.Authorizer;
import org.openmetadata.service.security.policyevaluator.OperationContext;
@ -109,20 +110,12 @@ public class FeedResource {
static class ThreadList extends ResultList<Thread> {
@SuppressWarnings("unused") // Used for deserialization
ThreadList() {}
ThreadList(List<Thread> data) {
super(data);
}
}
public static class PostList extends ResultList<Post> {
@SuppressWarnings("unused") /* Required for tests */
public PostList() {}
public PostList(List<Post> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
public PostList(List<Post> listPosts) {
super(listPosts);
}

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/glossary/GlossaryResource.java
View File

@ -24,7 +24,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -86,10 +85,6 @@ public class GlossaryResource extends EntityResource<Glossary, GlossaryRepositor
GlossaryList() {
// Empty constructor needed for deserialization
}
public GlossaryList(List<Glossary> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,tags,reviewers,usageCount";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/glossary/GlossaryTermResource.java
View File

@ -24,7 +24,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -93,10 +92,6 @@ public class GlossaryTermResource extends EntityResource<GlossaryTerm, GlossaryT
GlossaryTermList() {
// Empty constructor needed for deserialization
}
public GlossaryTermList(List<GlossaryTerm> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "children,relatedTerms,reviewers,tags,usageCount";

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/locations/LocationResource.java
View File

@ -85,10 +85,6 @@ public class LocationResource extends EntityResource<Location, LocationRepositor
public static class LocationList extends ResultList<Location> {
@SuppressWarnings("unused") /* Required for tests */
public LocationList() {}
public LocationList(List<Location> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,followers,tags,path";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/mlmodels/MlModelResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -87,10 +86,6 @@ public class MlModelResource extends EntityResource<MlModel, MlModelRepository>
MlModelList() {
// Empty constructor needed for deserialization
}
public MlModelList(List<MlModel> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,dashboard,followers,tags,usageSummary,extension";

9
openmetadata-service/src/main/java/org/openmetadata/service/resources/pipelines/PipelineResource.java
View File

@ -23,7 +23,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -91,10 +90,6 @@ public class PipelineResource extends EntityResource<Pipeline, PipelineRepositor
PipelineList() {
// Empty constructor needed for deserialization
}
public PipelineList(List<Pipeline> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static class PipelineStatusList extends ResultList<PipelineStatus> {
@ -102,10 +97,6 @@ public class PipelineResource extends EntityResource<Pipeline, PipelineRepositor
public PipelineStatusList() {
/* Required for serde */
}
public PipelineStatusList(List<PipelineStatus> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,tasks,pipelineStatus,followers,tags,extension";

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/policies/PolicyResource.java
View File

@ -107,10 +107,6 @@ public class PolicyResource extends EntityResource<Policy, PolicyRepository> {
PolicyList() {
// Empty constructor needed for deserialization
}
public PolicyList(List<Policy> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static class ResourceDescriptorList extends ResultList<ResourceDescriptor> {

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/dashboard/DashboardServiceResource.java
View File

@ -85,10 +85,6 @@ public class DashboardServiceResource
public static class DashboardServiceList extends ResultList<DashboardService> {
@SuppressWarnings("unused") /* Required for tests */
public DashboardServiceList() {}
public DashboardServiceList(List<DashboardService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/database/DatabaseServiceResource.java
View File

@ -86,10 +86,6 @@ public class DatabaseServiceResource
public static class DatabaseServiceList extends ResultList<DatabaseService> {
@SuppressWarnings("unused") /* Required for tests */
public DatabaseServiceList() {}
public DatabaseServiceList(List<DatabaseService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java
View File

@ -110,10 +110,6 @@ public class IngestionPipelineResource extends EntityResource<IngestionPipeline,
public IngestionPipelineList() {
// Empty constructor needed for deserialization
}
public IngestionPipelineList(List<IngestionPipeline> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = FIELD_OWNER;

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/messaging/MessagingServiceResource.java
View File

@ -85,10 +85,6 @@ public class MessagingServiceResource
public static class MessagingServiceList extends ResultList<MessagingService> {
@SuppressWarnings("unused") /* Required for tests */
public MessagingServiceList() {}
public MessagingServiceList(List<MessagingService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/mlmodel/MlModelServiceResource.java
View File

@ -84,10 +84,6 @@ public class MlModelServiceResource
public static class MlModelServiceList extends ResultList<MlModelService> {
@SuppressWarnings("unused") /* Required for tests */
public MlModelServiceList() {}
public MlModelServiceList(List<MlModelService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/pipeline/PipelineServiceResource.java
View File

@ -83,10 +83,6 @@ public class PipelineServiceResource
public static class PipelineServiceList extends ResultList<PipelineService> {
@SuppressWarnings("unused") /* Required for tests */
public PipelineServiceList() {}
public PipelineServiceList(List<PipelineService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/services/storage/StorageServiceResource.java
View File

@ -22,7 +22,6 @@ import io.swagger.v3.oas.annotations.media.Content;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.validation.Valid;
import javax.validation.constraints.Max;
@ -80,10 +79,6 @@ public class StorageServiceResource extends EntityResource<StorageService, Stora
public static class StorageServiceList extends ResultList<StorageService> {
@SuppressWarnings("unused") /* Required for tests */
public StorageServiceList() {}
public StorageServiceList(List<StorageService> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
@GET

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/settings/SettingsResource.java
View File

@ -118,10 +118,6 @@ public class SettingsResource {
public SettingsList() {
/* Required for serde */
}
public SettingsList(List<Settings> data) {
super(data);
}
}
public SettingsResource(CollectionDAO dao, Authorizer authorizer) {

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/tags/TagResource.java
View File

@ -81,10 +81,6 @@ public class TagResource {
static class CategoryList extends ResultList<TagCategory> {
@SuppressWarnings("unused") // Empty constructor needed for deserialization
CategoryList() {}
CategoryList(List<TagCategory> data) {
super(data);
}
}
public TagResource(CollectionDAO collectionDAO, Authorizer authorizer) {

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/RoleResource.java
View File

@ -105,10 +105,6 @@ public class RoleResource extends EntityResource<Role, RoleRepository> {
public static class RoleList extends ResultList<Role> {
@SuppressWarnings("unused") /* Required for tests */
RoleList() {}
public RoleList(List<Role> roles, String beforeCursor, String afterCursor, int total) {
super(roles, beforeCursor, afterCursor, total);
}
}
public static final String FIELDS = "policies,teams,users";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/TeamResource.java
View File

@ -27,7 +27,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -99,10 +98,6 @@ public class TeamResource extends EntityResource<Team, TeamRepository> {
public static class TeamList extends ResultList<Team> {
@SuppressWarnings("unused") /* Required for tests */
TeamList() {}
public TeamList(List<Team> teams, String beforeCursor, String afterCursor, int total) {
super(teams, beforeCursor, afterCursor, total);
}
}
public static class TeamHierarchyList extends ResultList<TeamHierarchy> {

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/UserResource.java
View File

@ -184,10 +184,6 @@ public class UserResource extends EntityResource<User, UserRepository> {
public static class UserList extends ResultList<User> {
@SuppressWarnings("unused") // Used for deserialization
public UserList() {}
public UserList(List<User> users, String beforeCursor, String afterCursor, int total) {
super(users, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "profile,roles,teams,follows,owns";

5
openmetadata-service/src/main/java/org/openmetadata/service/resources/topics/TopicResource.java
View File

@ -24,7 +24,6 @@ import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.parameters.RequestBody;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import java.io.IOException;
import java.util.List;
import java.util.UUID;
import javax.json.JsonPatch;
import javax.validation.Valid;
@ -89,10 +88,6 @@ public class TopicResource extends EntityResource<Topic, TopicRepository> {
public TopicList() {
// Empty constructor needed for deserialization
}
public TopicList(List<Topic> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
static final String FIELDS = "owner,followers,tags,sampleData,extension";

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/types/TypeResource.java
View File

@ -125,10 +125,6 @@ public class TypeResource extends EntityResource<Type, TypeRepository> {
TypeList() {
// Empty constructor needed for deserialization
}
public TypeList(List<Type> data, String beforeCursor, String afterCursor, int total) {
super(data, beforeCursor, afterCursor, total);
}
}
public static final String PROPERTIES = "customProperties";