yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-03 06:03:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Glossary Page issue (#7249)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2022-09-06 13:45:22 +05:30 committed by GitHub
parent a7e39ffd14
commit 1fa05327bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryV1.component.tsx
View File

@ -309,8 +309,9 @@ const GlossaryV1 = ({
Delete Delete
</p> </p>
<p className="tw-text-grey-muted tw-text-xs"> <p className="tw-text-grey-muted tw-text-xs">
Deleting this Glossary will permanently remove its metadata Deleting this{' '}
from OpenMetadata. {isGlossaryActive ? 'Glossary' : 'GlossaryTerm'} will
permanently remove its metadata from OpenMetadata.
</p> </p>
</div> </div>
</Space> </Space>
@ -387,10 +388,13 @@ const GlossaryV1 = ({
useEffect(() => { useEffect(() => {
setDisplayName(selectedData?.displayName); setDisplayName(selectedData?.displayName);
if (selectedData) { if (selectedData) {
fetchGlossaryPermission(); if (isGlossaryActive) {
fetchGlossaryTermPermission(); fetchGlossaryPermission();
} else {
fetchGlossaryTermPermission();
}
} }
}, [selectedData]); }, [selectedData, isGlossaryActive]);
return glossaryList.length ? ( return glossaryList.length ? (
<PageLayoutV1 leftPanel={fetchLeftPanel()}> <PageLayoutV1 leftPanel={fetchLeftPanel()}>
@ -439,14 +443,18 @@ const GlossaryV1 = ({
onVisibleChange={setShowActions}> onVisibleChange={setShowActions}>
<Tooltip <Tooltip
title={ title={
glossaryPermission.Delete glossaryPermission.Delete || glossaryTermPermission.Delete
? 'Manage Glossary' ? isGlossaryActive
? 'Manage Glossary'
: 'Manage GlossaryTerm'
: NO_PERMISSION_FOR_ACTION : NO_PERMISSION_FOR_ACTION
}> }>
<Button <Button
className="tw-rounded tw-justify-center tw-w-8 tw-h-8 glossary-manage-button tw-flex" className="tw-rounded tw-justify-center tw-w-8 tw-h-8 glossary-manage-button tw-flex"
data-testid="manage-button" data-testid="manage-button"
disabled={!glossaryPermission.Delete} disabled={
!(glossaryPermission.Delete || glossaryTermPermission.Delete)
}
size="small" size="small"
theme="primary" theme="primary"
variant="outlined" variant="outlined"