yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-18 14:39:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: hide username field on signup screen (#17144)

Browse Source 
* minor: hide username field on signup screen

* add tests

* fix cypress for owner search

* fix data quality and profiler spec
This commit is contained in:
Chirag Madlani 2024-07-25 21:46:40 +05:30 committed by GitHub
parent 77529d4fa0
commit 21579b13d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.ts
View File

@ -227,7 +227,7 @@ const fillForm = (formObj, type) => {
cy.get('[data-testid="add-experts"]').scrollIntoView().click(); cy.get('[data-testid="add-experts"]').scrollIntoView().click();
verifyResponseStatusCode('@getUsers', 200); verifyResponseStatusCode('@getUsers', 200);
cy.get('[data-testid="loader"]').should('not.exist'); cy.get('[data-testid="loader"]').should('not.exist');
interceptURL( interceptURL(
'GET', 'GET',
`api/v1/search/query?q=*${encodeURI(formObj.experts)}*`, `api/v1/search/query?q=*${encodeURI(formObj.experts)}*`,

6
openmetadata-ui/src/main/resources/ui/cypress/common/Utils/Owner.ts
View File

@ -88,6 +88,7 @@ export const addOwner = (
.click({ waitForAnimations: false }); .click({ waitForAnimations: false });
verifyResponseStatusCode('@getUsers', 200); verifyResponseStatusCode('@getUsers', 200);
cy.get('[data-testid="loader"]').should('not.exist');
interceptURL( interceptURL(
'GET', 'GET',
`api/v1/search/query?q=*&index=user_search_index*`, `api/v1/search/query?q=*&index=user_search_index*`,
@ -113,12 +114,11 @@ export const addOwner = (
}; };
export const updateOwner = (ownerName: string, dataTestId?: string) => { export const updateOwner = (ownerName: string, dataTestId?: string) => {
interceptURL('GET', '/api/v1/users?*isBot=false*', 'getUsers');
cy.get('[data-testid="edit-owner"]').click(); cy.get('[data-testid="edit-owner"]').click();
cy.get("[data-testid='select-owner-tabs']").should('be.visible'); cy.get("[data-testid='select-owner-tabs']").should('be.visible');
cy.get('.ant-tabs [id*=tab-users]').click(); cy.get('.ant-tabs [id*=tab-users]').click();
verifyResponseStatusCode('@getUsers', 200); cy.get('[data-testid="loader"]').should('not.exist');
interceptURL( interceptURL(
'GET', 'GET',
`api/v1/search/query?q=*${encodeURI(ownerName)}*&index=user_search_index`, `api/v1/search/query?q=*${encodeURI(ownerName)}*&index=user_search_index`,

1
openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/QueryEntity.spec.ts
View File

@ -183,6 +183,7 @@ describe('Query Entity', { tags: 'DataAssets' }, () => {
// Update owner // Update owner
cy.get(':nth-child(2) > [data-testid="edit-owner"]').click(); cy.get(':nth-child(2) > [data-testid="edit-owner"]').click();
verifyResponseStatusCode('@getUsers', 200); verifyResponseStatusCode('@getUsers', 200);
cy.get('[data-testid="loader"]').should('not.exist');
interceptURL( interceptURL(
'GET', 'GET',
`api/v1/search/query?q=*${encodeURI(DATA.owner)}*`, `api/v1/search/query?q=*${encodeURI(DATA.owner)}*`,

9
openmetadata-ui/src/main/resources/ui/src/pages/SignUp/SignUpPage.test.tsx
View File

@ -204,4 +204,13 @@ describe('SignUp page', () => {
expect(createUser as jest.Mock).toHaveBeenCalledTimes(0); expect(createUser as jest.Mock).toHaveBeenCalledTimes(0);
}); });
it('should have username as hidden field', async () => {
render(<SignUp />);
const usernameInput = screen.getByTestId('username-label');
usernameInput.parentElement?.parentElement;
expect(usernameInput.parentElement).toHaveClass('ant-form-item-hidden');
});
}); });

1
openmetadata-ui/src/main/resources/ui/src/pages/SignUp/SignUpPage.tsx
View File

@ -163,6 +163,7 @@ const SignUp = () => {
</Form.Item> </Form.Item>
<Form.Item <Form.Item
hidden
data-testid="username-label" data-testid="username-label"
label={t('label.username')} label={t('label.username')}
name="name" name="name"