From 21a3b14c281c874ca33748bffabaddf0e4895f9f Mon Sep 17 00:00:00 2001 From: karanh37 <33024356+karanh37@users.noreply.github.com> Date: Mon, 23 Oct 2023 22:41:45 +0530 Subject: [PATCH] UI feedbacks (#13684) * fix: minor ui feedbacks * fix: feedbacks * fix: css on explore * fix: domain cypress * fix: profile picture alignment issues --- .../ui/cypress/common/DomainUtils.js | 10 ++++- .../ui/cypress/e2e/Pages/Domains.spec.js | 2 +- .../resources/ui/src/assets/svg/ic-domain.svg | 9 +++- .../DataProductsDetailsPage.component.tsx | 2 +- .../DomainExperts/DomainExperts.component.tsx | 1 + .../GlossaryTermSummary.component.tsx | 4 +- .../components/ExploreV1/ExploreV1.style.less | 1 + .../GlossaryDetailsRightPanel.component.tsx | 1 + .../GlossaryReviewers.tsx | 1 + .../Tag/TagsContainerV2/TagsContainerV2.tsx | 8 ++-- .../common/PopOverCard/UserPopOverCard.tsx | 2 +- .../ui/src/locale/languages/de-de.json | 2 +- .../ui/src/locale/languages/en-us.json | 2 +- .../ui/src/locale/languages/es-es.json | 2 +- .../ui/src/locale/languages/fr-fr.json | 2 +- .../ui/src/locale/languages/ja-jp.json | 2 +- .../ui/src/locale/languages/pt-br.json | 2 +- .../ui/src/locale/languages/ru-ru.json | 2 +- .../ui/src/locale/languages/zh-cn.json | 2 +- .../pages/MarketPlacePage/MarketPlacePage.tsx | 45 ++++++++++++++++--- .../pages/MarketPlacePage/market-place.less | 4 +- .../src/pages/TasksPage/shared/Assignee.less | 6 +++ .../src/pages/TasksPage/shared/Assignees.tsx | 10 ++++- .../src/main/resources/ui/src/styles/app.less | 4 -- .../styles/components/profile-picture.less | 2 +- .../resources/ui/src/utils/DomainUtils.tsx | 1 + .../resources/ui/src/utils/TableUtils.tsx | 15 ++++++- 27 files changed, 107 insertions(+), 37 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js b/openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js index 639cbd5dbba..b575d083b4b 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js @@ -132,6 +132,10 @@ export const updateAssets = (domainObj) => { cy.get('[data-testid="domain-link"]').should('contain', domainObj.name); + cy.get('[data-testid="app-bar-item-domain"]') + .should('be.visible') + .click({ force: true }); + goToAssetsTab(domainObj); cy.get('.assets-data-container [data-testid="entity-header-display-name"]') @@ -147,7 +151,7 @@ export const removeAssets = (domainObj) => { verifyResponseStatusCode('@assetTab', 200); interceptURL('GET', '/api/v1/domain*', 'domains'); - interceptURL('PATCH', '/api/v1/table/*', 'patchDomain'); + interceptURL('PATCH', '/api/v1/tables/*', 'patchDomain'); cy.get('[data-testid="entity-header-display-name"]') .contains(entity.term) @@ -160,6 +164,10 @@ export const removeAssets = (domainObj) => { cy.get('[data-testid="remove-owner"]').click(); verifyResponseStatusCode('@patchDomain', 200); + cy.get('[data-testid="app-bar-item-domain"]') + .should('be.visible') + .click({ force: true }); + goToAssetsTab(domainObj); cy.contains('Adding a new Asset is easy, just give it a spin!').should( 'be.visible' diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Domains.spec.js b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Domains.spec.js index 6aebab6e51f..b833dda73f0 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Domains.spec.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Domains.spec.js @@ -57,7 +57,7 @@ describe('Domain page should work properly', () => { updateDomainDetails(DOMAIN_1); }); - it.skip('Assets Tab should work properly', () => { + it('Assets Tab should work properly', () => { updateAssets(DOMAIN_1); }); diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-domain.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-domain.svg index ff47af7ff9b..bdac92e51e8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-domain.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-domain.svg @@ -1,3 +1,8 @@ - - + + + + + + + diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx index 5dbf26bf372..57cce913ad6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx @@ -289,7 +289,7 @@ const DataProductsDetailsPage = ({ entityType: t('label.data-product'), } )} - icon={} + icon={} id="delete-button" name={t('label.delete')} /> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainExperts/DomainExperts.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainExperts/DomainExperts.component.tsx index 8644f2346f8..3f5d8cca835 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainExperts/DomainExperts.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainExperts/DomainExperts.component.tsx @@ -65,6 +65,7 @@ function DomainExperts({ id={expert.id} name={expert.name ?? ''} textClass="text-xs" + type="circle" width="20" /> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Explore/EntitySummaryPanel/GlossaryTermSummary/GlossaryTermSummary.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Explore/EntitySummaryPanel/GlossaryTermSummary/GlossaryTermSummary.component.tsx index 78eea3150a0..5d5d4cf78a0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Explore/EntitySummaryPanel/GlossaryTermSummary/GlossaryTermSummary.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Explore/EntitySummaryPanel/GlossaryTermSummary/GlossaryTermSummary.component.tsx @@ -91,9 +91,7 @@ function GlossaryTermSummary({ - {t('label.no-entity', { - entity: t('label.children-lowercase'), - })} + {t('label.no-reviewer')} )} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.style.less b/openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.style.less index e69d317b788..1e19b13eae4 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.style.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ExploreV1/ExploreV1.style.less @@ -68,6 +68,7 @@ .custom-menu.ant-menu-root.ant-menu-inline { .ant-menu-item { height: 40px; + width: 100%; } } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryDetailsRightPanel/GlossaryDetailsRightPanel.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryDetailsRightPanel/GlossaryDetailsRightPanel.component.tsx index 897d8808f3e..b55ad52ddf2 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryDetailsRightPanel/GlossaryDetailsRightPanel.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryDetailsRightPanel/GlossaryDetailsRightPanel.component.tsx @@ -117,6 +117,7 @@ const GlossaryDetailsRightPanel = ({ id={owner?.id || ''} name={owner?.name ?? ''} textClass="text-xs" + type="circle" width="20" /> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Tag/TagsContainerV2/TagsContainerV2.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Tag/TagsContainerV2/TagsContainerV2.tsx index cce2d62a136..75ff7026b50 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Tag/TagsContainerV2/TagsContainerV2.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Tag/TagsContainerV2/TagsContainerV2.tsx @@ -255,7 +255,7 @@ const TagsContainerV2 = ({ : t('label.request-tag-plural') }> permission && !isEmpty(tags?.[tagType]) ? ( = ({ children, userName, type = 'user' }) => { return ( - +