yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-08 23:14:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Reset form on submit and cancel"

Browse Source 
This reverts commit e2a19cfd1005d0d967530931287c0a125595eef7.
This commit is contained in:
karanh37 2025-09-25 11:40:35 +05:30
parent e2a19cfd10
commit 2381de0722
2 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx
View File

@ -303,7 +303,7 @@ const AddDomainForm = ({
delete (data as CreateDomain & { domains?: unknown }).domains; delete (data as CreateDomain & { domains?: unknown }).domains;
} }
onSubmit(data); onSubmit(data).then(() => form.resetFields());
}; };
return ( return (

15
openmetadata-ui/src/main/resources/ui/src/components/common/atoms/drawer/useFormDrawer.tsx
View File

@ -24,7 +24,6 @@ export interface FormDrawerConfig<T = any>
form: ReactNode; form: ReactNode;
onSubmit: (data: T) => Promise<void> | void; onSubmit: (data: T) => Promise<void> | void;
onCancel?: () => void; onCancel?: () => void;
onReset?: () => void;
submitLabel?: string; submitLabel?: string;
cancelLabel?: string; cancelLabel?: string;
loading?: boolean; loading?: boolean;
@ -85,7 +84,6 @@ export const useFormDrawer = <T = any,>(config: FormDrawerConfig<T>) => {
form, form,
onSubmit, onSubmit,
onCancel, onCancel,
onReset,
submitLabel = t('label.save'), submitLabel = t('label.save'),
cancelLabel = t('label.cancel'), cancelLabel = t('label.cancel'),
loading = false, loading = false,
@ -116,10 +114,7 @@ export const useFormDrawer = <T = any,>(config: FormDrawerConfig<T>) => {
label: cancelLabel, label: cancelLabel,
variant: 'text', variant: 'text',
testId: cancelTestId, testId: cancelTestId,
onClick: () => { onClick: () => closeRef.current(),
closeRef.current();
onReset?.(); // Reset form on cancel
},
}, },
primaryButton: { primaryButton: {
label: submitLabel, label: submitLabel,
@ -136,7 +131,6 @@ export const useFormDrawer = <T = any,>(config: FormDrawerConfig<T>) => {
// Form submission error handled by caller // Form submission error handled by caller
} finally { } finally {
setIsSubmitting(false); setIsSubmitting(false);
onReset?.(); // Reset form on submit
} }
}, },
}, },
@ -179,11 +173,7 @@ export const useFormDrawer = <T = any,>(config: FormDrawerConfig<T>) => {
*/ */
export const useFormDrawerWithRef = <T = any,>( export const useFormDrawerWithRef = <T = any,>(
config: FormDrawerConfig<T> & { config: FormDrawerConfig<T> & {
formRef?: { formRef?: { submit: () => void; validateFields?: () => Promise<any> };
submit: () => void;
validateFields?: () => Promise<any>;
resetFields: () => void;
};
} }
) => { ) => {
const { formRef, onSubmit, ...restConfig } = config; const { formRef, onSubmit, ...restConfig } = config;
@ -208,7 +198,6 @@ export const useFormDrawerWithRef = <T = any,>(
const drawer = useFormDrawer({ const drawer = useFormDrawer({
...restConfig, ...restConfig,
onSubmit: handleSubmit, onSubmit: handleSubmit,
onReset: formRef?.resetFields,
}); });
const submitForm = useCallback(() => { const submitForm = useCallback(() => {