yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-26 01:15:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): cypress skipped tests (#13360)

Browse Source 
* fix(test): cypress skipped tests

* limit cypress tests to changed one

* fix service search

* enable cypress tests

* enable tier and owner spec

---------

Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
This commit is contained in:
Chirag Madlani 2023-10-02 12:06:10 +05:30 committed by GitHub
parent 11f1df437b
commit 241c838c64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 53 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
openmetadata-ui/src/main/resources/ui/cypress/constants/Version.constants.js
View File

@ -1023,13 +1023,13 @@ export const SERVICE_DETAILS_FOR_VERSION_TEST = {
entityPatchPayload: COMMON_PATCH_PAYLOAD, entityPatchPayload: COMMON_PATCH_PAYLOAD,
settingsMenuId: 'services.dashboards', settingsMenuId: 'services.dashboards',
}, },
// Pipeline: { Pipeline: {
// serviceName: PIPELINE_SERVICE_NAME, serviceName: PIPELINE_SERVICE_NAME,
// serviceCategory: SERVICE_CATEGORIES.PIPELINE_SERVICES, serviceCategory: SERVICE_CATEGORIES.PIPELINE_SERVICES,
// entityCreationDetails: PIPELINE_SERVICE_DETAILS_FOR_VERSION_TEST, entityCreationDetails: PIPELINE_SERVICE_DETAILS_FOR_VERSION_TEST,
// entityPatchPayload: COMMON_PATCH_PAYLOAD, entityPatchPayload: COMMON_PATCH_PAYLOAD,
// settingsMenuId: 'services.pipelines', settingsMenuId: 'services.pipelines',
// }, },
'ML Model': { 'ML Model': {
serviceName: ML_MODEL_SERVICE_NAME, serviceName: ML_MODEL_SERVICE_NAME,
serviceCategory: SERVICE_CATEGORIES.ML_MODEL_SERVICES, serviceCategory: SERVICE_CATEGORIES.ML_MODEL_SERVICES,
@ -1037,20 +1037,20 @@ export const SERVICE_DETAILS_FOR_VERSION_TEST = {
entityPatchPayload: COMMON_PATCH_PAYLOAD, entityPatchPayload: COMMON_PATCH_PAYLOAD,
settingsMenuId: 'services.mlModels', settingsMenuId: 'services.mlModels',
}, },
// Storage: { Storage: {
// serviceName: STORAGE_SERVICE_NAME, serviceName: STORAGE_SERVICE_NAME,
// serviceCategory: SERVICE_CATEGORIES.STORAGE_SERVICES, serviceCategory: SERVICE_CATEGORIES.STORAGE_SERVICES,
// entityCreationDetails: STORAGE_SERVICE_DETAILS_FOR_VERSION_TEST, entityCreationDetails: STORAGE_SERVICE_DETAILS_FOR_VERSION_TEST,
// entityPatchPayload: COMMON_PATCH_PAYLOAD, entityPatchPayload: COMMON_PATCH_PAYLOAD,
// settingsMenuId: 'services.storages', settingsMenuId: 'services.storages',
// }, },
// Search: { Search: {
// serviceName: SEARCH_SERVICE_NAME, serviceName: SEARCH_SERVICE_NAME,
// serviceCategory: SERVICE_CATEGORIES.SEARCH_SERVICES, serviceCategory: SERVICE_CATEGORIES.SEARCH_SERVICES,
// entityCreationDetails: SEARCH_SERVICE_DETAILS_FOR_VERSION_TEST, entityCreationDetails: SEARCH_SERVICE_DETAILS_FOR_VERSION_TEST,
// entityPatchPayload: COMMON_PATCH_PAYLOAD, entityPatchPayload: COMMON_PATCH_PAYLOAD,
// settingsMenuId: 'services.search', settingsMenuId: 'services.search',
// }, },
}; };
export const DATABASE_DETAILS_FOR_VERSION_TEST = { export const DATABASE_DETAILS_FOR_VERSION_TEST = {

3
openmetadata-ui/src/main/resources/ui/cypress/e2e/AddNewService/Airflow.spec.js
View File

@ -54,8 +54,7 @@ describe('Airflow Ingestion', () => {
}); });
}); });
// Todo: unskip below test once issue is fixed https://github.com/open-metadata/OpenMetadata/issues/11676 it('Update pipeline description and verify description after re-run', () => {
it.skip('Update pipeline description and verify description after re-run', () => {
updateDescriptionForIngestedTables( updateDescriptionForIngestedTables(
serviceName, serviceName,
tableName, tableName,

2
openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/QueryEntity.spec.js
View File

@ -30,7 +30,7 @@ const DATA = {
}, },
}; };
describe.skip('Query Entity', () => { describe('Query Entity', () => {
beforeEach(() => { beforeEach(() => {
cy.login(); cy.login();
cy.get("[data-testid='welcome-screen-close-btn']").click(); cy.get("[data-testid='welcome-screen-close-btn']").click();

3
openmetadata-ui/src/main/resources/ui/cypress/e2e/Features/RecentlyViewed.spec.js
View File

@ -53,8 +53,7 @@ describe('Recently viwed data assets', () => {
).should('have.length', 0); ).should('have.length', 0);
}); });
// Todo: locally its working as expected but in cypress its not showing recently view table it(`recently view section should have at max list of 5 entity`, () => {
it.skip(`recently view section should have at max list of 5 entity`, () => {
RECENTLY_VIEW_ENTITIES.map((entity, index) => { RECENTLY_VIEW_ENTITIES.map((entity, index) => {
visitEntityDetailsPage(entity.term, entity.serviceName, entity.entity); visitEntityDetailsPage(entity.term, entity.serviceName, entity.entity);

22
openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/AddAndRemoveTierAndOwner.spec.js
View File

@ -24,20 +24,22 @@ import {
} from '../../common/common'; } from '../../common/common';
import { import {
DELETE_TERM, DELETE_TERM,
SEARCH_ENTITY_DASHBOARD,
SEARCH_ENTITY_MLMODEL, SEARCH_ENTITY_MLMODEL,
SEARCH_ENTITY_PIPELINE, SEARCH_ENTITY_PIPELINE,
SEARCH_ENTITY_STORED_PROCEDURE, SEARCH_ENTITY_STORED_PROCEDURE,
SEARCH_ENTITY_TABLE,
SEARCH_ENTITY_TOPIC, SEARCH_ENTITY_TOPIC,
} from '../../constants/constants'; } from '../../constants/constants';
const ENTITIES = { const ENTITIES = {
// table: { table: {
// ...SEARCH_ENTITY_TABLE.table_5, ...SEARCH_ENTITY_TABLE.table_5,
// schema: 'shopify', schema: 'shopify',
// database: 'ecommerce_db', database: 'ecommerce_db',
// }, },
topic: SEARCH_ENTITY_TOPIC.topic_2, topic: SEARCH_ENTITY_TOPIC.topic_2,
// dashboard: SEARCH_ENTITY_DASHBOARD.dashboard_2, dashboard: SEARCH_ENTITY_DASHBOARD.dashboard_2,
pipeline: SEARCH_ENTITY_PIPELINE.pipeline_2, pipeline: SEARCH_ENTITY_PIPELINE.pipeline_2,
mlmodel: SEARCH_ENTITY_MLMODEL.mlmodel_2, mlmodel: SEARCH_ENTITY_MLMODEL.mlmodel_2,
storedProcedure: SEARCH_ENTITY_STORED_PROCEDURE.stored_procedure_2, storedProcedure: SEARCH_ENTITY_STORED_PROCEDURE.stored_procedure_2,
@ -88,7 +90,7 @@ describe('Add and Remove Owner', () => {
}); });
}); });
it.skip('databaseSchema details page', () => { it('databaseSchema details page', () => {
interceptURL('PATCH', '/api/v1/databaseSchemas/*', 'patchOwner'); interceptURL('PATCH', '/api/v1/databaseSchemas/*', 'patchOwner');
interceptURL('GET', '/api/v1/*/name/*', 'schemaDetails'); interceptURL('GET', '/api/v1/*/name/*', 'schemaDetails');
const value = ENTITIES.table; const value = ENTITIES.table;
@ -106,7 +108,7 @@ describe('Add and Remove Owner', () => {
addRemoveOwner(OWNER, 'databaseSchemas'); addRemoveOwner(OWNER, 'databaseSchemas');
}); });
it.skip('database details page', () => { it('database details page', () => {
interceptURL('PATCH', '/api/v1/databases/*', 'patchOwner'); interceptURL('PATCH', '/api/v1/databases/*', 'patchOwner');
interceptURL('GET', '/api/v1/databases/name/*', 'databaseDetails'); interceptURL('GET', '/api/v1/databases/name/*', 'databaseDetails');
const value = ENTITIES.table; const value = ENTITIES.table;
@ -124,7 +126,7 @@ describe('Add and Remove Owner', () => {
addRemoveOwner(OWNER, 'databases'); addRemoveOwner(OWNER, 'databases');
}); });
it.skip('service details page', () => { it('service details page', () => {
interceptURL('PATCH', '/api/v1/services/databaseServices/*', 'patchOwner'); interceptURL('PATCH', '/api/v1/services/databaseServices/*', 'patchOwner');
interceptURL( interceptURL(
'GET', 'GET',
@ -341,7 +343,7 @@ describe('Add and Remove Tier', () => {
}); });
}); });
it.skip('database details page', () => { it('database details page', () => {
interceptURL('GET', '/api/v1/databases/name/*', 'databaseDetails'); interceptURL('GET', '/api/v1/databases/name/*', 'databaseDetails');
const value = ENTITIES.table; const value = ENTITIES.table;
visitEntityDetailsPage(value.term, value.serviceName, value.entity); visitEntityDetailsPage(value.term, value.serviceName, value.entity);

2
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Alerts.spec.js
View File

@ -56,7 +56,7 @@ const visitAddAlertPage = () => {
}); });
}; };
describe.skip('Alerts page should work properly', () => { describe('Alerts page should work properly', () => {
beforeEach(() => { beforeEach(() => {
interceptURL('POST', '/api/v1/events/subscriptions', 'createAlert'); interceptURL('POST', '/api/v1/events/subscriptions', 'createAlert');
interceptURL('GET', `/api/v1/search/query?q=*`, 'getSearchResult'); interceptURL('GET', `/api/v1/search/query?q=*`, 'getSearchResult');

6
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Glossary.spec.js
View File

@ -721,7 +721,7 @@ describe('Glossary page should work properly', () => {
voteGlossary(true); voteGlossary(true);
}); });
it.skip('Update glossary term', () => { it('Update glossary term', () => {
const uSynonyms = ['pick up', 'take', 'obtain']; const uSynonyms = ['pick up', 'take', 'obtain'];
const newRef = { name: 'take', url: 'https://take.com' }; const newRef = { name: 'take', url: 'https://take.com' };
const term2 = NEW_GLOSSARY_TERMS.term_2.name; const term2 = NEW_GLOSSARY_TERMS.term_2.name;
@ -758,7 +758,7 @@ describe('Glossary page should work properly', () => {
voteGlossary(); voteGlossary();
}); });
it.skip('Assets Tab should work properly', () => { it('Assets Tab should work properly', () => {
selectActiveGlossary(NEW_GLOSSARY.name); selectActiveGlossary(NEW_GLOSSARY.name);
const glossary = NEW_GLOSSARY.name; const glossary = NEW_GLOSSARY.name;
const term1 = NEW_GLOSSARY_TERMS.term_1.name; const term1 = NEW_GLOSSARY_TERMS.term_1.name;
@ -889,7 +889,7 @@ describe('Glossary page should work properly', () => {
.should('be.visible'); .should('be.visible');
}); });
it.skip('Remove Glossary term from entity should work properly', () => { it('Remove Glossary term from entity should work properly', () => {
const glossaryName = NEW_GLOSSARY_1.name; const glossaryName = NEW_GLOSSARY_1.name;
const { name, fullyQualifiedName } = NEW_GLOSSARY_1_TERMS.term_1; const { name, fullyQualifiedName } = NEW_GLOSSARY_1_TERMS.term_1;
const entity = SEARCH_ENTITY_TABLE.table_3; const entity = SEARCH_ENTITY_TABLE.table_3;

4
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Users.spec.js
View File

@ -54,11 +54,11 @@ describe('Users flow should work properly', () => {
softDeleteUser(userName); softDeleteUser(userName);
}); });
it.skip('Restore soft deleted user', () => { it('Restore soft deleted user', () => {
restoreUser(userName); restoreUser(userName);
}); });
it.skip('Permanently Delete Soft Deleted User', () => { it('Permanently Delete Soft Deleted User', () => {
softDeleteUser(userName); softDeleteUser(userName);
deleteSoftDeletedUser(userName); deleteSoftDeletedUser(userName);
}); });

4
openmetadata-ui/src/main/resources/ui/src/components/Services/Services.tsx
View File

@ -100,6 +100,10 @@ const Services = ({ serviceName }: ServicesProps) => {
return SearchIndex.PIPELINE_SERVICE; return SearchIndex.PIPELINE_SERVICE;
case ServiceCategory.ML_MODEL_SERVICES: case ServiceCategory.ML_MODEL_SERVICES:
return SearchIndex.ML_MODEL_SERVICE; return SearchIndex.ML_MODEL_SERVICE;
case ServiceCategory.STORAGE_SERVICES:
return SearchIndex.STORAGE_SERVICE;
case ServiceCategory.SEARCH_SERVICES:
return SearchIndex.SEARCH_SERVICE;
} }
return SearchIndex.DATABASE_SERVICE; return SearchIndex.DATABASE_SERVICE;

1
openmetadata-ui/src/main/resources/ui/src/enums/search.enum.ts
View File

@ -32,6 +32,7 @@ export enum SearchIndex {
SEARCH_SERVICE = 'search_service_search_index', SEARCH_SERVICE = 'search_service_search_index',
DASHBOARD_SERCVICE = 'dashboard_service_search_index', DASHBOARD_SERCVICE = 'dashboard_service_search_index',
ML_MODEL_SERVICE = 'mlmodel_service_search_index', ML_MODEL_SERVICE = 'mlmodel_service_search_index',
STORAGE_SERVICE = 'storage_service_search_index',
DOMAIN = 'domain_search_index', DOMAIN = 'domain_search_index',
SEARCH_INDEX = 'search_entity_index', SEARCH_INDEX = 'search_entity_index',
STORED_PROCEDURE = 'stored_procedure_search_index', STORED_PROCEDURE = 'stored_procedure_search_index',

6
openmetadata-ui/src/main/resources/ui/src/interface/search.interface.ts
View File

@ -138,6 +138,10 @@ export interface SearchServiceSearchSource
extends SearchSourceBase, extends SearchSourceBase,
SearchService {} SearchService {}
export interface StorageServiceSearchSource
extends SearchSourceBase,
SearchService {}
export type ExploreSearchSource = export type ExploreSearchSource =
| TableSearchSource | TableSearchSource
| DashboardSearchSource | DashboardSearchSource
@ -161,6 +165,7 @@ export type ExploreSearchSource =
| MlModelServiceSearchSource | MlModelServiceSearchSource
| MessagingServiceSearchSource | MessagingServiceSearchSource
| SearchServiceSearchSource | SearchServiceSearchSource
| StorageServiceSearchSource
| DomainSearchSource | DomainSearchSource
| SearchIndexSearchSource; | SearchIndexSearchSource;
@ -185,6 +190,7 @@ export type SearchIndexSearchSourceMapping = {
[SearchIndex.ML_MODEL_SERVICE]: MlModelServiceSearchSource; [SearchIndex.ML_MODEL_SERVICE]: MlModelServiceSearchSource;
[SearchIndex.MESSAGING_SERVICE]: MessagingServiceSearchSource; [SearchIndex.MESSAGING_SERVICE]: MessagingServiceSearchSource;
[SearchIndex.SEARCH_SERVICE]: SearchServiceSearchSource; [SearchIndex.SEARCH_SERVICE]: SearchServiceSearchSource;
[SearchIndex.STORAGE_SERVICE]: StorageServiceSearchSource;
[SearchIndex.DOMAIN]: DomainSearchSource; [SearchIndex.DOMAIN]: DomainSearchSource;
[SearchIndex.SEARCH_INDEX]: SearchIndexSearchSource; [SearchIndex.SEARCH_INDEX]: SearchIndexSearchSource;
[SearchIndex.STORED_PROCEDURE]: StoredProcedureSearchSource; [SearchIndex.STORED_PROCEDURE]: StoredProcedureSearchSource;