From 24b0eb56d6cfd8545336a4de10039b9cd6474010 Mon Sep 17 00:00:00 2001 From: Aniket Katkar Date: Mon, 3 Nov 2025 12:08:51 +0530 Subject: [PATCH] Fix(UI): Add missing icons and fix errors (#24107) * Add missing icons for persona data assets settings * Fix ui errors * Update the default values for oidc configs * Revert "Update the default values for oidc configs" This reverts commit 73cab6d00b15ecfc96a43b228d3b5e5b0379c79a. * Add missing icon for classification in persona details page * Fix sonar issue --- .../assets/svg/classification-colored-new.svg | 9 +++++ .../AppRouter/AuthenticatedAppRouter.tsx | 4 +-- .../ui/src/locale/languages/de-de.json | 1 + .../ui/src/locale/languages/en-us.json | 1 + .../ui/src/locale/languages/es-es.json | 1 + .../ui/src/locale/languages/fr-fr.json | 1 + .../ui/src/locale/languages/gl-es.json | 1 + .../ui/src/locale/languages/he-he.json | 1 + .../ui/src/locale/languages/ja-jp.json | 1 + .../ui/src/locale/languages/ko-kr.json | 1 + .../ui/src/locale/languages/mr-in.json | 1 + .../ui/src/locale/languages/nl-nl.json | 1 + .../ui/src/locale/languages/pr-pr.json | 1 + .../ui/src/locale/languages/pt-br.json | 1 + .../ui/src/locale/languages/pt-pt.json | 1 + .../ui/src/locale/languages/ru-ru.json | 1 + .../ui/src/locale/languages/th-th.json | 1 + .../ui/src/locale/languages/tr-tr.json | 1 + .../ui/src/locale/languages/zh-cn.json | 1 + .../ui/src/locale/languages/zh-tw.json | 1 + .../ui/src/utils/Persona/PersonaUtils.ts | 34 +++++++++++++++---- 21 files changed, 56 insertions(+), 9 deletions(-) create mode 100644 openmetadata-ui/src/main/resources/ui/src/assets/svg/classification-colored-new.svg diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/classification-colored-new.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/classification-colored-new.svg new file mode 100644 index 00000000000..fff14fe8a7d --- /dev/null +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/classification-colored-new.svg @@ -0,0 +1,9 @@ + + + + + + + + + diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx index c8f877c5f52..303e3f08784 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx @@ -711,8 +711,8 @@ const AuthenticatedAppRouter: FunctionComponent = () => { /> {/* Plugin routes */} - {pluginRoutes.map((route, idx) => { - return ; + {pluginRoutes?.map((route) => { + return ; })} } path={ROUTES.HOME} /> diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json index be5e04b9e9c..0e76782003f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Datenquartile", "data-range": "Datenbereich", "data-type": "Datentyp", + "data-type-display": "Datentyp-Anzeige", "data-volume": "Datenvolumen", "database": "Datenbank", "database-lowercase": "Datenbank", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json index 8b72bb8a201..3420c97f8cf 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Data Quartiles", "data-range": "Data Range", "data-type": "Data Type", + "data-type-display": "Data Type Display", "data-volume": "Data Volume", "database": "Database", "database-lowercase": "database", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json index c0d942bf4bd..5e5bda214ef 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json @@ -424,6 +424,7 @@ "data-quartile-plural": "cuartiles", "data-range": "Rango de datos", "data-type": "Tipo de datos", + "data-type-display": "Visualización del tipo de datos", "data-volume": "Volumen de datos", "database": "Base de datos", "database-lowercase": "base de datos", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json index 3a293299e15..1157e2ff401 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Quartiles des Données", "data-range": "Plage de Données", "data-type": "Type de Données", + "data-type-display": "Affichage du type de données", "data-volume": "Volume de Données", "database": "Base de Données", "database-lowercase": "base de données", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json index 899361337f5..c2fa8e13153 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Cuartís de datos", "data-range": "Rango de datos", "data-type": "Tipo de datos", + "data-type-display": "Visualización do tipo de datos", "data-volume": "Volume de datos", "database": "Base de datos", "database-lowercase": "base de datos", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json index 0c37e883d14..29fff62f272 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json @@ -424,6 +424,7 @@ "data-quartile-plural": "רביעונים (Quaertiles)", "data-range": "טווח נתונים", "data-type": "סוג עמודה", + "data-type-display": "תצוגת סוג הנתונים", "data-volume": "נפח נתונים", "database": "בסיס נתונים", "database-lowercase": "בסיס נתונים", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json index d82085aead4..bd4fa003518 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json @@ -424,6 +424,7 @@ "data-quartile-plural": "データ四分位数", "data-range": "データ範囲", "data-type": "データ型", + "data-type-display": "データ型の表示", "data-volume": "データ量", "database": "データベース", "database-lowercase": "データベース", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json index ee94df74a1c..8ede4963e86 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json @@ -424,6 +424,7 @@ "data-quartile-plural": "데이터 사분위수", "data-range": "데이터 범위", "data-type": "데이터 유형", + "data-type-display": "데이터 유형 표시", "data-volume": "데이터 볼륨", "database": "데이터베이스", "database-lowercase": "데이터베이스", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json index 8db66fe06d3..4f279df7262 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json @@ -424,6 +424,7 @@ "data-quartile-plural": "डेटा चतुर्थांश", "data-range": "डेटा श्रेणी", "data-type": "डेटा प्रकार", + "data-type-display": "डेटा प्रकार प्रदर्शन", "data-volume": "डेटा खंड", "database": "डेटाबेस", "database-lowercase": "डेटाबेस", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json index 85995094b2e..c9c68e4f1ec 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Datakwartielen", "data-range": "Datasbereik", "data-type": "Datatype", + "data-type-display": "Datatypeweergave", "data-volume": "Datavolume", "database": "Database", "database-lowercase": "database", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json index 51c10971be1..cca7f8a6cb1 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json @@ -424,6 +424,7 @@ "data-quartile-plural": "چهارک‌های داده", "data-range": "محدوده داده", "data-type": "نوع داده", + "data-type-display": "نمایش نوع داده", "data-volume": "حجم داده", "database": "پایگاه داده", "database-lowercase": "پایگاه داده", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json index 09b5a751ce6..d323d29837b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Quartis de Dados", "data-range": "Intervalo de Dados", "data-type": "Tipo de Dados", + "data-type-display": "Exibição do Tipo de Dados", "data-volume": "Volume de Dados", "database": "Base de Dados", "database-lowercase": "base de dados", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json index cba73b8081e..38316a8189d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Quartis de Dados", "data-range": "Intervalo de Dados", "data-type": "Tipo de Dados", + "data-type-display": "Visualização do Tipo de Dados", "data-volume": "Volume de Dados", "database": "Base de Dados", "database-lowercase": "base de dados", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json index 4f4e31c6b45..e63c594a36a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Качество данных", "data-range": "Временной интервал", "data-type": "Тип данных", + "data-type-display": "Отображение типа данных", "data-volume": "Объем данных", "database": "База данных", "database-lowercase": "база данных", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json index 62991d3267c..a93c83ec1cb 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json @@ -424,6 +424,7 @@ "data-quartile-plural": "ควอไทล์ข้อมูล", "data-range": "ช่วงข้อมูล", "data-type": "ประเภทข้อมูล", + "data-type-display": "การแสดงประเภทข้อมูล", "data-volume": "ปริมาณข้อมูล", "database": "ฐานข้อมูล", "database-lowercase": "ฐานข้อมูล", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json index 45400fa553f..86f143f30a3 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json @@ -424,6 +424,7 @@ "data-quartile-plural": "Veri Dörttebirleri", "data-range": "Veri Aralığı", "data-type": "Veri Türü", + "data-type-display": "Veri Türü Görünümü", "data-volume": "Veri Hacmi", "database": "Veritabanı", "database-lowercase": "veritabanı", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json index 63a886e4f04..056be8ab670 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json @@ -424,6 +424,7 @@ "data-quartile-plural": "数据四分位数", "data-range": "数据范围", "data-type": "数据类型", + "data-type-display": "数据类型显示", "data-volume": "数据量", "database": "数据库", "database-lowercase": "数据库", diff --git a/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json b/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json index cee18cad138..32864f0eca7 100644 --- a/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json +++ b/openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json @@ -424,6 +424,7 @@ "data-quartile-plural": "資料四分位數", "data-range": "資料範圍", "data-type": "資料類型", + "data-type-display": "資料類型顯示", "data-volume": "資料量", "database": "資料庫", "database-lowercase": "資料庫", diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts b/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts index 37027319796..c1c298c65b8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts +++ b/openmetadata-ui/src/main/resources/ui/src/utils/Persona/PersonaUtils.ts @@ -10,16 +10,20 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { camelCase, map, startCase } from 'lodash'; +import { map, startCase } from 'lodash'; import { ReactComponent as APICollectionIcon } from '../../assets/svg/api-collection-colored.svg'; import { ReactComponent as APIEndpointIcon } from '../../assets/svg/api-endpoints-colored.svg'; import { ReactComponent as ChartIcon } from '../../assets/svg/chart-colored.svg'; +import { ReactComponent as ClassificationIcon } from '../../assets/svg/classification-colored-new.svg'; import { ReactComponent as DashboardIcon } from '../../assets/svg/dashboard-colored-new.svg'; import { ReactComponent as DashboardDataModelIcon } from '../../assets/svg/dashboard-data-models-colored.svg'; import { ReactComponent as DataAssetsIcon } from '../../assets/svg/data-assets-colored-new.svg'; +import { ReactComponent as DataProductIcon } from '../../assets/svg/data-product-colored.svg'; import { ReactComponent as DatabaseIcon } from '../../assets/svg/database-colored-new.svg'; import { ReactComponent as SchemaIcon } from '../../assets/svg/database-schema-colored.svg'; +import { ReactComponent as DirectoryIcon } from '../../assets/svg/directory-colored-new.svg'; import { ReactComponent as DomainIcon } from '../../assets/svg/domain-colored.svg'; +import { ReactComponent as FileIcon } from '../../assets/svg/file-colored-new.svg'; import { ReactComponent as GlossaryIcon } from '../../assets/svg/glossary-term-colored-new.svg'; import { ReactComponent as GovernIcon } from '../../assets/svg/governance.svg'; import { ReactComponent as HomepageIcon } from '../../assets/svg/homepage.svg'; @@ -29,14 +33,23 @@ import { ReactComponent as MlModelIcon } from '../../assets/svg/ml-models-colore import { ReactComponent as NavigationIcon } from '../../assets/svg/navigation.svg'; import { ReactComponent as PipelineIcon } from '../../assets/svg/pipelines-colored-new.svg'; import { ReactComponent as SearchIndexIcon } from '../../assets/svg/search-index-colored-new.svg'; +import { ReactComponent as SpreadsheetIcon } from '../../assets/svg/spreadsheet-colored-new.svg'; import { ReactComponent as StorageIcon } from '../../assets/svg/storage-colored-new.svg'; import { ReactComponent as StoredProcedureIcon } from '../../assets/svg/stored-procedures-colored-new.svg'; import { ReactComponent as TableIcon } from '../../assets/svg/table-colored-new.svg'; +import { ReactComponent as TagIcon } from '../../assets/svg/tags-colored.svg'; +import { ReactComponent as WorksheetIcon } from '../../assets/svg/worksheet-colored-new.svg'; import { PageType } from '../../generated/system/ui/uiCustomization'; import { SettingMenuItem } from '../GlobalSettingsUtils'; import i18n from '../i18next/LocalUtil'; -const ENTITY_ICONS: Record = { +export type CustomizeIconKeys = + | PageType + | 'govern' + | 'dataAssets' + | 'navigation'; + +const ENTITY_ICONS: Record = { [PageType.Table]: TableIcon, [PageType.Chart]: ChartIcon, [PageType.Container]: StorageIcon, @@ -53,12 +66,19 @@ const ENTITY_ICONS: Record = { [PageType.Topic]: MessagingIcon, ['govern']: GovernIcon, ['dataAssets']: DataAssetsIcon, - ['homepage']: HomepageIcon, + [PageType.LandingPage]: HomepageIcon, ['navigation']: NavigationIcon, [PageType.APICollection]: APICollectionIcon, [PageType.APIEndpoint]: APIEndpointIcon, [PageType.MlModel]: MlModelIcon, [PageType.Metric]: MetricIcon, + [PageType.Directory]: DirectoryIcon, + [PageType.File]: FileIcon, + [PageType.Spreadsheet]: SpreadsheetIcon, + [PageType.Worksheet]: WorksheetIcon, + [PageType.Classification]: ClassificationIcon, + [PageType.Tag]: TagIcon, + [PageType.DataProduct]: DataProductIcon, }; export const getCustomizePageCategories = (): SettingMenuItem[] => { @@ -68,20 +88,20 @@ export const getCustomizePageCategories = (): SettingMenuItem[] => { label: i18n.t('label.navigation'), isBeta: true, description: 'Customize left sidebar ', - icon: ENTITY_ICONS[camelCase('Navigation')], + icon: ENTITY_ICONS['navigation'], }, { key: PageType.LandingPage, label: i18n.t('label.home-page'), description: 'Customize the My data page with widget of your preference', - icon: ENTITY_ICONS[camelCase('Homepage')], + icon: ENTITY_ICONS[PageType.LandingPage], }, { key: 'governance', label: i18n.t('label.governance'), isBeta: true, description: 'Customize the Govern pages with widget of your preference', - icon: ENTITY_ICONS[camelCase('GOVERN')], + icon: ENTITY_ICONS['govern'], }, { key: 'data-assets', @@ -89,7 +109,7 @@ export const getCustomizePageCategories = (): SettingMenuItem[] => { isBeta: true, description: 'Customize the entity detail page with widget of your preference', - icon: ENTITY_ICONS[camelCase('data-assets')], + icon: ENTITY_ICONS['dataAssets'], }, ]; };