yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-22 16:08:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ISSUE-3790: Remove unnecessary public modifiers (#8268)

Browse Source
This commit is contained in:
Shivam Shrey 2022-10-20 21:28:52 +05:30 committed by GitHub
parent 342e4a24da
commit 24f3ae763e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
30 changed files with 35 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/src/test/java/org/openmetadata/annotations/utils/AnnotationCheckerTest.java
View File

@ -6,7 +6,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import org.openmetadata.annotations.ExposedField;
public class AnnotationCheckerTest {
class AnnotationCheckerTest {
@Test
void testWhenClassHasExposedFields() {

2
openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/IngestionPipelineRepositoryUnitTest.java
View File

@ -39,7 +39,7 @@ import org.openmetadata.service.secrets.SecretsManager;
import org.openmetadata.service.secrets.SecretsManagerFactory;
@ExtendWith(MockitoExtension.class)
public class IngestionPipelineRepositoryUnitTest {
class IngestionPipelineRepositoryUnitTest {
@Mock protected CollectionDAO collectionDAO;

6
openmetadata-service/src/test/java/org/openmetadata/service/pipelineService/PipelineServiceClientTest.java
View File

@ -6,19 +6,19 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
import org.junit.jupiter.api.Test;
import org.openmetadata.service.exception.PipelineServiceVersionException;
public class PipelineServiceClientTest {
class PipelineServiceClientTest {
final MockPipelineServiceClient mockPipelineServiceClient =
new MockPipelineServiceClient("user", "password", "https://endpoint.com", "111.11.11.1", 10);
@Test
public void testGetVersionFromString() {
void testGetVersionFromString() {
String version = mockPipelineServiceClient.getVersionFromString("0.12.0.dev0");
assertEquals("0.12.0", version);
}
@Test
public void testGetVersionFromStringRaises() {
void testGetVersionFromStringRaises() {
Exception exception =
assertThrows(
PipelineServiceVersionException.class, () -> mockPipelineServiceClient.getVersionFromString("random"));

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/bots/BotResourceTest.java
View File

@ -25,7 +25,7 @@ import org.openmetadata.service.resources.bots.BotResource.BotList;
import org.openmetadata.service.resources.teams.UserResourceTest;
import org.openmetadata.service.util.ResultList;
public class BotResourceTest extends EntityResourceTest<Bot, CreateBot> {
class BotResourceTest extends EntityResourceTest<Bot, CreateBot> {
public static User botUser;
public static EntityReference botUserRef;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/charts/ChartResourceTest.java
View File

@ -40,7 +40,7 @@ import org.openmetadata.service.resources.charts.ChartResource.ChartList;
import org.openmetadata.service.util.ResultList;
@Slf4j
public class ChartResourceTest extends EntityResourceTest<Chart, CreateChart> {
class ChartResourceTest extends EntityResourceTest<Chart, CreateChart> {
public ChartResourceTest() {
super(Entity.CHART, Chart.class, ChartList.class, "charts", ChartResource.FIELDS);

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/dashboards/DashboardResourceTest.java
View File

@ -54,7 +54,7 @@ import org.openmetadata.service.util.ResultList;
import org.openmetadata.service.util.TestUtils;
@Slf4j
public class DashboardResourceTest extends EntityResourceTest<Dashboard, CreateDashboard> {
class DashboardResourceTest extends EntityResourceTest<Dashboard, CreateDashboard> {
public static EntityReference SUPERSET_INVALID_SERVICE_REFERENCE;
public DashboardResourceTest() {

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/DatabaseResourceTest.java
View File

@ -47,7 +47,7 @@ import org.openmetadata.service.util.TestUtils;
@Slf4j
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public class DatabaseResourceTest extends EntityResourceTest<Database, CreateDatabase> {
class DatabaseResourceTest extends EntityResourceTest<Database, CreateDatabase> {
public DatabaseResourceTest() {
super(Entity.DATABASE, Database.class, DatabaseList.class, "databases", DatabaseResource.FIELDS);
}

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestDefinitionResourceTest.java
View File

@ -17,7 +17,7 @@ import org.openmetadata.schema.type.TestDefinitionEntityType;
import org.openmetadata.service.Entity;
import org.openmetadata.service.resources.EntityResourceTest;
public class TestDefinitionResourceTest extends EntityResourceTest<TestDefinition, CreateTestDefinition> {
class TestDefinitionResourceTest extends EntityResourceTest<TestDefinition, CreateTestDefinition> {
public TestDefinitionResourceTest() {
super(
Entity.TEST_DEFINITION,

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/events/WebhookResourceTest.java
View File

@ -54,7 +54,7 @@ import org.openmetadata.service.util.JsonUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
public class WebhookResourceTest extends EntityResourceTest<Webhook, CreateWebhook> {
class WebhookResourceTest extends EntityResourceTest<Webhook, CreateWebhook> {
public static final List<EventFilter> ALL_EVENTS_FILTER = new ArrayList<>();
static {

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryResourceTest.java
View File

@ -45,7 +45,7 @@ import org.openmetadata.service.util.TestUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class GlossaryResourceTest extends EntityResourceTest<Glossary, CreateGlossary> {
class GlossaryResourceTest extends EntityResourceTest<Glossary, CreateGlossary> {
public GlossaryResourceTest() {
super(Entity.GLOSSARY, Glossary.class, GlossaryResource.GlossaryList.class, "glossaries", GlossaryResource.FIELDS);
}

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryTermResourceTest.java
View File

@ -74,7 +74,7 @@ import org.openmetadata.service.util.ResultList;
import org.openmetadata.service.util.TestUtils;
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class GlossaryTermResourceTest extends EntityResourceTest<GlossaryTerm, CreateGlossaryTerm> {
class GlossaryTermResourceTest extends EntityResourceTest<GlossaryTerm, CreateGlossaryTerm> {
public GlossaryTermResourceTest() {
super(
Entity.GLOSSARY_TERM,

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/metadata/TypeResourceTest.java
View File

@ -57,7 +57,7 @@ import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class TypeResourceTest extends EntityResourceTest<Type, CreateType> {
class TypeResourceTest extends EntityResourceTest<Type, CreateType> {
public TypeResourceTest() {
super(Entity.TYPE, Type.class, TypeList.class, "metadata/types", TypeResource.PROPERTIES);

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/mlmodels/MlModelResourceTest.java
View File

@ -65,7 +65,7 @@ import org.openmetadata.service.util.TestUtils;
@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class MlModelResourceTest extends EntityResourceTest<MlModel, CreateMlModel> {
class MlModelResourceTest extends EntityResourceTest<MlModel, CreateMlModel> {
public static final String ALGORITHM = "regression";
public static Dashboard DASHBOARD;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/policies/PolicyResourceTest.java
View File

@ -78,7 +78,7 @@ import org.openmetadata.service.util.JsonUtils;
import org.openmetadata.service.util.TestUtils;
@Slf4j
public class PolicyResourceTest extends EntityResourceTest<Policy, CreatePolicy> {
class PolicyResourceTest extends EntityResourceTest<Policy, CreatePolicy> {
private static final String LOCATION_NAME = "aws-s3";
private static Location location;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/DashboardServiceResourceTest.java
View File

@ -53,7 +53,7 @@ import org.openmetadata.service.util.TestUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
public class DashboardServiceResourceTest extends EntityResourceTest<DashboardService, CreateDashboardService> {
class DashboardServiceResourceTest extends EntityResourceTest<DashboardService, CreateDashboardService> {
public DashboardServiceResourceTest() {
super(
Entity.DASHBOARD_SERVICE,

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MessagingServiceResourceTest.java
View File

@ -46,7 +46,7 @@ import org.openmetadata.service.util.TestUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
public class MessagingServiceResourceTest extends EntityResourceTest<MessagingService, CreateMessagingService> {
class MessagingServiceResourceTest extends EntityResourceTest<MessagingService, CreateMessagingService> {
public static final String KAFKA_BROKERS = "192.168.1.1:0";
public static URI SCHEMA_REGISTRY_URL;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java
View File

@ -42,7 +42,7 @@ import org.openmetadata.service.util.TestUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
public class MlModelServiceResourceTest extends EntityResourceTest<MlModelService, CreateMlModelService> {
class MlModelServiceResourceTest extends EntityResourceTest<MlModelService, CreateMlModelService> {
public MlModelServiceResourceTest() {
super(Entity.MLMODEL_SERVICE, MlModelService.class, MlModelServiceList.class, "services/mlmodelServices", "owner");
this.supportsPatch = false;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java
View File

@ -31,7 +31,7 @@ import org.openmetadata.service.resources.services.storage.StorageServiceResourc
import org.openmetadata.service.util.TestUtils;
@Slf4j
public class StorageServiceResourceTest extends EntityResourceTest<StorageService, CreateStorageService> {
class StorageServiceResourceTest extends EntityResourceTest<StorageService, CreateStorageService> {
public StorageServiceResourceTest() {
super(Entity.STORAGE_SERVICE, StorageService.class, StorageServiceList.class, "services/storageServices", "owner");
this.supportsPatch = false;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java
View File

@ -72,7 +72,7 @@ import org.openmetadata.service.util.TestUtils;
@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class IngestionPipelineResourceTest extends EntityResourceTest<IngestionPipeline, CreateIngestionPipeline> {
class IngestionPipelineResourceTest extends EntityResourceTest<IngestionPipeline, CreateIngestionPipeline> {
public static SourceConfig DATABASE_METADATA_CONFIG;
public static SourceConfig DASHBOARD_METADATA_CONFIG;
public static SourceConfig MESSAGING_METADATA_CONFIG;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceUnitTest.java
View File

@ -64,7 +64,7 @@ import org.openmetadata.service.security.Authorizer;
import org.openmetadata.service.util.PipelineServiceClient;
@ExtendWith(MockitoExtension.class)
public class IngestionPipelineResourceUnitTest {
class IngestionPipelineResourceUnitTest {
private static final UUID DAG_ID = UUID.randomUUID();

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/RoleResourceTest.java
View File

@ -51,7 +51,7 @@ import org.openmetadata.service.util.JsonUtils;
import org.openmetadata.service.util.TestUtils;
@Slf4j
public class RoleResourceTest extends EntityResourceTest<Role, CreateRole> {
class RoleResourceTest extends EntityResourceTest<Role, CreateRole> {
public RoleResourceTest() {
super(Entity.ROLE, Role.class, RoleList.class, "roles", null);
this.supportsAuthorizedMetadataOperations = false;

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/TeamResourceTest.java
View File

@ -98,7 +98,7 @@ import org.openmetadata.service.util.TestUtils;
import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
public class TeamResourceTest extends EntityResourceTest<Team, CreateTeam> {
class TeamResourceTest extends EntityResourceTest<Team, CreateTeam> {
final Profile PROFILE = new Profile().withImages(new ImageList().withImage(URI.create("http://image.com")));
public TeamResourceTest() {

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java
View File

@ -113,7 +113,7 @@ import org.openmetadata.service.util.TestUtils.UpdateType;
@Slf4j
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
public class UserResourceTest extends EntityResourceTest<User, CreateUser> {
class UserResourceTest extends EntityResourceTest<User, CreateUser> {
final Profile PROFILE = new Profile().withImages(new ImageList().withImage(URI.create("http://image.com")));
public UserResourceTest() {

6
openmetadata-service/src/test/java/org/openmetadata/service/resources/util/UtilResourceTest.java
View File

@ -68,7 +68,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest {
}
@Test
public void entitiesCount(TestInfo test) throws HttpResponseException {
void entitiesCount(TestInfo test) throws HttpResponseException {
// Get count before adding entities
int beforeTableCount = getEntitiesCount().getTableCount();
@ -143,7 +143,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest {
}
@Test
public void servicesCount(TestInfo test) throws HttpResponseException {
void servicesCount(TestInfo test) throws HttpResponseException {
// Get count before adding services
int beforeMessagingServiceCount = getServicesCount().getMessagingServiceCount();
@ -190,7 +190,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest {
}
@Test
public void botUserCountCheck(TestInfo test) throws HttpResponseException {
void botUserCountCheck(TestInfo test) throws HttpResponseException {
int beforeUserCount = getEntitiesCount().getUserCount();
// Create a bot user.

2
openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSSMSecretsManagerTest.java
View File

@ -40,7 +40,7 @@ import software.amazon.awssdk.services.ssm.model.Parameter;
import software.amazon.awssdk.services.ssm.model.ParameterType;
import software.amazon.awssdk.services.ssm.model.PutParameterRequest;
public class AWSSSMSecretsManagerTest extends ExternalSecretsManagerTest {
class AWSSSMSecretsManagerTest extends ExternalSecretsManagerTest {
@Mock private SsmClient ssmClient;

2
openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSecretsManagerTest.java
View File

@ -37,7 +37,7 @@ import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueReques
import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueResponse;
import software.amazon.awssdk.services.secretsmanager.model.UpdateSecretRequest;
public class AWSSecretsManagerTest extends ExternalSecretsManagerTest {
class AWSSecretsManagerTest extends ExternalSecretsManagerTest {
@Mock private SecretsManagerClient secretsManagerClient;

4
openmetadata-service/src/test/java/org/openmetadata/service/secrets/NoopSecretsManagerTest.java
View File

@ -48,7 +48,7 @@ import org.openmetadata.schema.type.EntityReference;
import org.openmetadata.service.fernet.Fernet;
@ExtendWith(MockitoExtension.class)
public class NoopSecretsManagerTest {
class NoopSecretsManagerTest {
private static final boolean ENCRYPT = true;
private static final boolean DECRYPT = false;
@ -115,7 +115,7 @@ public class NoopSecretsManagerTest {
@ParameterizedTest
@MethodSource(
"org.openmetadata.service.resources.services.ingestionpipelines.IngestionPipelineResourceUnitTestParams#params")
public void testEncryptAndDecryptDbtConfigSource(
void testEncryptAndDecryptDbtConfigSource(
Object config,
EntityReference service,
Class<? extends EntityInterface> serviceClass,

2
openmetadata-service/src/test/java/org/openmetadata/service/secrets/SecretsManagerFactoryTest.java
View File

@ -19,7 +19,7 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.openmetadata.schema.services.connections.metadata.SecretsManagerProvider;
public class SecretsManagerFactoryTest {
class SecretsManagerFactoryTest {
private SecretsManagerConfiguration config;

2
openmetadata-service/src/test/java/org/openmetadata/service/security/policyevaluator/PolicyEvaluatorTest.java
View File

@ -7,7 +7,7 @@ import org.openmetadata.schema.type.Permission.Access;
class PolicyEvaluatorTest {
@Test
public void test_AccessOrderOfPrecedence() {
void test_AccessOrderOfPrecedence() {
//
// Order of precedence for access Deny > Allow > ConditionalDeny > ConditionalAllow > NotAllow
//

2
openmetadata-service/src/test/java/org/openmetadata/service/util/LoginAttemptCacheTest.java
View File

@ -8,7 +8,7 @@ import org.junit.jupiter.api.Test;
import org.openmetadata.service.security.auth.LoginAttemptCache;
@Slf4j
public class LoginAttemptCacheTest {
class LoginAttemptCacheTest {
@Test
void testFailedLogin() throws InterruptedException {
String testKey = "test";