From 24f3ae763eaecc707d56fc62bea59b792eb7ad8b Mon Sep 17 00:00:00 2001 From: Shivam Shrey <31056227+shivamshrey@users.noreply.github.com> Date: Thu, 20 Oct 2022 21:28:52 +0530 Subject: [PATCH] Fix ISSUE-3790: Remove unnecessary public modifiers (#8268) --- .../annotations/utils/AnnotationCheckerTest.java | 2 +- .../service/jdbi3/IngestionPipelineRepositoryUnitTest.java | 2 +- .../service/pipelineService/PipelineServiceClientTest.java | 6 +++--- .../service/resources/bots/BotResourceTest.java | 2 +- .../service/resources/charts/ChartResourceTest.java | 2 +- .../service/resources/dashboards/DashboardResourceTest.java | 2 +- .../service/resources/databases/DatabaseResourceTest.java | 2 +- .../resources/dqtests/TestDefinitionResourceTest.java | 2 +- .../service/resources/events/WebhookResourceTest.java | 2 +- .../service/resources/glossary/GlossaryResourceTest.java | 2 +- .../resources/glossary/GlossaryTermResourceTest.java | 2 +- .../service/resources/metadata/TypeResourceTest.java | 2 +- .../service/resources/mlmodels/MlModelResourceTest.java | 2 +- .../service/resources/policies/PolicyResourceTest.java | 2 +- .../resources/services/DashboardServiceResourceTest.java | 2 +- .../resources/services/MessagingServiceResourceTest.java | 2 +- .../resources/services/MlModelServiceResourceTest.java | 2 +- .../resources/services/StorageServiceResourceTest.java | 2 +- .../ingestionpipelines/IngestionPipelineResourceTest.java | 2 +- .../IngestionPipelineResourceUnitTest.java | 2 +- .../service/resources/teams/RoleResourceTest.java | 2 +- .../service/resources/teams/TeamResourceTest.java | 2 +- .../service/resources/teams/UserResourceTest.java | 2 +- .../service/resources/util/UtilResourceTest.java | 6 +++--- .../service/secrets/AWSSSMSecretsManagerTest.java | 2 +- .../openmetadata/service/secrets/AWSSecretsManagerTest.java | 2 +- .../service/secrets/NoopSecretsManagerTest.java | 4 ++-- .../service/secrets/SecretsManagerFactoryTest.java | 2 +- .../security/policyevaluator/PolicyEvaluatorTest.java | 2 +- .../openmetadata/service/util/LoginAttemptCacheTest.java | 2 +- 30 files changed, 35 insertions(+), 35 deletions(-) diff --git a/common/src/test/java/org/openmetadata/annotations/utils/AnnotationCheckerTest.java b/common/src/test/java/org/openmetadata/annotations/utils/AnnotationCheckerTest.java index 3bb7973aadc..e9b40c451f9 100644 --- a/common/src/test/java/org/openmetadata/annotations/utils/AnnotationCheckerTest.java +++ b/common/src/test/java/org/openmetadata/annotations/utils/AnnotationCheckerTest.java @@ -6,7 +6,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import org.junit.jupiter.api.Test; import org.openmetadata.annotations.ExposedField; -public class AnnotationCheckerTest { +class AnnotationCheckerTest { @Test void testWhenClassHasExposedFields() { diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/IngestionPipelineRepositoryUnitTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/IngestionPipelineRepositoryUnitTest.java index 072d52b4a6a..428abb0661f 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/IngestionPipelineRepositoryUnitTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/IngestionPipelineRepositoryUnitTest.java @@ -39,7 +39,7 @@ import org.openmetadata.service.secrets.SecretsManager; import org.openmetadata.service.secrets.SecretsManagerFactory; @ExtendWith(MockitoExtension.class) -public class IngestionPipelineRepositoryUnitTest { +class IngestionPipelineRepositoryUnitTest { @Mock protected CollectionDAO collectionDAO; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/pipelineService/PipelineServiceClientTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/pipelineService/PipelineServiceClientTest.java index 4c77e7e1286..9312c95ceee 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/pipelineService/PipelineServiceClientTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/pipelineService/PipelineServiceClientTest.java @@ -6,19 +6,19 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import org.junit.jupiter.api.Test; import org.openmetadata.service.exception.PipelineServiceVersionException; -public class PipelineServiceClientTest { +class PipelineServiceClientTest { final MockPipelineServiceClient mockPipelineServiceClient = new MockPipelineServiceClient("user", "password", "https://endpoint.com", "111.11.11.1", 10); @Test - public void testGetVersionFromString() { + void testGetVersionFromString() { String version = mockPipelineServiceClient.getVersionFromString("0.12.0.dev0"); assertEquals("0.12.0", version); } @Test - public void testGetVersionFromStringRaises() { + void testGetVersionFromStringRaises() { Exception exception = assertThrows( PipelineServiceVersionException.class, () -> mockPipelineServiceClient.getVersionFromString("random")); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/bots/BotResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/bots/BotResourceTest.java index 734c7084f23..3efa8bcafef 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/bots/BotResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/bots/BotResourceTest.java @@ -25,7 +25,7 @@ import org.openmetadata.service.resources.bots.BotResource.BotList; import org.openmetadata.service.resources.teams.UserResourceTest; import org.openmetadata.service.util.ResultList; -public class BotResourceTest extends EntityResourceTest { +class BotResourceTest extends EntityResourceTest { public static User botUser; public static EntityReference botUserRef; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/charts/ChartResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/charts/ChartResourceTest.java index 7bec4dfd349..ab10f4ff35c 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/charts/ChartResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/charts/ChartResourceTest.java @@ -40,7 +40,7 @@ import org.openmetadata.service.resources.charts.ChartResource.ChartList; import org.openmetadata.service.util.ResultList; @Slf4j -public class ChartResourceTest extends EntityResourceTest { +class ChartResourceTest extends EntityResourceTest { public ChartResourceTest() { super(Entity.CHART, Chart.class, ChartList.class, "charts", ChartResource.FIELDS); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dashboards/DashboardResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dashboards/DashboardResourceTest.java index 2edac03ad7d..582110c13af 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dashboards/DashboardResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dashboards/DashboardResourceTest.java @@ -54,7 +54,7 @@ import org.openmetadata.service.util.ResultList; import org.openmetadata.service.util.TestUtils; @Slf4j -public class DashboardResourceTest extends EntityResourceTest { +class DashboardResourceTest extends EntityResourceTest { public static EntityReference SUPERSET_INVALID_SERVICE_REFERENCE; public DashboardResourceTest() { diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/DatabaseResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/DatabaseResourceTest.java index c79e039297b..1c5c525c32f 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/DatabaseResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/DatabaseResourceTest.java @@ -47,7 +47,7 @@ import org.openmetadata.service.util.TestUtils; @Slf4j @TestInstance(TestInstance.Lifecycle.PER_CLASS) -public class DatabaseResourceTest extends EntityResourceTest { +class DatabaseResourceTest extends EntityResourceTest { public DatabaseResourceTest() { super(Entity.DATABASE, Database.class, DatabaseList.class, "databases", DatabaseResource.FIELDS); } diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestDefinitionResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestDefinitionResourceTest.java index 2d3d7d2741c..012a638377f 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestDefinitionResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestDefinitionResourceTest.java @@ -17,7 +17,7 @@ import org.openmetadata.schema.type.TestDefinitionEntityType; import org.openmetadata.service.Entity; import org.openmetadata.service.resources.EntityResourceTest; -public class TestDefinitionResourceTest extends EntityResourceTest { +class TestDefinitionResourceTest extends EntityResourceTest { public TestDefinitionResourceTest() { super( Entity.TEST_DEFINITION, diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/events/WebhookResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/events/WebhookResourceTest.java index 663f73e9332..a0b38c11263 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/events/WebhookResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/events/WebhookResourceTest.java @@ -54,7 +54,7 @@ import org.openmetadata.service.util.JsonUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j -public class WebhookResourceTest extends EntityResourceTest { +class WebhookResourceTest extends EntityResourceTest { public static final List ALL_EVENTS_FILTER = new ArrayList<>(); static { diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryResourceTest.java index 02d86b2bf65..22ddd4f1497 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryResourceTest.java @@ -45,7 +45,7 @@ import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class GlossaryResourceTest extends EntityResourceTest { +class GlossaryResourceTest extends EntityResourceTest { public GlossaryResourceTest() { super(Entity.GLOSSARY, Glossary.class, GlossaryResource.GlossaryList.class, "glossaries", GlossaryResource.FIELDS); } diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryTermResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryTermResourceTest.java index 0edfed525d4..c514cf740b5 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryTermResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/glossary/GlossaryTermResourceTest.java @@ -74,7 +74,7 @@ import org.openmetadata.service.util.ResultList; import org.openmetadata.service.util.TestUtils; @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class GlossaryTermResourceTest extends EntityResourceTest { +class GlossaryTermResourceTest extends EntityResourceTest { public GlossaryTermResourceTest() { super( Entity.GLOSSARY_TERM, diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/metadata/TypeResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/metadata/TypeResourceTest.java index 1217d5253d3..b53d25ee628 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/metadata/TypeResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/metadata/TypeResourceTest.java @@ -57,7 +57,7 @@ import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class TypeResourceTest extends EntityResourceTest { +class TypeResourceTest extends EntityResourceTest { public TypeResourceTest() { super(Entity.TYPE, Type.class, TypeList.class, "metadata/types", TypeResource.PROPERTIES); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/mlmodels/MlModelResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/mlmodels/MlModelResourceTest.java index d4af0286845..98e885b4783 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/mlmodels/MlModelResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/mlmodels/MlModelResourceTest.java @@ -65,7 +65,7 @@ import org.openmetadata.service.util.TestUtils; @Slf4j @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class MlModelResourceTest extends EntityResourceTest { +class MlModelResourceTest extends EntityResourceTest { public static final String ALGORITHM = "regression"; public static Dashboard DASHBOARD; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/policies/PolicyResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/policies/PolicyResourceTest.java index 4b7b6d6561d..aa35f59ef02 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/policies/PolicyResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/policies/PolicyResourceTest.java @@ -78,7 +78,7 @@ import org.openmetadata.service.util.JsonUtils; import org.openmetadata.service.util.TestUtils; @Slf4j -public class PolicyResourceTest extends EntityResourceTest { +class PolicyResourceTest extends EntityResourceTest { private static final String LOCATION_NAME = "aws-s3"; private static Location location; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/DashboardServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/DashboardServiceResourceTest.java index 66309d862af..ea60a2e93b6 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/DashboardServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/DashboardServiceResourceTest.java @@ -53,7 +53,7 @@ import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j -public class DashboardServiceResourceTest extends EntityResourceTest { +class DashboardServiceResourceTest extends EntityResourceTest { public DashboardServiceResourceTest() { super( Entity.DASHBOARD_SERVICE, diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MessagingServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MessagingServiceResourceTest.java index 2a967edc378..0067ab06ddf 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MessagingServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MessagingServiceResourceTest.java @@ -46,7 +46,7 @@ import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j -public class MessagingServiceResourceTest extends EntityResourceTest { +class MessagingServiceResourceTest extends EntityResourceTest { public static final String KAFKA_BROKERS = "192.168.1.1:0"; public static URI SCHEMA_REGISTRY_URL; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java index 98f2dd9d500..8cfecbc68dc 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java @@ -42,7 +42,7 @@ import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j -public class MlModelServiceResourceTest extends EntityResourceTest { +class MlModelServiceResourceTest extends EntityResourceTest { public MlModelServiceResourceTest() { super(Entity.MLMODEL_SERVICE, MlModelService.class, MlModelServiceList.class, "services/mlmodelServices", "owner"); this.supportsPatch = false; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java index 5011f97fe6a..777b8cb0655 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java @@ -31,7 +31,7 @@ import org.openmetadata.service.resources.services.storage.StorageServiceResourc import org.openmetadata.service.util.TestUtils; @Slf4j -public class StorageServiceResourceTest extends EntityResourceTest { +class StorageServiceResourceTest extends EntityResourceTest { public StorageServiceResourceTest() { super(Entity.STORAGE_SERVICE, StorageService.class, StorageServiceList.class, "services/storageServices", "owner"); this.supportsPatch = false; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java index ce190a2ea84..5be17766174 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceTest.java @@ -72,7 +72,7 @@ import org.openmetadata.service.util.TestUtils; @Slf4j @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class IngestionPipelineResourceTest extends EntityResourceTest { +class IngestionPipelineResourceTest extends EntityResourceTest { public static SourceConfig DATABASE_METADATA_CONFIG; public static SourceConfig DASHBOARD_METADATA_CONFIG; public static SourceConfig MESSAGING_METADATA_CONFIG; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceUnitTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceUnitTest.java index f4e053f26d7..c6cddae2313 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceUnitTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResourceUnitTest.java @@ -64,7 +64,7 @@ import org.openmetadata.service.security.Authorizer; import org.openmetadata.service.util.PipelineServiceClient; @ExtendWith(MockitoExtension.class) -public class IngestionPipelineResourceUnitTest { +class IngestionPipelineResourceUnitTest { private static final UUID DAG_ID = UUID.randomUUID(); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/RoleResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/RoleResourceTest.java index b3636d5ae52..e9c9139de91 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/RoleResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/RoleResourceTest.java @@ -51,7 +51,7 @@ import org.openmetadata.service.util.JsonUtils; import org.openmetadata.service.util.TestUtils; @Slf4j -public class RoleResourceTest extends EntityResourceTest { +class RoleResourceTest extends EntityResourceTest { public RoleResourceTest() { super(Entity.ROLE, Role.class, RoleList.class, "roles", null); this.supportsAuthorizedMetadataOperations = false; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/TeamResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/TeamResourceTest.java index d0a2a81312f..75623cc9521 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/TeamResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/TeamResourceTest.java @@ -98,7 +98,7 @@ import org.openmetadata.service.util.TestUtils; import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j -public class TeamResourceTest extends EntityResourceTest { +class TeamResourceTest extends EntityResourceTest { final Profile PROFILE = new Profile().withImages(new ImageList().withImage(URI.create("http://image.com"))); public TeamResourceTest() { diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java index 07f483cb4c1..425845ae5a2 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java @@ -113,7 +113,7 @@ import org.openmetadata.service.util.TestUtils.UpdateType; @Slf4j @TestMethodOrder(MethodOrderer.OrderAnnotation.class) -public class UserResourceTest extends EntityResourceTest { +class UserResourceTest extends EntityResourceTest { final Profile PROFILE = new Profile().withImages(new ImageList().withImage(URI.create("http://image.com"))); public UserResourceTest() { diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/util/UtilResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/util/UtilResourceTest.java index 5f226e19a7a..341b60a1346 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/util/UtilResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/util/UtilResourceTest.java @@ -68,7 +68,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest { } @Test - public void entitiesCount(TestInfo test) throws HttpResponseException { + void entitiesCount(TestInfo test) throws HttpResponseException { // Get count before adding entities int beforeTableCount = getEntitiesCount().getTableCount(); @@ -143,7 +143,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest { } @Test - public void servicesCount(TestInfo test) throws HttpResponseException { + void servicesCount(TestInfo test) throws HttpResponseException { // Get count before adding services int beforeMessagingServiceCount = getServicesCount().getMessagingServiceCount(); @@ -190,7 +190,7 @@ public class UtilResourceTest extends OpenMetadataApplicationTest { } @Test - public void botUserCountCheck(TestInfo test) throws HttpResponseException { + void botUserCountCheck(TestInfo test) throws HttpResponseException { int beforeUserCount = getEntitiesCount().getUserCount(); // Create a bot user. diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSSMSecretsManagerTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSSMSecretsManagerTest.java index 9bf0f46198d..fa8174694c7 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSSMSecretsManagerTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSSMSecretsManagerTest.java @@ -40,7 +40,7 @@ import software.amazon.awssdk.services.ssm.model.Parameter; import software.amazon.awssdk.services.ssm.model.ParameterType; import software.amazon.awssdk.services.ssm.model.PutParameterRequest; -public class AWSSSMSecretsManagerTest extends ExternalSecretsManagerTest { +class AWSSSMSecretsManagerTest extends ExternalSecretsManagerTest { @Mock private SsmClient ssmClient; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSecretsManagerTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSecretsManagerTest.java index 7044396dcf7..0d869d20466 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSecretsManagerTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/AWSSecretsManagerTest.java @@ -37,7 +37,7 @@ import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueReques import software.amazon.awssdk.services.secretsmanager.model.GetSecretValueResponse; import software.amazon.awssdk.services.secretsmanager.model.UpdateSecretRequest; -public class AWSSecretsManagerTest extends ExternalSecretsManagerTest { +class AWSSecretsManagerTest extends ExternalSecretsManagerTest { @Mock private SecretsManagerClient secretsManagerClient; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/NoopSecretsManagerTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/NoopSecretsManagerTest.java index 5526b30c2ac..e30bdd618a0 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/NoopSecretsManagerTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/NoopSecretsManagerTest.java @@ -48,7 +48,7 @@ import org.openmetadata.schema.type.EntityReference; import org.openmetadata.service.fernet.Fernet; @ExtendWith(MockitoExtension.class) -public class NoopSecretsManagerTest { +class NoopSecretsManagerTest { private static final boolean ENCRYPT = true; private static final boolean DECRYPT = false; @@ -115,7 +115,7 @@ public class NoopSecretsManagerTest { @ParameterizedTest @MethodSource( "org.openmetadata.service.resources.services.ingestionpipelines.IngestionPipelineResourceUnitTestParams#params") - public void testEncryptAndDecryptDbtConfigSource( + void testEncryptAndDecryptDbtConfigSource( Object config, EntityReference service, Class serviceClass, diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/SecretsManagerFactoryTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/SecretsManagerFactoryTest.java index d6a9ffb16d2..e6c765debb3 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/secrets/SecretsManagerFactoryTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/secrets/SecretsManagerFactoryTest.java @@ -19,7 +19,7 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import org.openmetadata.schema.services.connections.metadata.SecretsManagerProvider; -public class SecretsManagerFactoryTest { +class SecretsManagerFactoryTest { private SecretsManagerConfiguration config; diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/security/policyevaluator/PolicyEvaluatorTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/security/policyevaluator/PolicyEvaluatorTest.java index 2afa990a7bd..e67656d20e0 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/security/policyevaluator/PolicyEvaluatorTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/security/policyevaluator/PolicyEvaluatorTest.java @@ -7,7 +7,7 @@ import org.openmetadata.schema.type.Permission.Access; class PolicyEvaluatorTest { @Test - public void test_AccessOrderOfPrecedence() { + void test_AccessOrderOfPrecedence() { // // Order of precedence for access Deny > Allow > ConditionalDeny > ConditionalAllow > NotAllow // diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/util/LoginAttemptCacheTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/util/LoginAttemptCacheTest.java index 5bcb090af22..c6237a4854f 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/util/LoginAttemptCacheTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/util/LoginAttemptCacheTest.java @@ -8,7 +8,7 @@ import org.junit.jupiter.api.Test; import org.openmetadata.service.security.auth.LoginAttemptCache; @Slf4j -public class LoginAttemptCacheTest { +class LoginAttemptCacheTest { @Test void testFailedLogin() throws InterruptedException { String testKey = "test";