From 24ff5562db1a02c080da1cfd19de6922824c725e Mon Sep 17 00:00:00 2001
From: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
Date: Tue, 6 Dec 2022 15:34:01 +0530
Subject: [PATCH] Fix : Do not render the slack chat component directly as
 child of router switch (#9166)

---
 .../resources/ui/src/router/AppRouter.tsx     | 68 ++++++++++---------
 1 file changed, 37 insertions(+), 31 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/router/AppRouter.tsx b/openmetadata-ui/src/main/resources/ui/src/router/AppRouter.tsx
index e301aa48b12..fb6083f2941 100644
--- a/openmetadata-ui/src/main/resources/ui/src/router/AppRouter.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/router/AppRouter.tsx
@@ -137,42 +137,48 @@ const AppRouter = () => {
   }
 
   return (
-    <Switch>
+    <>
       {slackChat}
-      <Route exact component={SigninPage} path={ROUTES.SIGNIN} />
-      {callbackComponent ? (
-        <Route component={callbackComponent} path={ROUTES.CALLBACK} />
-      ) : null}
+      <Switch>
+        <Route exact component={SigninPage} path={ROUTES.SIGNIN} />
+        {callbackComponent ? (
+          <Route component={callbackComponent} path={ROUTES.CALLBACK} />
+        ) : null}
 
-      <Route exact path={ROUTES.HOME}>
-        {!isAuthenticated && !isSigningIn ? (
+        <Route exact path={ROUTES.HOME}>
+          {!isAuthenticated && !isSigningIn ? (
+            <>
+              <Redirect to={ROUTES.SIGNIN} />
+            </>
+          ) : (
+            <Redirect to={ROUTES.MY_DATA} />
+          )}
+        </Route>
+
+        {isBasicAuthProvider && (
           <>
-            <Redirect to={ROUTES.SIGNIN} />
+            <Route exact component={BasicSignupPage} path={ROUTES.REGISTER} />
+            <Route
+              exact
+              component={ForgotPassword}
+              path={ROUTES.FORGOT_PASSWORD}
+            />
+            <Route
+              exact
+              component={ResetPassword}
+              path={ROUTES.RESET_PASSWORD}
+            />
+            <Route
+              exact
+              component={AccountActivationConfirmation}
+              path={ROUTES.ACCOUNT_ACTIVATION}
+            />
           </>
-        ) : (
-          <Redirect to={ROUTES.MY_DATA} />
         )}
-      </Route>
-
-      {isBasicAuthProvider && (
-        <>
-          <Route exact component={BasicSignupPage} path={ROUTES.REGISTER} />
-          <Route
-            exact
-            component={ForgotPassword}
-            path={ROUTES.FORGOT_PASSWORD}
-          />
-          <Route exact component={ResetPassword} path={ROUTES.RESET_PASSWORD} />
-          <Route
-            exact
-            component={AccountActivationConfirmation}
-            path={ROUTES.ACCOUNT_ACTIVATION}
-          />
-        </>
-      )}
-      {isAuthenticated && <AuthenticatedAppRouter />}
-      <Route exact component={PageNotFound} path={ROUTES.NOT_FOUND} />
-    </Switch>
+        {isAuthenticated && <AuthenticatedAppRouter />}
+        <Route exact component={PageNotFound} path={ROUTES.NOT_FOUND} />
+      </Switch>
+    </>
   );
 };