#15236: fix redundent scrollbars on UI (#15779)

* fix redundent scrollbars on UI

* minor optimizaion
This commit is contained in:
Ashish Gupta 2024-04-04 10:54:29 +05:30 committed by GitHub
parent b2c72cb86f
commit 25a256f601
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
13 changed files with 46 additions and 47 deletions

View File

@ -155,7 +155,9 @@ const TaskFeedCard = ({
)} )}
data-testid="task-feed-card"> data-testid="task-feed-card">
<Row gutter={[0, 8]}> <Row gutter={[0, 8]}>
<Col className="d-flex items-center" span={24}> <Col
className="d-flex items-center task-feed-message-container"
span={24}>
<Icon <Icon
className="m-r-xs" className="m-r-xs"
component={ component={

View File

@ -22,16 +22,3 @@
margin-right: 4px; margin-right: 4px;
} }
} }
.task-feed-message {
height: 100%;
display: flex;
align-items: center;
flex-wrap: wrap;
&:hover {
.ant-typography {
color: @primary-color;
}
}
}

View File

@ -35,6 +35,7 @@
border-left: @global-border; border-left: @global-border;
height: @entity-details-tab-height; height: @entity-details-tab-height;
overflow-y: scroll; overflow-y: scroll;
overflow-x: hidden;
} }
} }

View File

@ -50,7 +50,7 @@
padding-right: 1px !important; padding-right: 1px !important;
} }
.data-quality-content-panel { .data-quality-content-panel {
overflow: scroll; overflow-y: scroll;
} }
} }
.sql-editor-container { .sql-editor-container {

View File

@ -251,14 +251,14 @@ const QueryCard: FC<QueryCardProp> = ({
/> />
</div> </div>
<Row align="middle" className="p-y-md border-top"> <Row align="middle" className="p-y-md border-top">
<Col className="p-l-md" span={16}> <Col className="p-l-md" span={20}>
<QueryUsedByOtherTable <QueryUsedByOtherTable
isEditMode={isEditMode} isEditMode={isEditMode}
query={query} query={query}
onChange={(value) => setSelectedTables(value)} onChange={(value) => setSelectedTables(value)}
/> />
</Col> </Col>
<Col span={8}> <Col span={4}>
{isEditMode && ( {isEditMode && (
<Space <Space
align="end" align="end"

View File

@ -10,7 +10,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
import { Popover, Space, Typography } from 'antd'; import { Col, Popover, Row, Space, Typography } from 'antd';
import { DefaultOptionType } from 'antd/lib/select'; import { DefaultOptionType } from 'antd/lib/select';
import { isArray, isUndefined, slice, uniqBy } from 'lodash'; import { isArray, isUndefined, slice, uniqBy } from 'lodash';
import React, { useEffect, useMemo, useState } from 'react'; import React, { useEffect, useMemo, useState } from 'react';
@ -171,7 +171,7 @@ const QueryUsedByOtherTable = ({
) : ( ) : (
<AsyncSelect <AsyncSelect
api={fetchTableEntity} api={fetchTableEntity}
className="w-min-15" className="w-min-15 w-full"
data-testid="edit-query-used-in" data-testid="edit-query-used-in"
defaultValue={defaultValue} defaultValue={defaultValue}
mode="multiple" mode="multiple"
@ -192,10 +192,12 @@ const QueryUsedByOtherTable = ({
}, [isEditMode]); }, [isEditMode]);
return ( return (
<Space className="m-b-0" data-testid="para-container"> <Row wrap data-testid="para-container">
<Text>{`${t('message.query-used-by-other-tables')}:`}</Text> <Col flex="200px">
{isEditMode ? selectList : tableNames} <Text>{`${t('message.query-used-by-other-tables')}:`}</Text>
</Space> </Col>
<Col>{isEditMode ? selectList : tableNames}</Col>
</Row>
); );
}; };

View File

@ -81,7 +81,7 @@ const TableQueryRightPanel = ({
{isLoading ? ( {isLoading ? (
<Loader /> <Loader />
) : ( ) : (
<Row className="m-y-md p-x-md" gutter={[16, 40]}> <Row className="m-y-md p-x-md w-full" gutter={[16, 40]}>
<Col span={24}> <Col span={24}>
<Space className="relative" direction="vertical" size={4}> <Space className="relative" direction="vertical" size={4}>
<Space align="center" className="w-full" size={0}> <Space align="center" className="w-full" size={0}>

View File

@ -751,7 +751,9 @@ export const TaskTab = ({
return ( return (
<Row className="p-y-sm p-x-md" data-testid="task-tab" gutter={[0, 24]}> <Row className="p-y-sm p-x-md" data-testid="task-tab" gutter={[0, 24]}>
<Col className="d-flex items-center" span={24}> <Col
className="d-flex items-center task-feed-message-container"
span={24}>
<Icon <Icon
className="m-r-xs" className="m-r-xs"
component={ component={

View File

@ -18,16 +18,3 @@
width: 100%; width: 100%;
} }
} }
.task-feed-message {
height: 100%;
display: flex;
align-items: center;
flex-wrap: wrap;
&:hover {
.ant-typography {
color: @primary-color;
}
}
}

View File

@ -184,7 +184,9 @@ const TotalDataAssetsWidget = ({
</div> </div>
</Col> </Col>
{isWidgetSizeLarge && ( {isWidgetSizeLarge && (
<Col className="overflow-y-scroll h-max-full" span={10}> <Col
className="overflow-y-scroll overflow-x-hidden h-max-full"
span={10}>
<TotalEntityInsightSummary <TotalEntityInsightSummary
entities={entities} entities={entities}
latestData={latestData} latestData={latestData}

View File

@ -754,3 +754,20 @@ a[href].link-text-grey,
right: 20px; right: 20px;
z-index: 1001; z-index: 1001;
} }
// Task Feed Message Container
.task-feed-message-container {
.task-feed-message {
height: 100%;
display: flex;
align-items: center;
flex-wrap: wrap;
&:hover {
.ant-typography {
color: @primary-color;
}
}
}
}

View File

@ -302,11 +302,3 @@
.max-width-md { .max-width-md {
max-width: 768px; max-width: 768px;
} }
.overflow-y-scroll {
overflow-y: scroll;
}
.overflow-x-scroll {
overflow-x: scroll;
}

View File

@ -17,6 +17,13 @@
.overflow-y-scroll { .overflow-y-scroll {
overflow-y: scroll; overflow-y: scroll;
} }
.overflow-x-scroll {
overflow-x: scroll;
}
.overflow-x-hidden {
overflow-x: hidden;
}
.overflow-wrap-anywhere { .overflow-wrap-anywhere {
overflow-wrap: anywhere; overflow-wrap: anywhere;
} }