From 25d9759967fe9dba29e61a613dcf901bb3e39c7f Mon Sep 17 00:00:00 2001 From: Pere Miquel Brull Date: Tue, 3 Jun 2025 12:17:14 +0200 Subject: [PATCH] FIX - Automation Workflows should not be updated by the SM & cleanup migration (#21435) Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com> (cherry picked from commit e58802b659c87afc1e18e92cfe50cdfc4c769dce) --- .../sql/migrations/native/1.7.2/mysql/schemaChanges.sql | 2 ++ .../migrations/native/1.7.2/postgres/schemaChanges.sql | 2 ++ .../service/secrets/SecretsManagerUpdateService.java | 9 --------- 3 files changed, 4 insertions(+), 9 deletions(-) create mode 100644 bootstrap/sql/migrations/native/1.7.2/mysql/schemaChanges.sql create mode 100644 bootstrap/sql/migrations/native/1.7.2/postgres/schemaChanges.sql diff --git a/bootstrap/sql/migrations/native/1.7.2/mysql/schemaChanges.sql b/bootstrap/sql/migrations/native/1.7.2/mysql/schemaChanges.sql new file mode 100644 index 00000000000..29513e5208e --- /dev/null +++ b/bootstrap/sql/migrations/native/1.7.2/mysql/schemaChanges.sql @@ -0,0 +1,2 @@ +-- cleanup dangling test connections +truncate automations_workflow; diff --git a/bootstrap/sql/migrations/native/1.7.2/postgres/schemaChanges.sql b/bootstrap/sql/migrations/native/1.7.2/postgres/schemaChanges.sql new file mode 100644 index 00000000000..29513e5208e --- /dev/null +++ b/bootstrap/sql/migrations/native/1.7.2/postgres/schemaChanges.sql @@ -0,0 +1,2 @@ +-- cleanup dangling test connections +truncate automations_workflow; diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/secrets/SecretsManagerUpdateService.java b/openmetadata-service/src/main/java/org/openmetadata/service/secrets/SecretsManagerUpdateService.java index 30ce9132598..4126a76211a 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/secrets/SecretsManagerUpdateService.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/secrets/SecretsManagerUpdateService.java @@ -76,7 +76,6 @@ public class SecretsManagerUpdateService { updateServices(); updateBotUsers(); updateIngestionPipelines(); - updateWorkflows(); } private void updateServices() { @@ -103,14 +102,6 @@ public class SecretsManagerUpdateService { retrieveIngestionPipelines().forEach(this::updateIngestionPipeline); } - private void updateWorkflows() { - LOG.info( - String.format( - "Updating workflows in case of an update on the JSON schema: [%s]", - secretManager.getSecretsManagerProvider().value())); - retrieveWorkflows().forEach(this::updateWorkflow); - } - private void updateService(ServiceEntityInterface serviceEntityInterface) { ServiceEntityRepository repository = connectionTypeRepositoriesMap.get(serviceEntityInterface.getConnection().getClass());