From 269d967b2ddbbf78aefedd5f55589609c69d2703 Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Fri, 13 Jun 2025 03:17:03 +0530 Subject: [PATCH] Fix: #21729 Test Cases Not Returned When Service Name Contains Spaces (#21737) --- .../Features/TestSuiteMultiPipeline.spec.ts | 8 +++---- .../playwright/support/entity/TableClass.ts | 22 ++++++++++++------- .../components/AddTestSuitePipeline.tsx | 4 ++-- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TestSuiteMultiPipeline.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TestSuiteMultiPipeline.spec.ts index 8e6300c8a5c..fd2a2da7a61 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TestSuiteMultiPipeline.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TestSuiteMultiPipeline.spec.ts @@ -26,9 +26,9 @@ test( await redirectToHomePage(page); const { apiContext, afterAction } = await getApiContext(page); - const table = new TableClass(); + const table = new TableClass(`multi pipeline !@#$%^&*()_-+=test-${uuid()}`); await table.create(apiContext); - await table.visitEntityPage(page); + await table.visitEntityPage(page, table.entity.name); const testCaseName = `multi-pipeline-test-${uuid()}`; const pipelineName = `test suite pipeline 2`; @@ -193,7 +193,7 @@ test( await redirectToHomePage(page); const { apiContext, afterAction } = await getApiContext(page); - const table = new TableClass(); + const table = new TableClass(`multi pipeline !@#$%^&*()_-+=test-${uuid()}`); await table.create(apiContext); for (let index = 0; index < 4; index++) { await table.createTestCase(apiContext); @@ -206,7 +206,7 @@ test( apiContext, testCaseNames ); - await table.visitEntityPage(page); + await table.visitEntityPage(page, table.entity.name); await page.getByText('Data Observability').click(); await page.getByRole('menuitem', { name: 'Data Quality' }).click(); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts b/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts index e4af79d85a3..db518d37927 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts @@ -158,19 +158,25 @@ export class TableClass extends EntityClass { data: this.service, } ); + const service = await serviceResponse.json(); + const databaseResponse = await apiContext.post('/api/v1/databases', { - data: this.database, + data: { ...this.database, service: service.fullyQualifiedName }, }); + const database = await databaseResponse.json(); + const schemaResponse = await apiContext.post('/api/v1/databaseSchemas', { - data: this.schema, + data: { ...this.schema, database: database.fullyQualifiedName }, }); + const schema = await schemaResponse.json(); + const entityResponse = await apiContext.post('/api/v1/tables', { - data: this.entity, + data: { + ...this.entity, + databaseSchema: schema.fullyQualifiedName, + }, }); - const service = await serviceResponse.json(); - const database = await databaseResponse.json(); - const schema = await schemaResponse.json(); const entity = await entityResponse.json(); this.serviceResponseData = service; @@ -220,10 +226,10 @@ export class TableClass extends EntityClass { }; } - async visitEntityPage(page: Page) { + async visitEntityPage(page: Page, searchTerm?: string) { await visitEntityPage({ page, - searchTerm: this.entityResponseData?.['fullyQualifiedName'], + searchTerm: searchTerm ?? this.entityResponseData?.['fullyQualifiedName'], dataTestId: `${this.service.name}-${this.entity.name}`, }); } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/AddTestSuitePipeline.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/AddTestSuitePipeline.tsx index 0d1f392e2af..09d012eb5cf 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/AddTestSuitePipeline.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/components/AddTestSuitePipeline.tsx @@ -182,9 +182,9 @@ const AddTestSuitePipeline = ({